VladPolskiy/webmin
1
0
Fork 0
mirror of https://github.com/webmin/webmin.git synced 2025-07-23 00:30:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Command to show in the UI should not be escaped, but the actual command must be

Browse Source
This commit is contained in:
Jamie Cameron
2022-07-10 16:59:09 -07:00
parent 13f7bf9621
commit d8e91f731e
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
software/yum-lib.pl
View File

@ -38,7 +38,7 @@ local @names = map { &append_architectures($_) } split(/\s+/, $update);
if (@names == 1) {
@names = ( $update );
}
$update = join(" ", @names);
$update = join(" ", map { quotemeta($_) } @names);
# Work out command to use - for DNF, upgrades need to use the update command
local $cmd;
@ -56,6 +56,7 @@ else {
}
# Work out the command to run, which may enable some repos
my $uicmd = "$yum_command $enable -y $cmd ".join(" ", @names);
my $fullcmd = "$yum_command $enable -y $cmd $update";
foreach my $u (@updates) {
my $repo = &update_system_repo($u);
@ -64,7 +65,7 @@ foreach my $u (@updates) {
}
}
print "<b>",&text('yum_install', "<tt>".&html_escape($fullcmd)."</tt>"),"</b><p>\n";
print "<b>",&text('yum_install', "<tt>".&html_escape($uicmd)."</tt>"),"</b><p>\n";
print "<pre>";
&additional_log('exec', undef, $fullcmd);
$SIG{'TERM'} = 'ignore'; # Installing webmin itself may kill this script