VladPolskiy/postgres-web
1
0
Fork 0
mirror of https://github.com/postgres/pgweb.git synced 2025-07-29 11:59:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't send notifications for new objects that are tri-state moderation

Browse Source 
These will get a notification when they are explicitly submitted for
moderation, so there is no point in having a separate notice sent when
they're created, since there is nothing for the moderators to do at that
point.
This commit is contained in:
Magnus Hagander
2020-09-10 20:47:19 +02:00
parent b59090f865
commit 4c95ad1878
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pgweb/util/helpers.py
View File

@ -80,8 +80,14 @@ def simple_form(instancetype, itemid, request, formclass, formtemplate='base/for
# bother notifying about the changes. But if it lacks this field, we notify
# about everything, as well as if the field exists and the item has already
# been approved.
# Newly added objects are always notified.
if not is_new:
# Newly added objects are always notified if they are two-state, but not if they
# are tri-state (in which case they get notified when submitted for
# moderation).
if is_new:
if hasattr(instance, 'modstate'):
# Tri-state indicated by the existence of the modstate field
do_notify = False
else:
if hasattr(instance, 'approved'):
if not getattr(instance, 'approved', True):
do_notify = False