In order to remove any confusion if the user has duplicate `renderd` sections in their `renderd.conf` file.
Currently with a configuration like this one:
```ini
[renderd]
pid_file=/run/renderd/renderd.pid
socketname=/run/renderd/renderd.sock
stats_file=/run/renderd/renderd.stats
tile_dir=/var/cache/renderd/tiles
[renderd0]
pid_file=/run/renderd/renderd0.pid
socketname=/run/renderd/renderd0.sock
stats_file=/run/renderd/renderd0.stats
tile_dir=/var/cache/renderd/tiles
```
only the second `renderd` section (`renderd0`) will actually be used.
After this patch is merged, an error message will be shown and the application will exit.
* Fixed `render_list` build needs `libm`
* Added tests
* Updated man page
* Created function to set double
* Cleaned up / optimized a bit
* Removed `--dont-render` option
So that workflows will still show as passing when issues arise.
* Build & Test
* debian:unstable
* fedora:rawhide
* ubuntu:devel
* Docker Image Build
* debian-unstable/debian-unstable-autotools
* fedora-rawhide
* opensuse-tumbleweed
* ubuntu-devel/ubuntu-devel-autotools
* Previously it was not actually sending the header
* Now runs in serial, regardless of parallel specification
* Now runs only once, rather than for each map layer
_Also_:
* Removed no-longer used `storage_mutex`
* Was only used for Apache HTTP Server < v2.4
_Also updated all render\_* apps to_:
* Use `MAX_ZOOM` rather than hard-coded values for `--max-zoom`
* Print `metatile` rather than `meta tile`
* Add missing `--help` output to `render_expired` & `render_list`
* Remove redundant `--help` output from `render_list`
_Also_:
* Use `mapnik::freetype_engine::register_fonts` in `gen_tile.cpp` rather than recursing manually
* Available since `Mapnik` v2 which is no longer supported
* Add support for reading `renderd.conf` to `render_expired`
* Add support for reading `renderd.conf` to `render_list`
* Add support for reading `renderd.conf` to `render_old`
* Add support for reading `renderd.conf` to `render_speedtest`
* Move renderd/render_* execution tests to own files
* Reduce variable scope & minor clean up
* Use `stat` rather than `access` to check if file exists
* Add tests for `ModTileCacheExtendedHostName` and expired tileOld/TileVeryOld
* Add tests for `ModTileEnableTileThrottling`/`ModTileEnableTileThrottlingXForward`
* Improve service startup "tests"
* Address intermittent download test failure
* Caused by load exceeding threshold
* Add more missing bad HTTPD config tests
* Allow for newer `libpng` with Docker tests
* Also test more image/file types
And setting it to `0`, no longer requiring defining it everywhere except in foreground executables as needed.
_Also_:
* Require `GLib` >= `v2.50`
* Needed for [g_log_writer_standard_streams](https://docs.gtk.org/glib/func.log_writer_standard_streams.html)
* Set FreeBSD job `BUILD_PARALLEL_LEVEL` & `TEST_PARALLEL_LEVEL` environment variables via `run`
* Rather than hard-coding them
_Also_:
* Added checks for `min` & `max` `x`, `y` & `z` tile coordinate options in order to:
* Ensure they are integers
* Ensure they are positive
Resolves#387
* Report coverage for almost all jobs
* Some jobs fail and are omitted
* Add more tests to `gen_tile_test.cpp`
* Also lightly cleaned up formatting
* Clean up cmake/* files
* So they don't report an empty version
* Remove commented `check_*` lines from `CMakeLists.txt` file
* These were left over from the initial CMake support implementation
* `includes/config.h.in`
* Wrap contents in `#ifndef CONFIG_H`
* `includes/mod_tile.h`
* Include `protocol.h`
* For `XMLCONFIG_MAX`
* Include `apr_tables.h`
* For `apr_array_header_t`/`apr_time_t`/`apr_uint64_t`
* Include `netinet/in.h`
* For `in6_addr`/`in_addr_t`
* `src/cache_expire.c`
* Include `netinet/in.h`
* For `htonl`/`htons`
* `src/gen_tile.cpp`
* Use `snprintf` instead of `sprintf`
* To resolve `warning: 'sprintf' is deprecated` in [`macOS` builds](https://github.com/openstreetmap/mod_tile/actions/runs/7590268635/job/20677236621#step:5:579)
* `src/gen_tile_test.cpp`
* Use `snprintf` instead of `sprintf`
* To resolve `warning: 'sprintf' is deprecated` in [`macOS` builds](https://github.com/openstreetmap/mod_tile/actions/runs/7590268635/job/20677236621#step:5:579)
* `src/mod_tile.c`
* Use `snprintf` instead of `sprintf`
* To resolve `warning: 'sprintf' is deprecated` in [`macOS` builds](https://github.com/openstreetmap/mod_tile/actions/runs/7590268635/job/20677236621#step:5:579)
* Cast `os_thread` to `(unsigned long)` in `ap_log_rerror` calls format
* To resolve `warning: format specifies type 'long' but the argument has type 'apr_os_thread_t'`
* `os_thread` is an alias of `unsigned long`
* Use `"%" APR_OFF_T_FMT`/`APR_UINT64_T_FMT "..."` to resolve warnings under `macOS`
* To resolve `warning: format specifies type 'long' but the argument has type 'off_t'`
* The format/type for `apr_off_t` varies under `macOS`
* See [here](8e68a77f61/include/apr.h.in (L610-L645))
* And resolve `warning: format specifies type 'long' but the argument has type 'apr_uint64_t'`
* The format/type for `apr_uint64_t` varies under `macOS`
* See [here](8e68a77f61/include/apr.h.in (L610-L645))
* Divide by `2.0` rather than `2`
* To resolve `possible loss of precision` warning
* Use `%li` rather than `"%" APR_TIME_T_FMT` as format for `maxAge`
* It is defined as a `long int`
* `src/render_submit_queue.c`
* Include `string.h`/`strings.h`
* To resolve `warning: call to undeclared library function 'bzero'`
* To resolve `warning: call to undeclared library function 'strncpy'`
* To resolve `warning: call to undeclared library function 'strdup'`
* To resolve `warning: call to undeclared library function 'strerror'`
* To resolve `warning: call to undeclared library function 'strchr'`
* To resolve `warning: call to undeclared library function 'strlen'`
* To resolve `warning: call to undeclared library function 'memset'`
* Cast `performance_stats.stat[i].noRendered` to `(float)`
* To resolve `possible loss of precision` warning
* `src/renderd.c`
* Use `snprintf` instead of `sprintf`
* To resolve `warning: 'sprintf' is deprecated` in [`macOS` builds](https://github.com/openstreetmap/mod_tile/actions/runs/7590268635/job/20677236621#step:5:579)
* Change `const char` to `char` for `ini_fileExtension`, `ini_mimeType`, `ini_outputFormat`
* To resolve `warning: format specifies type 'char *' but the argument has type 'const char *'`
* `src/request_queue.c`
* Add `default case` to `switch` statements
* To resolve:
* `warning: enumeration values 'queueRender' and 'queueDuplicate' not handled in switch`
* `warning: enumeration values 'cmdIgnore', 'cmdDone', and 'cmdNotDone' not handled in switch`
* `src/store_file.c`
* Cast `pthread_self()` to `(unsigned long)`
* To resolve `warning: format specifies type 'unsigned long' but the argument has type 'pthread_t'`
* No longer need `CFLAGS=-Wno-implicit-function-declaration`
* Run tests in parallel in some `GitHub Actions` Workflows
* Except for `macOS` & `Coverage` jobs
* Update `Node.js 16` actions to `Node.js 20` versions
* `actions/upload-artifact`
* `actions/cache`
* Add server `IP:Port` in `CTest` HTTPD logs
* Make `render_speedtest_*` CTest tests require tiles to be downloaded
* Add & use tile download functions for CTest
* Including `check` & `remove` "tests"
* To remove much of the redundant code
* Split up HTTPD0/HTTPD1 downloads in CTest
* Remove Amazon Linux 2/CentOS 7 from CI workflow
* Comment out fedora:rawhide, it's not currently working
* Re-enable CentOS Stream tests
* To facilitate running `memcached` tests for all jobs
* `CentOS`/`Debian`/`Fedora` jobs don't seem to like running `memcached` on `localhost`
* `FreeBSD` jobs don't seem to like running `memcached` on `0.0.0.0`
_Also_:
- Changed `AddTileConfig` parsing directive
- From `AP_INIT_RAW_ARGS` to `AP_INIT_TAKE_ARGV`
- Makes code a bit cleaner, e.g.:
- Checking for first two "arguments"
- Iterating "arguments"
- Applied Artistic Style Formatting
- After merging #346
- Added deprecation notice when using `AddTileMimeConfig`
- Enabled commented `AddTileConfig`/`AddTileMimeConfig` tests
_Also_:
- Removed `AddTileMimeConfig` from example `HTTPD` config
- No longer needed after merging #346
- Deprecation notice incoming with #370
- Added additional `AddTileConfig`/`AddTileMimeConfig` tests
- Testing failing download with invalid map name in `httpd.conf`
- Testing parsing invalid `httpd.conf`, e.g.:
- `LoadTileConfigFile` without arguments
- `LoadTileConfigFile` without non-existent file
- Replaced `grep` with `${GREP_EXECUTABLE}` in tests
So that MemcacheD hosts and ports other than `localhost` and `11211` can be used.
_Also_:
- Added `ctest --parallel` execution support
- Added tests for custom `MemcacheD` {host}:{port}
- Added tests for `AddTileConfig`/`AddTileMimeConfig`
AddTileConfig is a shorthand way of adding tile configs without a renderd.conf; if you use mod_tile with tirex, then you will typically not have a renderd.conf and hence rely on AddTileConfig.
AddTileConfig lacks the richness of renderd.conf configuration; you cannot, for example, configure differing max_zooms or file extensions or mime types.
To partly fix this problem, AddTileMimeConfig was introduced which takes one extra argument - misleadingly, not the MIME type, but the file extension, as a third parameter.
This approach is not scalable and difficult to use because of the positional parameters.
This pull request introduces optional key-value pairs for the AddTileConfig directive. You can now write
AddTileConfig /tile tile mimetype=image/jpeg extension=jpg maxzoom=22
to configure your tile layer. Currently, "mimetype", "maxzoom", "minzoom", and "extension" are supported.
This is totally backwards compatible, as old-style AddTileConfig directives will still work like they did before.
The AddTileMimeConfig directive still works but it could be deprecated in favour of this new AddTileConfig syntax.
Co-authored-by: Frederik Ramm <ramm@geofabrik.de>
By taking advantage of `YAML anchors`: https://docs.docker.com/compose/compose-file/10-fragments/
_Also_:
- Added `full` service to `docker/docker-compose.yml` (including real osm data and openstreetmap carto)
- Under `ubuntu-devel-full`
- I.E. (`cd docker && docker compose up ubuntu-devel-full`)
- In order to more fully test
