mirror of
https://gitlab.com/gitlab-org/gitlab-foss.git
synced 2025-07-23 00:47:51 +00:00
Merge branch 'ios-tooltips' into 'master'
Set webkit-overflow-scrolling to auto for children of body. ## What does this MR do? Fixes weird tooltip layering behavior in iOS Safari. See screenshots and/or the original issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/22816 ## Why was this MR needed? Tooltips were cutoff in Safari. ## Screenshots (if relevant) Before:  After:  Also, as part of this fix, I removed applications of `-webkit-overflow-scrolling: auto` in two other places where they're no longer needed. One was the file-holder. I made sure I could reproduce the behavior this was intended to fix, and then made sure this MR still fixed it. Here's the errant behavior:  Here's what it looks like with this MR:  ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? See merge request !6962
This commit is contained in:
@ -131,6 +131,7 @@ Please view this file on the master branch, on stable branches it's out of date.
|
||||
- API: all unknown routing will be handled with 404 Not Found
|
||||
- Add docs for request profiling
|
||||
- Delete dynamic environments
|
||||
- Fix buggy iOS tooltip layering behavior.
|
||||
- Make guests unable to view MRs on private projects
|
||||
|
||||
## 8.12.7
|
||||
|
@ -167,7 +167,6 @@
|
||||
*/
|
||||
&.code {
|
||||
padding: 0;
|
||||
-webkit-overflow-scrolling: auto; // See https://gitlab.com/gitlab-org/gitlab-ce/issues/13987
|
||||
}
|
||||
}
|
||||
}
|
||||
|
@ -27,3 +27,15 @@ body {
|
||||
.container-limited {
|
||||
max-width: $fixed-layout-width;
|
||||
}
|
||||
|
||||
|
||||
/* The following prevents side effects related to iOS Safari's implementation of -webkit-overflow-scrolling: touch,
|
||||
which is applied to the body by jquery.nicescroling plugin to force hardware acceleration for momentum scrolling. Side
|
||||
effects are commonly related to inconsisent z-index behavior (e.g. tooltips). By applying the following to direct children
|
||||
of the body element here, we negate cascading side effects but allow momentum scrolling to be applied to the body */
|
||||
|
||||
.navbar,
|
||||
.page-gutter,
|
||||
.page-with-sidebar {
|
||||
-webkit-overflow-scrolling: auto;
|
||||
}
|
||||
|
@ -52,7 +52,6 @@
|
||||
background: #fff;
|
||||
color: #333;
|
||||
border-radius: 0 0 3px 3px;
|
||||
-webkit-overflow-scrolling: auto;
|
||||
|
||||
.unfold {
|
||||
cursor: pointer;
|
||||
|
Reference in New Issue
Block a user