mirror of
https://gitlab.com/gitlab-org/gitlab-foss.git
synced 2025-07-29 12:00:32 +00:00
Add latest changes from gitlab-org/gitlab@master
This commit is contained in:
23
.gitlab/duo/mr-review-instructions.yaml
Normal file
23
.gitlab/duo/mr-review-instructions.yaml
Normal file
@ -0,0 +1,23 @@
|
||||
---
|
||||
# Custom instructions for GitLab Duo Code Review
|
||||
# Based on GitLab's official code review guidelines
|
||||
|
||||
# References:
|
||||
# - Code Review Guidelines: https://docs.gitlab.com/development/code_review/
|
||||
# - Developer Guide: https://docs.gitlab.com/operator/developer/guide/
|
||||
# - Contributing Guide: https://docs.gitlab.com/development/contributing/
|
||||
|
||||
# This file defines custom review criteria that will be applied to specific files
|
||||
# during merge request reviews. Instructions are grouped by name and can target
|
||||
# multiple file patterns using glob syntax.
|
||||
|
||||
instructions:
|
||||
- name: Test Coverage
|
||||
fileFilters:
|
||||
- "spec/**/*_spec.rb"
|
||||
- "ee/spec/**/*_spec.rb"
|
||||
instructions: |
|
||||
1. Test both happy paths and edge cases
|
||||
2. Include error scenarios
|
||||
3. Use shared examples to reduce duplication
|
||||
4. Ensure proper database cleanup
|
@ -157,7 +157,7 @@ users were not explicitly listed in the approval rules.
|
||||
To get email notifications every time a merge request you're eligible to approve is created:
|
||||
|
||||
- [Set your notification level](../../../profile/notifications.md#edit-notification-settings) to **Custom**
|
||||
and select this event.
|
||||
and select the **Merge request you're eligible to approve is created** event.
|
||||
|
||||
### Group approvers
|
||||
|
||||
|
Reference in New Issue
Block a user