refactor: Apply changes from design review

This commit is contained in:
Peter French
2025-02-24 15:10:40 +01:00
parent bedf3de377
commit f7b117fe49
3 changed files with 35 additions and 24 deletions

View File

@ -5,4 +5,4 @@ canonicalwebteam.yaml-responses==1.2.0
Flask==2.3.3
Jinja2==3.1.4
djlint==1.34.1
canonicalwebteam.image-template==1.4.1
canonicalwebteam.image-template==1.5.0

View File

@ -20,13 +20,26 @@
{% call(slot) vf_hero(
title_text='Make a difference with your designs',
subtitle_text='Passion and curiosity <br />are all you need ',
layout='50/50'
layout='50/50-full-width-image'
) -%}
{%- if slot == 'description' -%}
<p>
Non-code contributions are crucial. Help the community, build your portfolio, and sharpen your skills by sharing your expertise on world-changing open source projects.
</p>
{%- endif -%}
{%- if slot == 'image' -%}
<div class="p-image-container--cinematic is-cover">
{{ image(url="https://assets.ubuntu.com/v1/52415873-hero-img.png",
alt="",
width="3696",
height="1540",
hi_def=True,
loading="auto",
fmt="jpg",
attrs={"class": "p-image-container__image"}) | safe
}}
</div>
{% endif -%}
{% endcall -%}
<section class="p-section">
@ -42,7 +55,7 @@
<div class="p-section--shallow">
<div class="row" role="listitem">
<div class="col-3 col-medium-3">
<p class="p-heading--5">1. Reflect on what skills you have to share</p>
<p class="p-heading--5">1.&nbsp;&nbsp;&nbsp;Reflect on what skills you have to share</p>
</div>
<div class="col-6 col-medium-3">
<p>
@ -55,7 +68,7 @@
<div class="p-section--shallow">
<div class="row" role="listitem">
<div class="col-3 col-medium-3">
<p class="p-heading--5">2. Consider your commitment</p>
<p class="p-heading--5">2.&nbsp;&nbsp;&nbsp;Consider your commitment</p>
</div>
<div class="col-6 col-medium-3">
<p>
@ -68,7 +81,7 @@
<div class="p-section--shallow">
<div class="row" role="listitem">
<div class="col-3 col-medium-3">
<p class="p-heading--5">3. Understand the different types of contributions</p>
<p class="p-heading--5">3.&nbsp;&nbsp;&nbsp;Understand the different types of contributions</p>
</div>
<div class="col-6 col-medium-3">
<p>
@ -81,7 +94,7 @@
<div class="p-section--shallow">
<div class="row" role="listitem">
<div class="col-3 col-medium-3">
<p class="p-heading--5">4. Get familiar with the tools of the trade</p>
<p class="p-heading--5">4.&nbsp;&nbsp;&nbsp;Get familiar with the tools of the trade</p>
</div>
<div class="col-6 col-medium-3">
<p>
@ -94,7 +107,7 @@
<div class="p-section--shallow">
<div class="row" role="listitem">
<div class="col-3 col-medium-3">
<p class="p-heading--5">5. Find your first project</p>
<p class="p-heading--5">5.&nbsp;&nbsp;&nbsp;Find your first project</p>
</div>
<div class="col-6 col-medium-3">
<p>
@ -107,7 +120,7 @@
<div class="p-section--shallow">
<div class="row" role="listitem">
<div class="col-3 col-medium-3">
<p class="p-heading--5">6. Read about the project</p>
<p class="p-heading--5">6.&nbsp;&nbsp;&nbsp;Read about the project</p>
</div>
<div class="col-6 col-medium-3">
<p>
@ -120,7 +133,7 @@
<div class="p-section--shallow">
<div class="row" role="listitem">
<div class="col-3 col-medium-3">
<p class="p-heading--5">7. Understand the assignment</p>
<p class="p-heading--5">7.&nbsp;&nbsp;&nbsp;Understand the assignment</p>
</div>
<div class="col-6 col-medium-3">
<p>
@ -136,7 +149,7 @@
<div class="p-section--shallow">
<div class="row" role="listitem">
<div class="col-3 col-medium-3">
<p class="p-heading--5">8. Have fun and be patient</p>
<p class="p-heading--5">8.&nbsp;&nbsp;&nbsp;Have fun and be patient</p>
</div>
<div class="col-6 col-medium-3">
<p>
@ -149,7 +162,7 @@
<div class="p-section--shallow">
<div class="row" role="listitem">
<div class="col-3 col-medium-3">
<p class="p-heading--5">9. Know your worth</p>
<p class="p-heading--5">9.&nbsp;&nbsp;&nbsp;Know your worth</p>
</div>
<div class="col-6 col-medium-3">
<p>
@ -254,7 +267,7 @@
<div class="row">
<div class="col-3">
<hr class="p-rule--muted u-hide--large" />
<div class="p-image-container--2-3 is-highlighted is-underlined u-hide--medium u-hide--small">
<div class="p-image-container--2-3 is-highlighted is-underlined u-hide--small u-hide--medium">
{{ image(url="https://assets.ubuntu.com/v1/2ebaee6d-create-great-os.png",
alt="",
width="852",
@ -272,7 +285,7 @@
</div>
<div class="col-3">
<hr class="p-rule--muted u-hide--large" />
<div class="p-image-container--2-3 is-highlighted is-underlined u-hide--medium u-hide--small">
<div class="p-image-container--2-3 is-highlighted is-underlined u-hide--small u-hide--medium">
{{ image(url="https://assets.ubuntu.com/v1/e3b8aabb-join-the-osc.png",
alt="",
width="852",
@ -291,7 +304,7 @@
</div>
<div class="col-3">
<hr class="p-rule--muted u-hide--large" />
<div class="p-image-container--2-3 is-highlighted is-underlined u-hide--medium u-hide--small">
<div class="p-image-container--2-3 is-highlighted is-underlined u-hide--small u-hide--medium">
{{ image(url="https://assets.ubuntu.com/v1/a4fb11f0-work-for-canonical.png",
alt="",
width="852",

View File

@ -126,7 +126,7 @@
<div class="p-equal-height-row has-divider-3">
<div class="p-equal-height-row__col">
<div class="p-equal-height-row__item">
<div class="p-image-container--3-2-on-small p-image-container--square-on-medium p-image-container--2-3-on-large">
<div class="p-image-container--3-2-on-small p-image-container--square-on-medium p-image-container--2-3-on-large u-hide--small">
{{ image (
url="https://assets.ubuntu.com/v1/e55d59fa-research-testing.png",
alt="",
@ -153,7 +153,7 @@
</div>
<div class="p-equal-height-row__col">
<div class="p-equal-height-row__item">
<div class="p-image-container--3-2-on-small p-image-container--square-on-medium p-image-container--2-3-on-large">
<div class="p-image-container--3-2-on-small p-image-container--square-on-medium p-image-container--2-3-on-large u-hide--small">
{{ image(url="https://assets.ubuntu.com/v1/ab3113a4-user-flows.png",
alt="",
width="852",
@ -178,7 +178,7 @@
</div>
<div class="p-equal-height-row__col">
<div class="p-equal-height-row__item">
<div class="p-image-container--3-2-on-small p-image-container--square-on-medium p-image-container--2-3-on-large">
<div class="p-image-container--3-2-on-small p-image-container--square-on-medium p-image-container--2-3-on-large u-hide--small">
{{ image(url="https://assets.ubuntu.com/v1/1f8e1bb8-visuals.png",
alt="",
width="852",
@ -201,7 +201,7 @@
</div>
<div class="p-equal-height-row__col">
<div class="p-equal-height-row__item">
<div class="p-image-container--3-2-on-small p-image-container--square-on-medium p-image-container--2-3-on-large">
<div class="p-image-container--3-2-on-small p-image-container--square-on-medium p-image-container--2-3-on-large u-hide--small">
{{ image(url="https://assets.ubuntu.com/v1/298ccdad-design-systems.png",
alt="",
width="852",
@ -271,10 +271,10 @@
}}
</div>
<div class="p-logo-section__item">
{{ image(url="https://assets.ubuntu.com/v1/a0feb2d4-bitcoin_community.svg",
{{ image(url="https://assets.ubuntu.com/v1/150f79be-btc-logo.png",
alt="",
width="62",
height="62",
width="186",
height="312",
hi_def=True,
loading="lazy",
attrs={"class": "p-logo-section__logo"}) | safe
@ -341,9 +341,7 @@
</div>
<div class="col-6">
<div class="p-section--shallow">
<p>
Do you have an open source project that needs design contributions?
</p>
<p>Do you have an open source project that needs design contributions?</p>
</div>
<div class="p-cta-block">
<a href="/sauce">Let us know!</a>