VladPolskiy/apache-http-server
1
0
Fork 0
mirror of https://github.com/apache/httpd.git synced 2025-08-03 16:33:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

change ap_unix_create_privileged_process() to allocate enough space in

Browse Source 
the newargs array to allow for a null terminator.  This allows suexec and
mod_cgid to work together reliably.

Apparently, rounding up the size to a multiple of 8 bytes in apr_palloc
hid the problem sometimes.  At other times, suexec would complain
about a null command name.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92627 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Greg Ames
2001-12-27 19:53:37 +00:00
parent 470adc87c8
commit 652e5b19ce
2 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
STATUS
View File

@ -1,5 +1,5 @@
APACHE 2.0 STATUS: -*-text-*-
Last modified at [$Date: 2001/12/27 06:08:12 $]
Last modified at [$Date: 2001/12/27 19:53:37 $]
Release:
@ -193,11 +193,6 @@ RELEASE NON-SHOWSTOPPERS BUT WOULD BE REAL NICE TO WRAP THESE UP:
server-info or server-status.
This proposed change would _not_ depricate Alias.
* daedalus: mod_cgid and suexec have a problem co-existing. suexec
sees a null command string sometimes. The problem happens when
you access bugs.apache.org, then click on the "search the bug db"
button.
* Win32: Rotatelogs sometimes is not terminated when Apache
goes down hard. FirstBill was looking at possibly tracking the
child's-child processes in the parent process.

3
os/unix/unixd.c
View File

@ -345,7 +345,8 @@ static apr_status_t ap_unix_create_privileged_process(
i++;
}
}
newargs = apr_palloc(p, sizeof(char *) * (i + 4));
/* allocate space for 4 new args, the input args, and a null terminator */
newargs = apr_palloc(p, sizeof(char *) * (i + 5));
newprogname = SUEXEC_BIN;
newargs[0] = SUEXEC_BIN;
newargs[1] = execuser;