5689d1275f
There is inconsistency happens between two INSERTs. First INSERT happens after only tr1 was created. It enters DML_prelocking_strategy::handle_table() and sets need_prelocking as there is table->triggers. But there is no relevant triggers: tr1 is TRG_EVENT_DELETE, so nothing was added for prelocking. Nonetheless, extend_table_list() calls mark_as_requiring_prelocking() based on need_prelocking. It sets lex->query_tables_own_last to save_query_tables_last which is double pointer to NULL. Then reset_lex_and_exec_core() based on that value (double pointer is non-NULL itself) propagates that to SP's m_lex. After tr2 created, next execution of INSERT thinks it has prelocking list. extend_table_list() receives has_prelocking_list:true and skips handle_table() (and therefore any prelocking list updates). As a result when process_triggers() is trying to open t2 it does not see it in the list of open (and prelocked) tables and fails with ER_NO_SUCH_TABLE (which is misleading error code as t2 exists). The fix avoids setting need_prelocking for the cases when no triggers executed (i.e. no matching event type). Note that we can not disable prelocking for triggers without any tables like that: *need_prelocking|= trigger->add_used_tables_to_table_list(thd, &prelocking_ctx->query_tables_last, table_list->belong_to_view); because trigger must be executed under LTM_PRELOCKED, otherwise it will close not own tables (this can be further improved, see TODO in the patch). Thanks to Chǔ Huáxīng <15381158111@163.com> for the patch idea.
Code status:
ci.appveyor.com
MariaDB: The innovative open source database
MariaDB was designed as a drop-in replacement of MySQL(R) with more features, new storage engines, fewer bugs, and better performance.
MariaDB is brought to you by the MariaDB Foundation and the MariaDB Corporation. Please read the CREDITS file for details about the MariaDB Foundation, and who is developing MariaDB.
MariaDB is developed by many of the original developers of MySQL who now work for the MariaDB Corporation, the MariaDB Foundation and by many people in the community.
MySQL, which is the base of MariaDB, is a product and trademark of Oracle Corporation, Inc. For a list of developers and other contributors, see the Credits appendix. You can also run 'SHOW authors' to get a list of active contributors.
A description of the MariaDB project and a manual can be found at:
https://mariadb.com/kb/en/mariadb-vs-mysql-features/
https://mariadb.com/kb/en/mariadb-versus-mysql-compatibility/
https://mariadb.com/kb/en/new-and-old-releases/
Getting the code, building it and testing it
Refer to the following guide: https://mariadb.org/get-involved/getting-started-for-developers/get-code-build-test/ which outlines how to build the source code correctly and run the MariaDB testing framework, as well as which branch to target for your contributions.
Help
More help is available from the Maria Discuss mailing list https://lists.mariadb.org/postorius/lists/discuss.lists.mariadb.org/ and MariaDB's Zulip instance, https://mariadb.zulipchat.com/
Licensing
MariaDB is specifically available only under version 2 of the GNU General Public License (GPLv2). (I.e. Without the "any later version" clause.) This is inherited from MySQL. Please see the README file in the MySQL distribution for more information.
License information can be found in the COPYING file. Third party license information can be found in the THIRDPARTY file.
Bug Reports
Bug and/or error reports regarding MariaDB should be submitted at: https://jira.mariadb.org
For reporting security vulnerabilities see: https://mariadb.org/about/security-policy/
The code for MariaDB, including all revision history, can be found at: https://github.com/MariaDB/server