I had to rename some .cxx files to follow the same patterns.
The renaming cause clang-format to be triggered for
those files
CppunitTest_sc_functionlistobj fails with
xindexaccess.cxx:26:Assertion
Test name: sc_apitest::ScFunctionListObj::testGetCount
equality assertion failed
- Expected: 395
- Actual : 508
if it doesn't use gb_CppunitTest_use_components
Change-Id: I7c929512bbf05293118bc54b343a59c8bbee5538
Change-Id: I21971773f1e2d4bc7a6f33e4c392b20abf8d54de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142387
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Accepting tracked row deletion didn't delete the table row,
only its row content, if the table row contained cell
starting nested tables.
Extend SwTableBox::IsEmpty() to detect a table cell as empty,
if it contains only a cell starting empty table.
Note: Without change tracking, deleting content of a selected
table cell leaves the cell starting nested table in
the cell, but deleting row removed the row with nested table,
too.
Follow-up to commit 6383362999
"tdf#151657 sw: delete row with nested table in Hide Changes" and
commit c809867f3e
"tdf#150976 sw: fix tracked deletion of row with nested table".
Change-Id: I9c9bc3b97653b63e797e1e9dd545809b77a02c76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142384
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Follow-up to commit 7c20c3c2a9
"xmloff: ODF export: adapt all checks of ODFSVER_012 etc.".
Reported by Eike Rathke.
See also b7d53247eb
"tdf#115007 i18npool: add NatNum12 formats to locales" and
2a1d2d42af
"tdf#115007 add NatNum12 number format list items, fix title case".
Change-Id: Idb25a37ffcad0a0fb05276b972561abf929cd81b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142373
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
So the problem here is that when we call SwDoc::FindFormatByName we can
have the situation that there are two formats with the same name.
Those formats appear to have which ids
159 RES_DRAWFRMFMT
156 RES_FLYFRMFMT
Previously, the index was sorted by
... which ... name
which meant that the lower-valued which was always been returned.
After my path, the index is sorted by
...name....which
The problem is call path is
sw/source/core/undo/unattr.cxx:252 in SwUndoFormatAttr::GetFormat
where it calls
rDoc.GetSpzFrameFormats()->FindFormatByName()
To fix it, use the findByTypeAndName method to explicitly specify which
which-id we are interested in.
Change-Id: I8941f7c277785afb1940bcf5d2b5153c291b6f97
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142371
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
If FONTCOLOR is set to Automatic, then check the background color and adjust the font color to Black or White depending whether the background is dark.
Change-Id: I3c277291f8aa3a3e63a050c28c8f17b05f4dbf2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141177
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Revert: "vcl: allow editing a column other than the first one in GtkInstanceTreeView"
This reverts commit be11a3573a.
both basctl watchwindow and writer insert bookmark work as expected
without this.
.git/COMMIT_EDITMSG.save
Revert "vcl: allow editing a column other than the first one in GtkInstanceTreeView"
This reverts commit be11a3573a.
Change-Id: I3384164ef5634b6695cc7edad7c03a3242195003
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142366
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
If we close the file on error, then clear the handle we returned to
the caller so it doesn't try and close it again or do anything else
with it.
Change-Id: Idd054f92f4f3cbc3427896ec9795e588471292d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142344
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
If the tempfile creation fails, the handle is left uninitialised
but we still try and close it, and we explode with various
pthread locking corruptions.
I think this could be the cause of a bunch of the:
https://crashreport.libreoffice.org/stats/signature/osl_closeFile
I can trigger it on Linux by setting TMPDIR to a bogus value,
but I don't think that's all the cases that we see in the crash reports.
Initialising it to null makes the close take a safe path.
Change-Id: If66c5629b6bce62e6c4b18a97ecb901abedd4ea3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142343
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This reverts commit 64469bb1a7.
To keep the compatibility with C++98, we need to revert the previous patch.
Quoting sberg:
"This code happens to not normally be processed (see ure/source/uretest/README)
and is meant to be compilable with the 3rd-party UNO compiler baselines (i.e.,
just C++98, which implies no range base for loops)."
Change-Id: I1355a29af24299a99a23dfcd1dd473894d7c9e0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142302
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
selected is already visible (affects tdf#138868 and tdf#129610)
This patch replaces the use of TreeView::scroll_to_row with
TreeView::set_cursor in SdPageObjsTLV::SelectEntry because the GtkInst
scroll_to_row always scrolls the entry to the top, when possible, even
if the entry is already in the visible entries range. SalInst only
scrolls the entry to the top when it is not in the visible range.
Commit 3c8e81669f 'tdf#149279 related:
make gtk treeview scroll_to_row more sal like' made the gtk behavior
similiar to the sal behavior.
Change-Id: I95aa3555699eb8c8d88bb00ca39d7c3a6589353a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142363
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
For homogeneity with the Form service,
the
ApplyFilter()
OrderBy()
methods are replaced by the
Filter
OrderBy
updatable properties respectively.
Functionally there is no change.
This substitution is valid both for Basic and
Python user scripts.
Change-Id: I63a1d5c4554437b6a2cd634677e6eee246cb59ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142355
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to 37a143c8e41209ae1836215e83313250de5a2fb4
- Fix missing link and refactr
Option "printeroptions" no more available
Change-Id: I4aa67acaf2c24db196b14904e781679425bf8baa
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142314
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
(see the commit message of 4280a32579
"-Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): tools" about the
recent need of some "clang-format off" in tools/source/misc/json_writer.cxx), in
case we would ever bump our clang-format version
Change-Id: I4ee9385f84db415903790332c81161c5dbc7614f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142350
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Discovered when working on commit f6004e1c45.
To reproduce, you can print the content of aOutput2 above the line:
https://opengrok.libreoffice.org/xref/core/sdext/source/pdfimport/test/tests.cxx?r=f6004e1c#836,
and then you get the xml content as shown in:
https://bugs.documentfoundation.org/attachment.cgi?id=183217,
in which you can see that there are duplicated draw:frame(s) with identical draw:z-index.
To dig into the problem, you may take a look at the following code block:
1 for( const auto& rxChild : elem.Children )
2 {
3 PageElement* pPage = dynamic_cast<PageElement*>(rxChild.get());
4 if( pPage )
5 {
6 for( auto child_it = pPage->Children.begin(); child_it != pPage->Children.end(); ++child_it )
7 {
8 if( dynamic_cast<DrawElement*>(child_it->get()) != nullptr )
9 (*child_it)->visitedBy( *this, child_it );
10 }
11 }
12 }
13
14 for( auto it = elem.Children.begin(); it != elem.Children.end(); ++it )
15 {
16 if( dynamic_cast<DrawElement*>(it->get()) != nullptr )
17 (*it)->visitedBy( *this, it );
18 }
In the for loop in lines 1:12:
* "elem" is a "DocumentElement" which is derived from "Element". It's childen are PageElement(s).
* "pPage" is a "PageElement" which is also derived from "Element". It's childen are DrawElement(s).
* "child_it", as in the for loop in lines 6:10, is a "DrawElement" which is derived from
"GraphicalElement", whereas "GraphicalElement" is derived from "Element".
In this block, the code goes through each of the pages and visit the DrawElements there.
The code in lines 14:18 seems to assume that, a DrawElement, in addition to be a child of
PageElement, may also be a child of DocumentElement. See the comment in souce code.
Yes, it may be. For such DrawElement(s), the visiting is done in lines 14:18 separately.
Note that The above code uses dynamic_cast to determine whether a node is a DrawElement or not.
The problem is that, in determining whether the node during the 2nd visiting is a DrawElement,
it accidently used "== nullptr". This may be an inadvertent error. If the dynamic_cast is a nullprt,
then it is not a DrawElement and the visiting should not be done there.
Resolve this by using "!= nullptr" in the second dynamic_cast checking.
Change-Id: I066100e98039d505d8b10c390954e014b78cff4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141680
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
There was processorfromoutputdevice.cxx|hxx containing
createBaseProcessor2DFromOutputDevice that does exactly
the same thing as createProcessor2DFromOutputDevice in
processor2dtools.cxx|hxx, so I removed one onf them
to make handling of future changes easier.
Change-Id: Id8d49d1572a1bc39f1d330a742d4697c8c030e75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142320
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
