LibreOffice/core
1
0
Fork 0
mirror of https://github.com/LibreOffice/core.git synced 2025-08-15 20:47:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't call isIntegerConstantExpr on value dependent Expr

Browse Source 
...as it causes Clang to fail with

> Assertion failed: (!isValueDependent() && "Expression evaluator can't be called on a dependent expression."), function isIntegerConstantExpr, file .../llvm/llvm-project/clang/lib/AST/ExprConstant.cpp, line 15487.

Change-Id: I335f7610955c30a5c102bfb3b8aa6441a30dd247
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108241
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2020-12-23 18:44:47 +01:00
parent 473ca9b753
commit 68a3c364f7
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
compilerplugins/clang/elidestringvar.cxx
View File

@ -131,7 +131,7 @@ public:
{
break;
}
if (e2->isIntegerConstantExpr(compiler.getASTContext()))
if (!e2->isValueDependent() && e2->isIntegerConstantExpr(compiler.getASTContext()))
{
break;
}

5
compilerplugins/clang/test/elidestringvar.cxx
View File

@ -11,8 +11,9 @@
#include "rtl/ustring.hxx"
OUString f(sal_Unicode c, int n)
template <sal_Unicode C> OUString f(sal_Unicode c, int n)
{
OUString s0(C);
OUString s1(c);
// expected-note@+1 {{literal 'rtl::OUString' variable defined here [loplugin:elidestringvar]}}
OUString s2('a');
@ -23,6 +24,8 @@ OUString f(sal_Unicode c, int n)
OUString s4 = s4lit;
switch (n)
{
case 0:
return s0;
case 1:
return s1;
case 2: