LibreOffice/core
1
0
Fork 0
mirror of https://github.com/LibreOffice/core.git synced 2025-08-14 07:48:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

change default Calc number of columns to 16384 (tdf#50916)

Browse Source 
All tests pass now, and I've also handled all significant bugreports
from tdf#133764. This commit is mainly meant to test this more
in practice and collect feedback. Depending on how this turns out,
there may be a backwards compatibility option or something similar,
but so far I see no significant need for it.

Change-Id: I1a946f4e0b51be5acf4e25dc773e7694c2b17b48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131180
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
This commit is contained in:
Luboš Luňák
2022-03-08 12:44:49 +01:00
parent d6cd44b74c
commit 4c5f8ccf0a
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pyuno/qa/pytests/testcollections_XCellRange.py
View File

@ -348,7 +348,7 @@ class TestXCellRange(CollectionsTestBase):
self.assertEqual(0, rng.RangeAddress.StartRow)
self.assertEqual(0, rng.RangeAddress.StartColumn)
self.assertEqual(0, rng.RangeAddress.EndRow)
self.assertEqual(1023, rng.RangeAddress.EndColumn)
self.assertEqual(16383, rng.RangeAddress.EndColumn)
spr.close(True)
@ -369,7 +369,7 @@ class TestXCellRange(CollectionsTestBase):
self.assertEqual(0, rng.RangeAddress.StartRow)
self.assertEqual(0, rng.RangeAddress.StartColumn)
self.assertEqual(0, rng.RangeAddress.EndRow)
self.assertEqual(1023, rng.RangeAddress.EndColumn)
self.assertEqual(16383, rng.RangeAddress.EndColumn)
spr.close(True)

4
sc/inc/address.hxx
View File

@ -60,7 +60,7 @@ const SCSIZE SCSIZE_MAX = ::std::numeric_limits<SCSIZE>::max();
// Count values
const SCROW MAXROWCOUNT = 1048576;
const SCCOL MAXCOLCOUNT = 1024;
const SCCOL MAXCOLCOUNT = 16384;
const SCCOL INITIALCOLCOUNT = 64; // initial number of columns we allocate memory for
/// limiting to 10000 for now, problem with 32 bit builds for now
const SCTAB MAXTABCOUNT = 10000;
@ -82,7 +82,7 @@ const SCTAB MAXINITTAB = 1024;
const SCTAB MININITTAB = 1;
inline constexpr OUStringLiteral MAXROW_STRING(u"1048575");
inline constexpr OUStringLiteral MAXCOL_STRING(u"AMJ");
inline constexpr OUStringLiteral MAXCOL_STRING(u"XFD");
inline constexpr OUStringLiteral MAXROW_JUMBO_STRING(u"16777215");
inline constexpr OUStringLiteral MAXCOL_JUMBO_STRING(u"XFD");