From efe99ddd807881c470123e9b28a9a6eab89f4876 Mon Sep 17 00:00:00 2001
From: Jamie Cameron <jcameron@webmin.com>
Date: Fri, 30 May 2025 09:23:42 -0700
Subject: [PATCH] Improve checks for cron job existence

---
 cron/edit_cron.cgi | 4 ++++
 cron/lang/en       | 1 +
 2 files changed, 5 insertions(+)

diff --git a/cron/edit_cron.cgi b/cron/edit_cron.cgi
index 088355456..2c69ab865 100755
--- a/cron/edit_cron.cgi
+++ b/cron/edit_cron.cgi
@@ -8,6 +8,7 @@ require './cron-lib.pl';
 
 if (!$in{'new'}) {
 	$job = $jobs[$in{'idx'}];
+	$job || &error($text{'edit_egone'});
 	&can_edit_user(\%access, $job->{'user'}) ||
 		&error($text{'edit_ecannot'});
 	&ui_print_header(undef, $text{'edit_title'}, "");
@@ -17,6 +18,9 @@ else {
 	if (defined($in{'clone'})) {
 		# Default to clone source
 		$clone = $jobs[$in{'clone'}];
+		$clone || &error($text{'edit_egone'});
+		&can_edit_user(\%access, $clone->{'user'}) ||
+			&error($text{'edit_ecannot'});
 		$job = { %$clone };
 		}
 	elsif ($config{'vixie_cron'}) {
diff --git a/cron/lang/en b/cron/lang/en
index 16a14a0c4..fbdca9c1a 100644
--- a/cron/lang/en
+++ b/cron/lang/en
@@ -41,6 +41,7 @@ index_bootdesc=Change this setting to enable or disable starting the scheduled c
 edit_title=Edit Cron Job
 create_title=Create Cron Job
 edit_ecannot=You are not allowed to edit cron jobs for this user
+edit_egone=Job does not exist
 edit_details=Job Details
 edit_user=Execute cron job as
 edit_active=Active?