From 4bc6a0fb9685b641fb92393c0a30e77a5781fd1f Mon Sep 17 00:00:00 2001 From: Jamie Cameron Date: Fri, 20 Dec 2013 15:31:38 -0800 Subject: [PATCH] strict conversion --- acl/feedback_files.pl | 3 +++ acl/log_parser.pl | 3 +++ acl/postinstall.pl | 3 +++ acl/useradmin_update.pl | 5 ++++- 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/acl/feedback_files.pl b/acl/feedback_files.pl index c987aa04f..d7066543e 100755 --- a/acl/feedback_files.pl +++ b/acl/feedback_files.pl @@ -1,5 +1,8 @@ +use strict; +use warnings; do 'acl-lib.pl'; +our ($config_directory); sub feedback_files { diff --git a/acl/log_parser.pl b/acl/log_parser.pl index c34d335b8..86e290095 100755 --- a/acl/log_parser.pl +++ b/acl/log_parser.pl @@ -1,7 +1,10 @@ # log_parser.pl # Functions for parsing this module's logs +use strict; +use warnings; do 'acl-lib.pl'; +our (%text); # parse_webmin_log(user, script, action, type, object, ¶ms) # Converts logged information from this module into human-readable form diff --git a/acl/postinstall.pl b/acl/postinstall.pl index 431a0e3da..50324b8ac 100755 --- a/acl/postinstall.pl +++ b/acl/postinstall.pl @@ -1,5 +1,8 @@ +use strict; +use warnings; require 'acl-lib.pl'; +our ($config_directory); # Rename the .acl files for any groups to .gacl files sub module_install diff --git a/acl/useradmin_update.pl b/acl/useradmin_update.pl index c505a9ed3..e495b14f5 100755 --- a/acl/useradmin_update.pl +++ b/acl/useradmin_update.pl @@ -1,5 +1,8 @@ +use strict; +use warnings; do "acl-lib.pl"; +our (%config, $config_directory); # useradmin_create_user(&details) # Create a new webmin user in the group @@ -41,7 +44,7 @@ if ($u) { &delete_user($u->{'name'}); &reload_miniserv(); } -foreach $g (&list_groups()) { +foreach my $g (&list_groups()) { my @mems = @{$g->{'members'}}; my $i = &indexof($_[0]->{'user'}, @mems); if ($i >= 0) {