diff --git a/custom/CHANGELOG b/custom/CHANGELOG index e7bafe68a..d4aec5c85 100644 --- a/custom/CHANGELOG +++ b/custom/CHANGELOG @@ -15,3 +15,6 @@ Added a Module Config parameter to change the number of columns used to display The contents of uploaded files are no longer logged. ---- Changes since 1.340 ---- Removed the Module Config option to control if a shell is used when executing a command as a user, since we can now work this out automatically. +---- Changes since 1.390 ---- +Re-designed the user interface somewhat, and converted all code to use the new Webmin UI library. +When commands are shown in a table and no parameters are needed, the names now link directly to run the command. diff --git a/custom/custom-lib.pl b/custom/custom-lib.pl index 3f56a6cbe..775156a94 100644 --- a/custom/custom-lib.pl +++ b/custom/custom-lib.pl @@ -294,41 +294,33 @@ return @rv; sub show_params_inputs { local ($cmd, $noquote, $editor) = @_; -print "\n"; -print "\n"; -print "
$text{'edit_params'}
\n"; -print " ", - " "; -if (!$noquote) { - print " "; - } -print "\n"; +local $ptable = &ui_columns_start([ + $text{'edit_name'}, $text{'edit_desc'}, $text{'edit_type'}, + $noquote ? ( ) : ( $text{'edit_quote'} ), + ], 100, 0, undef, undef); local @a = (@{$cmd->{'args'}}, { }); for(my $i=0; $i<@a; $i++) { - print "\n"; - printf "\n", - $a[$i]->{'name'}; - printf "\n", - &html_escape($a[$i]->{'desc'}); - print "\n"; + push(@cols, &ui_select("type_$i", $a[$i]->{'type'}, \@opts)." ". + &ui_textbox("opts_$i", $a[$i]->{'opts'}, 20)); if (!$noquote) { - print "\n"; + push(@cols, &ui_yesno_radio("quote_$i", + int($a[$i]->{'quote'}))); } - print "\n"; + $ptable .= &ui_columns_row(\@cols); } -print "
$text{'edit_name'}$text{'edit_desc'} $text{'edit_type'}$text{'edit_quote'}
\n"; - print &ui_textbox("opts_$i", $a[$i]->{'opts'}, 20),"",&ui_yesno_radio("quote_$i", - int($a[$i]->{'quote'})),"
\n"; +$ptable .= &ui_columns_end(); +print $ptable; } # parse_params_inputs(&command) diff --git a/custom/edit_cmd.cgi b/custom/edit_cmd.cgi index b7d8962a2..1ea86b3ef 100755 --- a/custom/edit_cmd.cgi +++ b/custom/edit_cmd.cgi @@ -15,123 +15,92 @@ else { $cmd = $cmds[$in{'idx'}]; } -print "
\n"; -print "\n"; -print "\n"; -print "\n"; -print "\n"; -print "
$text{'edit_details'}
\n"; +# Form header +print &ui_form_start("save_cmd.cgi", "post"); +print &ui_hidden("new", $in{'new'}); +print &ui_hidden("idx", $in{'idx'}); +print &ui_table_start($text{'edit_details'}, "width=100%", 4); +# Command ID if (!$in{'new'}) { - print "\n"; - print "\n"; + print &ui_table_row(&hlink($text{'edit_id'}, "id"), + "$cmd->{'id'}", 3); } -print "\n"; -print "\n"; +# Description, text and HTML +print &ui_table_row(&hlink($text{'edit_desc'}, "desc"), + &ui_textbox("desc", $cmd->{'desc'}, 60)."
". + &ui_textarea("html", $cmd->{'html'}, 2, 60), 3); +# Command to run if ($cmd->{'cmd'} =~ s/^\s*cd\s+(\S+)\s*;\s*//) { $dir = $1; } -print "\n"; -print "\n"; +print &ui_table_row(&hlink($text{'edit_cmd'},"command"), + &ui_textbox("cmd", $cmd->{'cmd'}, 60), 3); -print "\n"; -$dir =~ s/"/"/g; -printf "\n", - $dir, &file_chooser_button("dir", 1); +# Directory to run in +print &ui_table_row(&hlink($text{'edit_dir'},"dir"), + &ui_opt_textbox("dir", $dir, 40, $text{'default'})." ". + &file_chooser_button("dir", 1), 3); +# User to run as if (&supports_users()) { - print "\n"; - print "\n", - $cmd->{'su'} ? 'checked' : '', $text{'edit_su'}; + print &ui_table_row(&hlink($text{'edit_user'},"user"), + &ui_opt_textbox("user", $cmd->{'user'} eq '*' ? undef + : $cmd->{'user'}, 13, $text{'edit_user_def'})." ". + &user_chooser_button("user", 0)." ". + &ui_checkbox("su", 1, $text{'edit_su'}, $cmd->{'su'}), 3); } -print "\n"; -printf "\n", - $cmd->{'raw'} ? "" : "checked", $text{'no'}; +# Show raw output +print &ui_table_row(&hlink($text{'edit_raw'},"raw"), + &ui_yesno_radio("raw", $cmd->{'raw'} ? 1 : 0)); -print "\n"; -printf "\n", - $cmd->{'order'} ? $cmd->{'order'} : ''; +# Command ordering on main page +print &ui_table_row(&hlink($text{'edit_order'},"order"), + &ui_opt_textbox("order", $cmd->{'order'} || "", 6, $text{'default'})); -print "\n"; -printf "\n", - $cmd->{'noshow'} ? "" : "checked", $text{'no'}; +# Hide from main page? +print &ui_table_row(&hlink($text{'edit_noshow'},"noshow"), + &ui_yesno_radio("noshow", $cmd->{'noshow'})); -print "\n"; -printf "\n", - $cmd->{'usermin'} ? "" : "checked", $text{'no'}; +# Visible in Usermin? +print &ui_table_row(&hlink($text{'edit_usermin'},"usermin"), + &ui_yesno_radio("usermin", $cmd->{'usermin'})); -print "\n"; -printf "\n", - $cmd->{'timeout'} ? $cmd->{'timeout'} : '', $text{'edit_secs'}; +# Command timeout +print &ui_table_row(&hlink($text{'edit_timeout'},"timeout"), + &ui_opt_textbox("timeout", $cmd->{'timeout'}, 6, $text{'default'}). + " ".$text{'edit_secs'}); -print "\n"; -printf "\n", - $cmd->{'clear'} ? "" : "checked", $text{'no'}; +# Clear environment? +print &ui_table_row(&hlink($text{'edit_clear'},"clear"), + &ui_yesno_radio("clear", $cmd->{'clear'})); # Show Webmin servers to run on @servers = &list_servers(); if (@servers > 1) { - print "\n"; - print "\n"; + 5, 1), 3); } -print "
",&hlink($text{'edit_id'}, "id"), - "$cmd->{'id'}
",&hlink($text{'edit_desc'}, "desc"), - "
\n"; -print "
",&hlink($text{'edit_cmd'},"command"),"{'cmd'})."\">
",&hlink($text{'edit_dir'},"dir")," %s\n", - $dir ? "" : "checked", $text{'default'}; -printf "\n", - $dir ? "checked" : ""; -printf " %s
",&hlink($text{'edit_user'},"user"),"\n"; - printf " %s\n", - $cmd->{'user'} eq '*' && !$in{'new'} ? "checked" : "", - $text{'edit_user_def'}; - printf "\n", - $cmd->{'user'} eq '*' && !$in{'new'} ? "" : "checked"; - printf " %s\n", - $cmd->{'user'} eq '*' ? '' : $cmd->{'user'}, - &user_chooser_button("user", 0); - printf " %s
",&hlink($text{'edit_raw'},"raw")," %s\n", - $cmd->{'raw'} ? "checked" : "", $text{'yes'}; -printf " %s",&hlink($text{'edit_order'},"order")," %s\n", - $cmd->{'order'} ? "" : "checked", $text{'default'}; -printf "\n", - $cmd->{'order'} ? "checked" : ""; -printf "
",&hlink($text{'edit_noshow'},"noshow")," %s\n", - $cmd->{'noshow'} ? "checked" : "", $text{'yes'}; -printf " %s",&hlink($text{'edit_usermin'},"usermin")," %s\n", - $cmd->{'usermin'} ? "checked" : "", $text{'yes'}; -printf " %s
",&hlink($text{'edit_timeout'},"timeout")," %s\n", - $cmd->{'timeout'} ? "" : "checked", $text{'edit_timeoutdef'}; -printf "\n", - $cmd->{'timeout'} ? "checked" : ""; -printf " %s",&hlink($text{'edit_clear'},"clear")," %s\n", - $cmd->{'clear'} ? "checked" : "", $text{'yes'}; -printf " %s
", - &hlink($text{'edit_servers'}, "servers"),""; @hosts = @{$cmd->{'hosts'}}; @hosts = ( 0 ) if (!@hosts); - print &ui_select("hosts", \@hosts, + print &ui_table_row(&hlink($text{'edit_servers'}, "servers"), + &ui_select("hosts", \@hosts, [ map { [ $_->{'id'}, ($_->{'desc'} || $_->{'host'}) ] } @servers ], - 5, 1); - print "

\n"; +print &ui_table_end(); # Show parameters &show_params_inputs($cmd); -print "\n"; -print "\n"; -if (!$in{'new'}) { - print "\n"; +if ($in{'new'}) { + print &ui_form_end([ [ undef, $text{'create'} ] ]); + } +else { + print &ui_form_end([ [ undef, $text{'save'} ], + [ 'delete', $text{'delete'} ] ]); } -print "

\n"; &ui_print_footer("", $text{'index_return'}); diff --git a/custom/edit_file.cgi b/custom/edit_file.cgi index 17898f7e4..4871e3b5c 100755 --- a/custom/edit_file.cgi +++ b/custom/edit_file.cgi @@ -18,80 +18,64 @@ else { print &ui_form_start("save_file.cgi", "post"); print &ui_hidden("new", $in{'new'}); print &ui_hidden("idx", $in{'idx'}); -print &ui_table_start($text{'file_details'}, "width=100%", 4); +print &ui_table_start($text{'file_details'}, "width=100%", 2); if (!$in{'new'}) { - print " ",&hlink($text{'file_id'}, "fileid"), - "\n"; - print "$edit->{'id'} \n"; + print &ui_table_row(&hlink($text{'file_id'}, "fileid"), + "$edit->{'id'}"); } -print " ",&hlink($text{'file_desc'}, "fdesc"), - "\n"; -print "
\n"; -print " \n"; +# Description, text and HTML +print &ui_table_row(&hlink($text{'edit_desc'}, "desc"), + &ui_textbox("desc", $edit->{'desc'}, 60)."
". + &ui_textarea("html", $edit->{'html'}, 2, 60)); -print " ",&hlink($text{'file_edit'}, "file"),"\n"; -print " ", - &file_chooser_button("edit", 0)," \n"; +# File to edit, and environment checkbox +print &ui_table_row(&hlink($text{'file_edit'}, "file"), + &ui_textbox("edit", $edit->{'edit'}, 60)." ". + &file_chooser_button("edit", 0)."
". + &ui_checkbox("envs", 1, $text{'file_envs'}, $edit->{'envs'})); -print " \n"; -printf " %s \n", - $edit->{'envs'} ? "checked" : "", $text{'file_envs'}; +# File owner and group +print &ui_table_row(&hlink($text{'file_owner'}, "owner"), + &ui_radio("owner_def", $edit->{'user'} ? 0 : 1, + [ [ 1, $text{'file_leave'} ], + [ 0, $text{'file_user'}." ". + &ui_textbox("user", $edit->{'user'}, 13)." ". + $text{'file_group'}." ". + &ui_textbox("group", $edit->{'group'}, 13) ] ])); -print " ",&hlink($text{'file_owner'}, "owner"),"\n"; -printf " %s\n", - $edit->{'user'} ? '' : 'checked', $text{'file_leave'}; -printf " %s\n", - $edit->{'user'} ? 'checked' : '', $text{'file_user'}; -printf " %s\n", - $edit->{'user'}, $text{'file_group'}; -printf " \n", - $edit->{'group'}; +# File permissions +print &ui_table_row(&hlink($text{'file_perms'}, "perms"), + &ui_opt_textbox("perms", $edit->{'perms'}, 3, $text{'file_leave'}, + $text{'file_set'})); -print " ",&hlink($text{'file_perms'}, "perms"),"\n"; -printf " %s\n", - $edit->{'perms'} ? '' : 'checked', $text{'file_leave'}; -printf " %s\n", - $edit->{'perms'} ? 'checked' : '', $text{'file_set'}; -printf " \n", - $edit->{'perms'}; +# Commands to run before and after +print &ui_table_row(&hlink($text{'file_before'}, "before"), + &ui_textbox("before", $edit->{'before'}, 60)); +print &ui_table_row(&hlink($text{'file_after'}, "after"), + &ui_textbox("after", $edit->{'after'}, 60)); -print " ",&hlink($text{'file_before'}, "before"),"\n"; -print " \n"; +# Command ordering on main page +print &ui_table_row(&hlink($text{'edit_order'},"order"), + &ui_opt_textbox("order", $edit->{'order'} || "", 6, $text{'default'})); -print " ",&hlink($text{'file_after'}, "after"),"\n"; -print " \n"; +# Visible in Usermin? +print &ui_table_row(&hlink($text{'edit_usermin'},"usermin"), + &ui_yesno_radio("usermin", $edit->{'usermin'})); -print " ",&hlink($text{'edit_order'}, "order"),"\n"; -printf " %s\n", - $edit->{'order'} ? "" : "checked", $text{'default'}; -printf "\n", - $edit->{'order'} ? "checked" : ""; -printf " \n", - $edit->{'order'} ? $edit->{'order'} : ''; - -print " ",&hlink($text{'edit_usermin'},"usermin"),"\n"; -printf " %s\n", - $edit->{'usermin'} ? "checked" : "", $text{'yes'}; -printf " %s \n", - $edit->{'usermin'} ? "" : "checked", $text{'no'}; - -print "

\n"; +print &ui_table_end(); +# Show parameters &show_params_inputs($edit, 1, 1); -print "\n"; -print "\n"; -if (!$in{'new'}) { - print "\n"; +if ($in{'new'}) { + print &ui_form_end([ [ undef, $text{'create'} ] ]); + } +else { + print &ui_form_end([ [ undef, $text{'save'} ], + [ 'delete', $text{'delete'} ] ]); } -print "
\n"; &ui_print_footer("", $text{'index_return'}); diff --git a/custom/lang/en b/custom/lang/en index f03718af8..3178fc241 100644 --- a/custom/lang/en +++ b/custom/lang/en @@ -30,9 +30,9 @@ edit_raw=Command outputs HTML? edit_su=Use user's environment? edit_order=Ordering on main page edit_params=Command parameters -edit_name=Name +edit_name=Parameter name edit_type=Type -edit_quote=Quote parameter? +edit_quote=Quote? edit_type0=Text edit_type1=User edit_type2=UID