From bc2926ce61374fd0850d7507f064dc7c8c515131 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=94=D0=B5=D0=BD=D0=B8=D1=81=20=D0=A1=D1=82=D1=80=D0=BE?= =?UTF-8?q?=D0=BA=D0=BE=D0=B2?= Date: Thu, 16 Feb 2023 00:06:12 +0300 Subject: [PATCH] minor updates for el function after habr.com feedback --- package.json | 2 +- src/core/el.ts | 16 +++++----------- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/package.json b/package.json index a22ffe6..e1ed8a1 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@webislife/wc-wysiwyg", - "version": "0.9.32", + "version": "0.9.33", "description": "WYWSIWYG HTML5 Editor written in ts and designed by web-componennt, support all JS frameworks and browsers", "main": "dist/wc-wysiwyg.js", "type": "module", diff --git a/src/core/el.ts b/src/core/el.ts index 7dab354..4b9433d 100644 --- a/src/core/el.ts +++ b/src/core/el.ts @@ -1,5 +1,5 @@ /** - * Short + * Short for document.createElement * @param tagName element tag name * @param params list of object params for document.createElements * @returns @@ -27,11 +27,7 @@ } // element.style[prop] if(styles) { - const stylesKeys = Object.keys(styles); - for (let i = 0; i < stylesKeys.length; i++) { - const key = stylesKeys[i]; - element.style[key] = styles[key]; - } + Object.assign(element.style, styles); } // element[prop] if(props) { @@ -51,11 +47,9 @@ } } } - if(append) { - for (let i = 0; i < append.length; i++) { - const appendEl = append[i]; - element.append(appendEl); - } + //append child elements + if(append.length) { + element.append(...append); } return element; }; \ No newline at end of file