Don't compare revision numbers to recognize file as old/critical

It's silly criterion and results were incorrect.
This commit is contained in:
Sobak
2014-06-23 08:52:25 +02:00
parent 1c63160f1e
commit 0c34ec2edb

View File

@ -3,7 +3,7 @@
+----------------------------------------------------------------------+ +----------------------------------------------------------------------+
| PHP Documentation Tools Site Source Code | | PHP Documentation Tools Site Source Code |
+----------------------------------------------------------------------+ +----------------------------------------------------------------------+
| Copyright (c) 1997-2011 The PHP Group | | Copyright (c) 1997-2014 The PHP Group |
+----------------------------------------------------------------------+ +----------------------------------------------------------------------+
| This source file is subject to version 3.0 of the PHP license, | | This source file is subject to version 3.0 of the PHP license, |
| that is bundled with this package in the file LICENSE, and is | | that is bundled with this package in the file LICENSE, and is |
@ -20,7 +20,6 @@
*/ */
// A file is criticaly "outdated' if // A file is criticaly "outdated' if
define("ALERT_REV", 10); // translation is 10 or more revisions behind the en one
define("ALERT_SIZE", 3); // translation is 3 or more kB smaller than the en one define("ALERT_SIZE", 3); // translation is 3 or more kB smaller than the en one
define("ALERT_DATE", -30); // translation is 30 or more days older than the en one define("ALERT_DATE", -30); // translation is 30 or more days older than the en one
@ -285,8 +284,6 @@ function translator_get_old($idx, $lang)
a.lang="' . $lang . '" a.lang="' . $lang . '"
AND AND
b.lang="en" b.lang="en"
AND
b.revision - a.revision < ' . ALERT_REV . '
AND AND
b.revision != a.revision b.revision != a.revision
AND AND
@ -323,19 +320,13 @@ function translator_get_critical($idx, $lang)
a.lang="' . $lang . '" a.lang="' . $lang . '"
AND AND
b.lang="en" b.lang="en"
AND AND (
( b.revision != a.revision
b.revision - a.revision >= ' . ALERT_REV . ' AND (
OR b.size - a.size >= ' . (1024 * ALERT_SIZE) . '
( OR
b.revision != a.revision (b.mdate - a.mdate) / 86400 >= ' . ALERT_DATE . '
AND )
(
b.size - a.size >= ' . (1024 * ALERT_SIZE) . '
OR
(b.mdate - a.mdate) / 86400 >= ' . ALERT_DATE . '
)
)
) )
AND AND
a.size is not NULL a.size is not NULL
@ -439,19 +430,14 @@ function get_stats_critical($idx, $lang)
a.lang="' . $lang .'" a.lang="' . $lang .'"
AND AND
b.lang="en" b.lang="en"
AND AND (
( b.revision != a.revision
b.revision - a.revision >= ' . ALERT_REV . ' AND
OR (
( (b.size - a.size) >= ' . ALERT_SIZE . '
b.revision != a.revision OR
AND (b.mdate - a.mdate) / 86400 >= ' . ALERT_DATE . '
( )
(b.size - a.size) >= ' . ALERT_SIZE . '
OR
(b.mdate - a.mdate) / 86400 >= ' . ALERT_DATE . '
)
)
) )
AND AND
a.revision != "n/a" a.revision != "n/a"
@ -486,8 +472,6 @@ function get_stats_old($idx, $lang)
a.lang="' . $lang .'" a.lang="' . $lang .'"
AND AND
b.lang="en" b.lang="en"
AND
(b.revision - a.revision) < ' . ALERT_REV . '
AND AND
b.revision != a.revision b.revision != a.revision
AND AND