3c73225125
When converting text to/from wchars, mbstring makes one function call for each and every byte or wchar to be converted. Typically, each of these conversion functions contains a state machine, and its state has to be restored and then saved for every single one of these calls. It doesn't take much to see that this is grossly inefficient. Instead of converting one byte or wchar on each call, the new conversion functions will either fill up or drain a whole buffer of wchars on each call. In benchmarks, this is about 3-10× faster. Adding the new, faster conversion functions for all supported legacy text encodings still needs some work. Also, all the code which uses the old-style conversion functions needs to be converted to use the new ones. After that, the old code can be dropped. (The mailparse extension will also have to be fixed up so it will still compile.)
26 lines
729 B
PHP
26 lines
729 B
PHP
--TEST--
|
|
Bug #65045: mb_convert_encoding breaks well-formed character
|
|
--EXTENSIONS--
|
|
mbstring
|
|
--FILE--
|
|
<?php
|
|
|
|
mb_internal_encoding('UTF-8');
|
|
|
|
$str = "\xF0\xA4\xAD". "\xF0\xA4\xAD\xA2"."\xF0\xA4\xAD\xA2";
|
|
$str2 = "\xF0\xA4\xAD\xA2"."\xF0\xA4\xAD\xA2"."\xF0\xA4\xAD";
|
|
|
|
mb_substitute_character(0xFFFD);
|
|
|
|
echo bin2hex(htmlspecialchars_decode(htmlspecialchars($str, ENT_SUBSTITUTE, 'UTF-8'))), "\n";
|
|
echo bin2hex(htmlspecialchars_decode(htmlspecialchars($str2, ENT_SUBSTITUTE, 'UTF-8'))), "\n";
|
|
echo bin2hex(mb_convert_encoding($str, 'UTF-8', 'UTF-8')), "\n";
|
|
echo bin2hex(mb_convert_encoding($str2, 'UTF-8', 'UTF-8')), "\n";
|
|
|
|
?>
|
|
--EXPECT--
|
|
efbfbdf0a4ada2f0a4ada2
|
|
f0a4ada2f0a4ada2efbfbd
|
|
efbfbdf0a4ada2f0a4ada2
|
|
f0a4ada2f0a4ada2efbfbd
|