13fe915bb1
bump detekt issues by 2
...
Signed-off-by: Marcel Hibbe <dev@mhibbe.de >
2025-02-07 12:31:16 +01:00
9e3840c3a9
style(lint): replace magic number with constant
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2025-01-16 16:29:39 +01:00
8d0c6b0ce3
style(detekt): Restrict the number of return statements in methods
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-12-13 18:24:30 +01:00
f549870d3b
style(detekt): Shorten methods
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-12-13 16:21:42 +01:00
8fe7addaef
ci(detekt): Update current detekt score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-12-13 15:35:18 +01:00
383bf2a728
style(detekt): Shorten methods
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-12-13 15:35:17 +01:00
12620a5c3e
style(detekt): shorten long methods
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
Signed-off-by: Marcel Hibbe <dev@mhibbe.de >
2024-12-10 09:00:47 +01:00
72f653a29c
ci(detekt): bump condition complexity threshold 4->5
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-12-10 08:59:25 +01:00
abebe6fcad
style(detekt): Comment on all EmptyFunctionBlock cases
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-12-06 11:11:25 +01:00
f820277779
style(detekt): Accept current use of TooGenericExceptionCaught cases
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-12-06 11:11:24 +01:00
06f7597de0
style(detekt): Ignore TooGenericExceptionThrown on test stub implementation
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-12-06 11:11:23 +01:00
eb890cfbd3
style(detekt): Replace MagicNumbers with constants
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-12-06 11:11:02 +01:00
77d2632513
style(detekt): Improve score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-12-02 10:40:00 +01:00
cabd248e13
ci: bump detekt score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-11-07 14:32:42 +01:00
ba56ee574c
ci(detekt): Bump score to turn green again
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-10-07 15:46:22 +02:00
78a55c016f
change functionPattern to support composable functions and ktlintFormat
...
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com >
2024-09-24 13:43:30 +02:00
b40a1ea438
ci: bump detekt score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-08-17 23:31:57 +02:00
9d62a6f745
fix: improve detekt score and threshold
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-08-17 20:42:26 +02:00
6b3f789545
bump detekt maxIssues for now
...
Signed-off-by: Marcel Hibbe <dev@mhibbe.de >
2024-07-24 14:14:07 +02:00
1768ce70cb
Bump score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-03-21 20:47:54 +01:00
65662e90c8
Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-03-17 18:19:19 +01:00
754b825096
pass spreedCapabilities instead user to CapabilitiesUtil
...
To support federated rooms, capabilities have to be checked from the room which now also has capabilities.
If room is not federated, capabilities fromuser are still checked.
This is why CapabilitiesUtil had to be refactored to accept SpreedCapabilities which can come from room or user.
Other than that, many other changes were made as a result of this change.
Signed-off-by: Marcel Hibbe <dev@mhibbe.de >
2024-03-01 11:25:11 +01:00
da1742f85c
improve code formatting for detekt score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2023-09-20 23:20:28 +02:00
efc8a1a2dd
Fix some magic numbers, bump score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2023-07-27 12:40:12 +02:00
5bfae5793b
bump detekt score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2023-06-28 15:07:40 +02:00
502a3f1f59
Lower max detekt findings threshold due to latest fixes
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2023-05-24 09:47:47 +02:00
47da6226f6
reduce detekt max issues count
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2022-10-06 19:49:52 +02:00
9b4f391bab
Bump detekt.yml issues after ConversationsListController conversion
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com >
2022-08-18 17:22:50 +02:00
c56a44592c
detekt: fix syntax of detekt.yml
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com >
2022-08-12 14:56:14 +02:00
d86622588a
Fix a bunch of easy detekt issues
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com >
2022-08-12 14:46:15 +02:00
a8422e665a
Add MaterialSchemes and remove any in-line color theming to be replaced with a themeUtils call
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2022-08-11 18:14:03 +02:00
7230f81cf5
Migrate conversations list and next hop controllers to use the room user entity
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2022-07-13 00:22:03 +02:00
3e99dc065b
improve code base from review comments
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2022-06-09 12:03:03 +02:00
84fea0ba80
Migrate SettingsController to kotlin + viewbinding
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2022-05-16 15:56:30 +02:00
b84589a831
improve detekt score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2022-05-09 16:51:05 +02:00
8febcdf8d8
Replace deprecated Detekt configuration options
...
Signed-off-by: Tim Krüger <t@timkrueger.me >
2022-05-04 09:18:18 +02:00
f17e892acd
improve detekt and format kotlin code
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2022-04-08 09:21:13 +02:00
deac2059ff
improve lint/detekt
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2022-04-08 09:21:11 +02:00
4f80430018
Use correct API endpoint for predefined status
...
Resolves : #1830
Signed-off-by: Tim Krüger <t@timkrueger.me >
2022-03-17 21:39:11 +01:00
eed209428e
splitting up complex methods into smaller, easier to understand methods
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2022-03-15 18:21:29 +01:00
ac703a6ac7
extract magic numbers
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2022-03-15 17:46:40 +01:00
2bc5ac1461
Allow one more detekt issue
...
The source are the six parameters in
'ConductorRemapping#remapChatController". But since we're planning to
get rid of Conductor we will live with that a while.
Signed-off-by: Tim Krüger <t@timkrueger.me >
2022-03-15 14:35:08 +01:00
1ef8acb153
lower detekt score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2022-03-14 10:23:08 +01:00
6206e4910d
simplify complex conditions for readability
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2022-03-14 10:23:06 +01:00
9223727e00
adapt to new detekt score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2022-03-14 10:23:06 +01:00
59e85334f7
set detekt limit to latest check run
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2022-03-07 13:43:46 +01:00
2cf5952fae
bump detekt score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2021-06-22 11:18:05 +02:00
db231ed12b
update after rebase, lower detekt score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2021-06-08 23:26:09 +02:00
7372d108a7
housekeeping to improve codacy/detekt score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2021-06-08 23:21:20 +02:00
b513d0f154
improve detekt score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2021-06-08 17:37:06 +02:00
