VladPolskiy/nextcloud-tables
1
0
Fork 0
mirror of https://github.com/nextcloud/tables.git synced 2026-01-14 03:17:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(CI): make unit tests PHP 8.5 compatibly

Browse Source 
... and do not swallow exceptions

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
This commit is contained in:
Arthur Schiwon
2026-01-09 14:10:35 +01:00
parent 4ca5bc0d9c
commit d0825efae1
1 changed files with 57 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/unit/Db/EntityVirtualPropertiesTest.php
View File

@ -194,7 +194,6 @@ class EntityVirtualPropertiesTest extends DatabaseTestCase {
* Get database table fields for Entity class
*/
private function getDatabaseTableFields(string $className): array {
try {
// Try to get table name from class
$tableName = $this->getTableNameFromClass($className);
if (!$tableName) {
@ -217,23 +216,20 @@ class EntityVirtualPropertiesTest extends DatabaseTestCase {
}
return $fields;
} catch (\Exception $e) {
// If we can't get table fields, return empty array
return [];
}
}
/**
* Get table name from Entity class
*/
private function getTableNameFromClass(string $className): ?string {
try {
$reflection = new ReflectionClass($className);
// Try to get table name from protected property
if ($reflection->hasProperty('table')) {
$tableProperty = $reflection->getProperty('table');
if (PHP_VERSION_ID < 80200) {
$tableProperty->setAccessible(true);
}
// Create instance to get table name
$instance = $reflection->newInstanceWithoutConstructor();
@ -250,7 +246,9 @@ class EntityVirtualPropertiesTest extends DatabaseTestCase {
$mapperReflection = new ReflectionClass($mapperClassName);
if ($mapperReflection->hasProperty('table')) {
$tableProperty = $mapperReflection->getProperty('table');
if (PHP_VERSION_ID < 80200) {
$tableProperty->setAccessible(true);
}
// Create mapper instance to get table name
$mapperInstance = $mapperReflection->newInstanceWithoutConstructor();
@ -274,10 +272,6 @@ class EntityVirtualPropertiesTest extends DatabaseTestCase {
return $tableName;
}
} catch (\Exception $e) {
// If we can't get table name, return null
}
return null;
}