* Added Additional Events
- dblclick, mousedown, mouseup, mouseover, mouseout and mousemove added to unit testing for DomEvent On function
* Added On and Off DomEvents Tests
- Added more types for DomEvent On
- Added tests for dealing with multiple events and listeners for DomEvent On
- Added tests for DomEvent Off
* Cleaned up .only
* Ran Lint Fix
Apologies, should have ran that earlier
* Reimplement disableClickPropagation in more simple and reliable way
Original approach was even simpler 5a7420dd1a
But was reworked in 5c1a34979e to be compatible with IE<9
Todo: return to original after we drop support for legacy IE
* Get rid of skipped() in stopPropagation
It was originated from here: caece94467
The only purpose of skipped there - neutralize flaws of former limited implementation of
disableClickPropagation, so it is not needed anymore.
* Reimplement preventing of double-processing of Canvas events in more simple and reliable way.
(fakeStop was used there for sole purpose here - do not pass events to map)
Remove unused functions fakeStop / skipped.
* Revert "DomEventSpec.js: test to ensure stopPropagation does not break disableClickPropagation logic"
This reverts commit 63a280993d.
Remove test case which is not useful after disableClickPropagation reimplemented
* Remove excessive check
After previous refactoring corresponding events are stopped naturally
* DomEvent.disableClickPropagation: prevent contextmenu as well
* tests: IE<11 does not understand const/let
* tests: specify all required initEvent arguments for (IE)
Otherwise we get: TypeError: Argument not optional
* tests: add profiles to emulate legacy IE versions in IE11
I can confirm that only IE10 profile is working.
Sample commandline:
npm run test-nolint -- --browsers IE,IE10
* tests: consider that style.zIndex is Number type in IE
* tests: set container height explicitly to fix 6 tests failing in IE
in IE when container.style.height is not set, container.clientWidth is always 0, despite container.style.width value.
* tests: fix #preventDefault in IE
Event properties is not preserved across different listeners calls in IE,
so we have to make all checks in the same listener.
Also: control case added.
Note: previously here used to be different implementation that was also reliable,
as it relied on return value of https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/dispatchEvent
```
function dispatchClick(el) { // return: cancelled
if (document.createEvent) {
var e = document.createEvent('MouseEvents');
e.initMouseEvent('click', true, true, window,
0, 0, 0, 0, 0, false, false, false, false, 0, null);
return el.dispatchEvent(e);
} else if (el.fireEvent) { // IE<11
return el.fireEvent('onclick');
}
}
it('prevents the default action of event', function () {
expect(dispatchClick(el)).to.be.ok(); // control case
L.DomEvent.on(el, 'click', L.DomEvent.preventDefault);
expect(dispatchClick(el)).to.not.be.ok();
});
```
* tests: skip crossOrigin-related tests in IE<11
https://caniuse.com/mdn-html_elements_img_crossorigin
* DomEventSpec.js: use on/off instead of add/removeListener aliases
* DomEventSpec.js: use happen.click instead of custom function (for uniformity)
* DomEventSpec.js: minor refactoring
Make use of more `sinon` features (for uniformity with other tests)
* DomEventSpec.js: tests for disableScrollPropagation and disableClickPropagation
DomEvent.js: fix typo
* DomEventSpec.js: test to ensure stopPropagation does not break disableClickPropagation logic
Test case for #1963
* MapSpec.js: fix: mocked function must be restored
Otherwise it will break crs.project test in CRSSpec.js
* MapSpec.js: skip broken test
crsMock.verify() call is mandatory here, but it shows that crs.project is never called,
thus the test is not ever valid.
* MapSpec.js: fix non-valid test
Revert 50a4845a78 and 1b1d96a4c4,
and refactor a bit (rather cosmetical changes)
* MapSpec.js: fix more tests
Refactor before/afterEach hooks for more careful setup/cleanup.
Fix some non-valid tests:
* #remove
- "undefines container._leaflet"
- "unbinds events"
* #removeLayer
- "when the last tile layer on a map is removed"
- "when a tile layer is removed from a map and it had greater zoom level coverage than the remainding layer"
- "when a tile layer is removed from a map it and it had lesser or the sa,e zoom level coverage as the remainding layer(s)"
* GridLayerSpec.js: fix some tests
Refactor before/afterEach hooks for more careful setup/cleanup.
Fix some non-valid tests:
* "when a tilelayer is added to a map that already has a tilelayer"
* spec/suites/**: refactor for more careful setup/cleanup
Refactor before/afterEach hooks
Other minor changes
* SpecHelper.js: rename skipIn(non)Phantom to skipIf(No)3d
..to make things more clear
Remove unused helper functions
* Update testing deps
sinon.js: left on 7.5.0 (latest still working on PhantomJS)
karma-rollup-preprocessor: left on 6.1.2 (latest still supporting rollup < 1.0.0)
* CRSSpec.js: workaround round-off error in Chrome
L.CRS.zoom(L.CRS.scale(2.5)) results 2.4999999999999996 in Chrome
Note: comparing floating point numbers properly is hard,
e.g. see https://randomascii.wordpress.com/2012/02/25/comparing-floating-point-numbers-2012-edition/
* Fix touch tests failing in Chrome
* karma.conf.js: add custom Chrome config to make some tests pass
npm run test-nolint -- --browsers Chrome1280x1024
* spec/.eslintrc: do not forbid no-unused-vars rule
* spec/.eslintrc: do not forbid more rules
no-extend-native
no-irregular-whitespace
no-shadow
* Add karma-edge-launcher
* Add karma-ie-launcher
Some test fails atm, see log:
> karma start ./spec/karma.conf.js "--browsers" "IE"
................................................................................
.....
WARN: 'Deprecated include of L.Mixin.Events: this property will be removed in future releases, please inherit from L.Evented instead.', undefined
................................................................................
................................................................................
...............................................................
IE 11.0 (Windows 10) ImageOverlay _image when loaded should raise the load event FAILED
TypeError: Argument not optional
at raiseImageEvent (spec/suites/layer/ImageOverlaySpec.js:66:4)
at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:74:5)
IE 11.0 (Windows 10) ImageOverlay _image when load fails should raise the error event FAILED
TypeError: Argument not optional
at raiseImageEvent (spec/suites/layer/ImageOverlaySpec.js:66:4)
at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:83:5)
IE 11.0 (Windows 10) ImageOverlay _image when load fails should change the image to errorOverlayUrl FAILED
TypeError: Argument not optional
at raiseImageEvent (spec/suites/layer/ImageOverlaySpec.js:66:4)
at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:88:5)
..
IE 11.0 (Windows 10) ImageOverlay #setZIndex should update the z-index of the image if it has allready been added to the map FAILED
Error: expected 1 to equal '1'
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5)
at Anonymous function (node_modules/expect.js/index.js:69:13)
at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:111:4)
IE 11.0 (Windows 10) ImageOverlay #setZIndex should set the z-index of the image when it is added to the map FAILED
Error: expected 10 to equal '10'
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5)
at Anonymous function (node_modules/expect.js/index.js:69:13)
at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:121:4)
IE 11.0 (Windows 10) ImageOverlay #setZIndex should use the z-index specified in options FAILED
Error: expected 20 to equal '20'
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5)
at Anonymous function (node_modules/expect.js/index.js:69:13)
at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:127:4)
........................................................................
IE 11.0 (Windows 10) Marker.Drag drag in CSS scaled container drags a marker with mouse, compensating for CSS scale FAILED
expected 0 to be within -50..-30 (node_modules/expect.js/index.js:102)
................................................................................
...........................................................
WARN: 'Deprecated use of _flat, please use L.LineUtil.isFlat instead.'
.
WARN: 'Deprecated use of _flat, please use L.LineUtil.isFlat instead.'
.......................................................................... 05 2020 15:25:48.917:WARN [web-server]: : /000
05 2020 15:25:48.938:WARN [web-server]: : /000
......
..
IE 11.0 (Windows 10) Map #invalidateSize pans by the right amount when growing in 1px increments FAILED
Error: expected 0 to equal 1
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5)
at Anonymous function (node_modules/expect.js/index.js:69:13)
at Anonymous function (spec/suites/map/MapSpec.js:649:4)
IE 11.0 (Windows 10) Map #invalidateSize pans by the right amount when shrinking in 1px increments FAILED
Error: expected 0 to equal -1
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5)
at Anonymous function (node_modules/expect.js/index.js:69:13)
at Anonymous function (spec/suites/map/MapSpec.js:667:4)
..
IE 11.0 (Windows 10) Map #invalidateSize emits a move event if the size has changed FAILED
Error: expected false to be truthy
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.ok (node_modules/expect.js/index.js:115:5)
at Anonymous function (node_modules/expect.js/index.js:499:7)
at Anonymous function (spec/suites/map/MapSpec.js:700:4)
IE 11.0 (Windows 10) Map #invalidateSize emits a moveend event if the size has changed FAILED
Error: expected false to be truthy
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.ok (node_modules/expect.js/index.js:115:5)
at Anonymous function (node_modules/expect.js/index.js:499:7)
at Anonymous function (spec/suites/map/MapSpec.js:710:4)
IE 11.0 (Windows 10) Map #invalidateSize debounces the moveend event if the debounceMoveend option is given FAILED
Error: expected false to be truthy
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.ok (node_modules/expect.js/index.js:115:5)
at Anonymous function (node_modules/expect.js/index.js:499:7)
at Anonymous function (spec/suites/map/MapSpec.js:724:4)
IE 11.0 (Windows 10) Map #invalidateSize correctly adjusts for new container size when view is set during map initialization (#6165) FAILED
Error: expected 0 to equal 100
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5)
at Anonymous function (spec/suites/map/MapSpec.js:745:4)
................
IE 11.0 (Windows 10) Map #fitBounds after layers set Snaps to a number after adding tile layer FAILED
Error: Access is denied.
at createTile (src/Leaflet.js:11698:3)
at _addTile (src/Leaflet.js:11433:3)
at _update (src/Leaflet.js:11330:5)
at _setView (src/Leaflet.js:11191:5)
at _resetView (src/Leaflet.js:11146:3)
at onAdd (src/Leaflet.js:10784:3)
at _layerAdd (src/Leaflet.js:6580:3)
at Events.fire (src/Leaflet.js:588:6)
at _resetView (src/Leaflet.js:4184:4)
at setView (src/Leaflet.js:3181:3)
..............................
IE 11.0 (Windows 10) Map.Drag mouse events in CSS scaled container change the center of the map, compensating for CSS scale FAILED
expected 31.952162238024975 to be within 21.943..21.9431 (node_modules/expect.js/index.js:102)
IE 11.0 (Windows 10) Map.Drag touch events change the center of the map FAILED
Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624)
IE 11.0 (Windows 10) Map.Drag touch events does not change the center of the map when finger is moved less than the drag threshold FAILED
Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624)
IE 11.0 (Windows 10) Map.Drag touch events reset itself after touchend FAILED
Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624)
.............
IE 11.0 (Windows 10) Map.TouchZoom Increases zoom when pinching out FAILED
Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624)
IE 11.0 (Windows 10) Map.TouchZoom Decreases zoom when pinching in FAILED
Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624)
IE 11.0 (Windows 10): Executed 685 of 688 (20 FAILED) (skipped 3) (25.993 secs / 22.211 secs)
* karma.conf.js: additional Firefox configs
- FirefoxPointer
- FirefoxTouch
- FirefoxPointerTouch
* .travis.yml: run CI tests with different Firefox configs
Use FirefoxHeadless
* karma.conf.js: change reporter to default ('progress')
Because 'dots' is confusing when mixed up with different warnings.
But for CI script 'dots' fits better due to travis-ci log qualities.
* .travis.yml: run CI tests with Chrome too
The rationale is this: the spec string describes the expected
behavior unconditionally. The code examples, on the other hand,
set up an expectation that is tested with the call to the expect
method. The code examples can violate the expectation, but the
spec string does not. The value of the spec string is as clearly
as possible describing the behavior. Including “should” in that
description adds no value. (From http://rubyspec.org/style_guide/)
