* test: add coverage for Layer\_addZoomLimit
Resolves#7762
Checks that zoom levels are updated to non-NaN values when
minZoom and maxZoom are set to non-NaN values in one or many
layers that are passed into addZoomLimit.
Checks that min zoom level is updated to NaN when minZoom is
set to NaN in at least one layer that passed into addZoomLimit,
but maxZoom is never set in any layer. Vice versa for when
maxZoom is set to NaN in at least one layer but minZoom is never
set in any layer. Not sure if this is a feature or a bug, so
need to followup with reviewers.
Checks that zoom levels are undefined when minZoom and maxZoom
are both set to NaN in a layer that is passed into addZoomLimit.
* test: add notes to tests showing NaN usage in zoom levels
* Disable test
Co-authored-by: Florian Bischof <design.falke@gmail.com>
* Initial Commit
- added tests for setZoomAround and setZoom
* Added fitWorld Test
- fitWorld test complete
- Extended setZoomAround tests
- Incorporated lint
* Fixed setZoom Test
- Fixed a unit test in setZoom
* Added setMinZoom and setMaxZoom Tests
- setMinZoom and setMaxZoom tests
* Applied Lint
* Fixed setMaxZoom Test
- Max layer zoom is infinity instead of 0
* Added Getter Tests
- Added tests for getPixelBounds, getSize, getContainer
* Added Getters Tests
- getPixelOrigin and getPixelWorldBounds tests added
- Refactored previous tests
* Fixed getBounds
- Accidently changed test and did not fully convert, changed back to original version
* Added Pane Tests
- Added getPane, getPanes and createPanes tests
- Changed clone test in getSize test
* Added distance Tests
- distance tests added
* Cleaned up Only
- Removed .only
* Added Point Conversion Tests
- Added layerPointToContainerPoint and containerPointToLayerPoint test
- setZoomAround test had demonstrated Point parameter incorrectly
* Fixed Missing Character
- Added # to describe
- Updated condition that can be brittle in setZoomAround
* Removed skips
* Fixed Failing Tests
* Removed .only
Co-authored-by: Florian Bischof <design.falke@gmail.com>
* Implemented missing logic for noMoveStart when using panTo function
* Add test and apply suggestions from johnd0e
Co-authored-by: Tobias Johansson <tobias_johansson@live.se>
Co-authored-by: Florian Bischof <design.falke@gmail.com>
* Add check if map container has the leaflet_id
* Fix lint
* Use private _container
* Add test for _handleGeolocationError
* Update test text
* Change text of test
undefined/null/false are not considered as special case anymore,
`layer` argument is always required, as per docs.
Previous excessive tolerance may lead to real errors get masked.
* tests: IE<11 does not understand const/let
* tests: specify all required initEvent arguments for (IE)
Otherwise we get: TypeError: Argument not optional
* tests: add profiles to emulate legacy IE versions in IE11
I can confirm that only IE10 profile is working.
Sample commandline:
npm run test-nolint -- --browsers IE,IE10
* tests: consider that style.zIndex is Number type in IE
* tests: set container height explicitly to fix 6 tests failing in IE
in IE when container.style.height is not set, container.clientWidth is always 0, despite container.style.width value.
* tests: fix #preventDefault in IE
Event properties is not preserved across different listeners calls in IE,
so we have to make all checks in the same listener.
Also: control case added.
Note: previously here used to be different implementation that was also reliable,
as it relied on return value of https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/dispatchEvent
```
function dispatchClick(el) { // return: cancelled
if (document.createEvent) {
var e = document.createEvent('MouseEvents');
e.initMouseEvent('click', true, true, window,
0, 0, 0, 0, 0, false, false, false, false, 0, null);
return el.dispatchEvent(e);
} else if (el.fireEvent) { // IE<11
return el.fireEvent('onclick');
}
}
it('prevents the default action of event', function () {
expect(dispatchClick(el)).to.be.ok(); // control case
L.DomEvent.on(el, 'click', L.DomEvent.preventDefault);
expect(dispatchClick(el)).to.not.be.ok();
});
```
* tests: skip crossOrigin-related tests in IE<11
https://caniuse.com/mdn-html_elements_img_crossorigin
* Map: fix contextmenu default-preventing when there are >1 target candidates
_fireDOMEvent gets 2 separate targets lists
- from _findEventTargets - has only targets with listeners
- from canvas (passed in argument) - may contain targets without listeners too
Previous code was incorrect as it checked random (first) target, and if happened not to have listeners -
the issue was triggered: preventDefault was not called (despite existing listeners on other targets in list).
* MapSpec.js: fix contextmenu-preventing test in IE
* Update panInside
Rewrite of panInside to correct issue #7445. Now correctly deals with cases where the padding exceeds half of the display bounds.
* Update panInside tests
Add a test for panInside specifically for issue #7445.
* Clarify last panInside test
Added comments and temp var to clarify the test intention.
* Improve readability of panInside test
Integrated suggested changes from @johnd0e
* tests: prevent warnings from webserver
Like this:
03 02 2021 08:16:25.848:WARN [web-server]: 404: /000
(also seen as unexpected newlines in progress log)
* MapSpec.js: make quotation marks consistent
* MapSpec.js: minor simplification
* MapSpec.js: fix tests containing expectations in callbacks
* MapSpec.js: fix: mocked function must be restored
Otherwise it will break crs.project test in CRSSpec.js
* MapSpec.js: skip broken test
crsMock.verify() call is mandatory here, but it shows that crs.project is never called,
thus the test is not ever valid.
* MapSpec.js: fix non-valid test
Revert 50a4845a78 and 1b1d96a4c4,
and refactor a bit (rather cosmetical changes)
* MapSpec.js: fix more tests
Refactor before/afterEach hooks for more careful setup/cleanup.
Fix some non-valid tests:
* #remove
- "undefines container._leaflet"
- "unbinds events"
* #removeLayer
- "when the last tile layer on a map is removed"
- "when a tile layer is removed from a map and it had greater zoom level coverage than the remainding layer"
- "when a tile layer is removed from a map it and it had lesser or the sa,e zoom level coverage as the remainding layer(s)"
* GridLayerSpec.js: fix some tests
Refactor before/afterEach hooks for more careful setup/cleanup.
Fix some non-valid tests:
* "when a tilelayer is added to a map that already has a tilelayer"
* spec/suites/**: refactor for more careful setup/cleanup
Refactor before/afterEach hooks
Other minor changes
* SpecHelper.js: rename skipIn(non)Phantom to skipIf(No)3d
..to make things more clear
Remove unused helper functions
* Update testing deps
sinon.js: left on 7.5.0 (latest still working on PhantomJS)
karma-rollup-preprocessor: left on 6.1.2 (latest still supporting rollup < 1.0.0)
* CRSSpec.js: workaround round-off error in Chrome
L.CRS.zoom(L.CRS.scale(2.5)) results 2.4999999999999996 in Chrome
Note: comparing floating point numbers properly is hard,
e.g. see https://randomascii.wordpress.com/2012/02/25/comparing-floating-point-numbers-2012-edition/
* Fix touch tests failing in Chrome
* karma.conf.js: add custom Chrome config to make some tests pass
npm run test-nolint -- --browsers Chrome1280x1024
* spec/.eslintrc: do not forbid no-unused-vars rule
* spec/.eslintrc: do not forbid more rules
no-extend-native
no-irregular-whitespace
no-shadow
* Add karma-edge-launcher
* Add karma-ie-launcher
Some test fails atm, see log:
> karma start ./spec/karma.conf.js "--browsers" "IE"
................................................................................
.....
WARN: 'Deprecated include of L.Mixin.Events: this property will be removed in future releases, please inherit from L.Evented instead.', undefined
................................................................................
................................................................................
...............................................................
IE 11.0 (Windows 10) ImageOverlay _image when loaded should raise the load event FAILED
TypeError: Argument not optional
at raiseImageEvent (spec/suites/layer/ImageOverlaySpec.js:66:4)
at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:74:5)
IE 11.0 (Windows 10) ImageOverlay _image when load fails should raise the error event FAILED
TypeError: Argument not optional
at raiseImageEvent (spec/suites/layer/ImageOverlaySpec.js:66:4)
at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:83:5)
IE 11.0 (Windows 10) ImageOverlay _image when load fails should change the image to errorOverlayUrl FAILED
TypeError: Argument not optional
at raiseImageEvent (spec/suites/layer/ImageOverlaySpec.js:66:4)
at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:88:5)
..
IE 11.0 (Windows 10) ImageOverlay #setZIndex should update the z-index of the image if it has allready been added to the map FAILED
Error: expected 1 to equal '1'
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5)
at Anonymous function (node_modules/expect.js/index.js:69:13)
at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:111:4)
IE 11.0 (Windows 10) ImageOverlay #setZIndex should set the z-index of the image when it is added to the map FAILED
Error: expected 10 to equal '10'
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5)
at Anonymous function (node_modules/expect.js/index.js:69:13)
at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:121:4)
IE 11.0 (Windows 10) ImageOverlay #setZIndex should use the z-index specified in options FAILED
Error: expected 20 to equal '20'
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5)
at Anonymous function (node_modules/expect.js/index.js:69:13)
at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:127:4)
........................................................................
IE 11.0 (Windows 10) Marker.Drag drag in CSS scaled container drags a marker with mouse, compensating for CSS scale FAILED
expected 0 to be within -50..-30 (node_modules/expect.js/index.js:102)
................................................................................
...........................................................
WARN: 'Deprecated use of _flat, please use L.LineUtil.isFlat instead.'
.
WARN: 'Deprecated use of _flat, please use L.LineUtil.isFlat instead.'
.......................................................................... 05 2020 15:25:48.917:WARN [web-server]: : /000
05 2020 15:25:48.938:WARN [web-server]: : /000
......
..
IE 11.0 (Windows 10) Map #invalidateSize pans by the right amount when growing in 1px increments FAILED
Error: expected 0 to equal 1
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5)
at Anonymous function (node_modules/expect.js/index.js:69:13)
at Anonymous function (spec/suites/map/MapSpec.js:649:4)
IE 11.0 (Windows 10) Map #invalidateSize pans by the right amount when shrinking in 1px increments FAILED
Error: expected 0 to equal -1
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5)
at Anonymous function (node_modules/expect.js/index.js:69:13)
at Anonymous function (spec/suites/map/MapSpec.js:667:4)
..
IE 11.0 (Windows 10) Map #invalidateSize emits a move event if the size has changed FAILED
Error: expected false to be truthy
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.ok (node_modules/expect.js/index.js:115:5)
at Anonymous function (node_modules/expect.js/index.js:499:7)
at Anonymous function (spec/suites/map/MapSpec.js:700:4)
IE 11.0 (Windows 10) Map #invalidateSize emits a moveend event if the size has changed FAILED
Error: expected false to be truthy
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.ok (node_modules/expect.js/index.js:115:5)
at Anonymous function (node_modules/expect.js/index.js:499:7)
at Anonymous function (spec/suites/map/MapSpec.js:710:4)
IE 11.0 (Windows 10) Map #invalidateSize debounces the moveend event if the debounceMoveend option is given FAILED
Error: expected false to be truthy
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.ok (node_modules/expect.js/index.js:115:5)
at Anonymous function (node_modules/expect.js/index.js:499:7)
at Anonymous function (spec/suites/map/MapSpec.js:724:4)
IE 11.0 (Windows 10) Map #invalidateSize correctly adjusts for new container size when view is set during map initialization (#6165) FAILED
Error: expected 0 to equal 100
at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7)
at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5)
at Anonymous function (spec/suites/map/MapSpec.js:745:4)
................
IE 11.0 (Windows 10) Map #fitBounds after layers set Snaps to a number after adding tile layer FAILED
Error: Access is denied.
at createTile (src/Leaflet.js:11698:3)
at _addTile (src/Leaflet.js:11433:3)
at _update (src/Leaflet.js:11330:5)
at _setView (src/Leaflet.js:11191:5)
at _resetView (src/Leaflet.js:11146:3)
at onAdd (src/Leaflet.js:10784:3)
at _layerAdd (src/Leaflet.js:6580:3)
at Events.fire (src/Leaflet.js:588:6)
at _resetView (src/Leaflet.js:4184:4)
at setView (src/Leaflet.js:3181:3)
..............................
IE 11.0 (Windows 10) Map.Drag mouse events in CSS scaled container change the center of the map, compensating for CSS scale FAILED
expected 31.952162238024975 to be within 21.943..21.9431 (node_modules/expect.js/index.js:102)
IE 11.0 (Windows 10) Map.Drag touch events change the center of the map FAILED
Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624)
IE 11.0 (Windows 10) Map.Drag touch events does not change the center of the map when finger is moved less than the drag threshold FAILED
Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624)
IE 11.0 (Windows 10) Map.Drag touch events reset itself after touchend FAILED
Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624)
.............
IE 11.0 (Windows 10) Map.TouchZoom Increases zoom when pinching out FAILED
Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624)
IE 11.0 (Windows 10) Map.TouchZoom Decreases zoom when pinching in FAILED
Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624)
IE 11.0 (Windows 10): Executed 685 of 688 (20 FAILED) (skipped 3) (25.993 secs / 22.211 secs)
* karma.conf.js: additional Firefox configs
- FirefoxPointer
- FirefoxTouch
- FirefoxPointerTouch
* .travis.yml: run CI tests with different Firefox configs
Use FirefoxHeadless
* karma.conf.js: change reporter to default ('progress')
Because 'dots' is confusing when mixed up with different warnings.
But for CI script 'dots' fits better due to travis-ci log qualities.
* .travis.yml: run CI tests with Chrome too
