VladPolskiy/leaflet
1
0
Fork 0
mirror of https://github.com/Leaflet/Leaflet.git synced 2025-07-23 00:34:55 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

GridLayer: fix _updateLevels and _removeTilesAtZoom (#7123)

Browse Source 
Because of particular quality of `for ... in` loop, type of `z` is 'string'.
Thus condition `z === zoom` never met in _updateLevels.
Considering wrong arg type, _removeTilesAtZoom also never had any action.

Cleaner solution would be to iterate `Object.keys()` instead, but it is available only since IE 9.
This commit is contained in:
johnd0e
2020-05-04 14:24:08 +03:00
committed by GitHub
parent e7a5c6ffbf
commit ec35ab52f6
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/layer/tile/GridLayer.js
View File

@ -365,6 +365,7 @@ export var GridLayer = Layer.extend({
if (zoom === undefined) { return undefined; } if (zoom === undefined) { return undefined; }
for (var z in this._levels) { for (var z in this._levels) {
z = Number(z);
if (this._levels[z].el.children.length || z === zoom) { if (this._levels[z].el.children.length || z === zoom) {
this._levels[z].el.style.zIndex = maxZoom - Math.abs(zoom - z); this._levels[z].el.style.zIndex = maxZoom - Math.abs(zoom - z);
this._onUpdateLevel(z); this._onUpdateLevel(z);
@ -461,7 +462,7 @@ export var GridLayer = Layer.extend({
_invalidateAll: function () { _invalidateAll: function () {
for (var z in this._levels) { for (var z in this._levels) {
DomUtil.remove(this._levels[z].el); DomUtil.remove(this._levels[z].el);
this._onRemoveLevel(z); this._onRemoveLevel(Number(z));
delete this._levels[z]; delete this._levels[z];
} }
this._removeAllTiles(); this._removeAllTiles();