From 00cfeb7c25bdbd460efb83ad846cb924e73ee150 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 18 Dec 2023 12:07:35 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/frontend.gitlab-ci.yml | 2 +- .gitlab/ci/rails.gitlab-ci.yml | 6 +- .../rails/rspec-foss-impact.gitlab-ci.yml.erb | 4 +- .gitlab/ci/rails/shared.gitlab-ci.yml | 6 +- .gitlab/ci/reports.gitlab-ci.yml | 2 +- .rubocop_todo/layout/hash_alignment.yml | 1 - .rubocop_todo/lint/unused_method_argument.yml | 3 - .../worker_data_consistency.yml | 1 - .../style/inline_disable_annotation.yml | 1 - GITLAB_PAGES_VERSION | 2 +- Gemfile | 2 +- .../components/validate/ci_validate.vue | 62 +++++++++-------- .../services/serialization_helpers.js | 44 ++++++++----- .../projects/new/components/app.vue | 2 +- .../webhooks/components/form_url_app.vue | 24 ++++++- .../ci/catalog/resources/unpublish.rb | 30 --------- app/graphql/types/mutation_type.rb | 1 - app/helpers/ci/pipeline_editor_helper.rb | 2 +- app/models/ci/catalog/resource.rb | 4 -- app/models/user_custom_attribute.rb | 8 +++ config/feature_categories.yml | 1 - .../soft_limit_daily_phone_verifications.yml | 8 +++ config/initializers/rspec_profiling.rb | 51 +++++++++----- config/sidekiq_queues.yml | 2 - db/docs/automation_rules.yml | 4 +- ...on_column_in_vulnerability_occurrences.yml | 4 +- ...nique_project_id_container_path_pattern.rb | 6 ++ ...ion_column_in_vulnerability_occurrences.rb | 21 ++++++ db/schema_migrations/20231207221056 | 1 + doc/api/graphql/reference/index.md | 22 ------- .../documentation/styleguide/word_list.md | 11 ++++ doc/user/enterprise_user/index.md | 2 +- .../lib/gitlab/housekeeper/keep.rb | 23 ++++++- .../lib/gitlab/housekeeper/runner.rb | 5 +- .../spec/gitlab/housekeeper/git_spec.rb | 2 +- .../spec/gitlab/housekeeper/runner_spec.rb | 6 +- .../overdue_finalize_background_migration.rb | 21 +++++- lib/gitlab/ci/config/entry/release.rb | 6 -- lib/organization/current_organization.rb | 23 +++++++ locale/gitlab.pot | 9 +-- scripts/rspec_helpers.sh | 4 +- spec/factories/user_custom_attributes.rb | 5 ++ .../user_uses_header_search_field_spec.rb | 2 +- .../components/validate/ci_validate_spec.js | 15 +++-- .../services/markdown_serializer_spec.js | 31 +++++---- .../webhooks/components/form_url_app_spec.js | 20 +++++- .../helpers/ci/pipeline_editor_helper_spec.rb | 2 +- .../ci/config/entry/inherit/default_spec.rb | 1 + .../database/no_cross_db_foreign_keys_spec.rb | 15 ++++- .../organization/current_organization_spec.rb | 66 +++++++++++++++++++ spec/models/ci/catalog/resource_spec.rb | 23 ------- spec/models/user_custom_attribute_spec.rb | 30 +++++++++ .../ci/catalog/resources/unpublish_spec.rb | 52 --------------- .../lib/sidekiq/base_reliable_fetch.rb | 1 + .../spec/base_reliable_fetch_spec.rb | 12 +++- 55 files changed, 446 insertions(+), 268 deletions(-) delete mode 100644 app/graphql/mutations/ci/catalog/resources/unpublish.rb create mode 100644 config/feature_flags/development/soft_limit_daily_phone_verifications.yml create mode 100644 db/post_migrate/20231207221056_finalize_backfill_uuid_conversion_column_in_vulnerability_occurrences.rb create mode 100644 db/schema_migrations/20231207221056 create mode 100644 lib/organization/current_organization.rb create mode 100644 spec/lib/organization/current_organization_spec.rb delete mode 100644 spec/requests/api/graphql/mutations/ci/catalog/resources/unpublish_spec.rb diff --git a/.gitlab/ci/frontend.gitlab-ci.yml b/.gitlab/ci/frontend.gitlab-ci.yml index 278ee26d48d..9d78fb102f9 100644 --- a/.gitlab/ci/frontend.gitlab-ci.yml +++ b/.gitlab/ci/frontend.gitlab-ci.yml @@ -153,7 +153,7 @@ retrieve-frontend-fixtures: - run_timed_command "gem install knapsack --no-document" - section_start "gitaly-test-spawn" "Spawning Gitaly"; scripts/gitaly-test-spawn; section_end "gitaly-test-spawn"; # Do not use 'bundle exec' here - source ./scripts/rspec_helpers.sh - - rspec_paralellized_job + - rspec_parallelized_job artifacts: name: frontend-fixtures expire_in: 31d diff --git a/.gitlab/ci/rails.gitlab-ci.yml b/.gitlab/ci/rails.gitlab-ci.yml index c9d85d2a3f8..7efcc4b58a3 100644 --- a/.gitlab/ci/rails.gitlab-ci.yml +++ b/.gitlab/ci/rails.gitlab-ci.yml @@ -769,7 +769,7 @@ rspec-ee unit gitlab-duo-chat-zeroshot pg14: - .rails:rules:ee-gitlab-duo-chat-optional script: - !reference [.base-script, script] - - rspec_paralellized_job "--tag zeroshot_executor" + - rspec_parallelized_job "--tag zeroshot_executor" rspec-ee unit gitlab-duo-chat-qa-fast pg14: extends: @@ -777,7 +777,7 @@ rspec-ee unit gitlab-duo-chat-qa-fast pg14: - .rails:rules:ee-gitlab-duo-chat-always script: - !reference [.base-script, script] - - rspec_paralellized_job "--tag fast_chat_qa_evaluation" + - rspec_parallelized_job "--tag fast_chat_qa_evaluation" rspec-ee unit gitlab-duo pg14: extends: @@ -785,7 +785,7 @@ rspec-ee unit gitlab-duo pg14: - .rails:rules:ee-gitlab-duo-chat-always script: - !reference [.base-script, script] - - rspec_paralellized_job "--tag gitlab_duo" + - rspec_parallelized_job "--tag gitlab_duo" rspec-ee unit gitlab-duo-chat-qa pg14: variables: diff --git a/.gitlab/ci/rails/rspec-foss-impact.gitlab-ci.yml.erb b/.gitlab/ci/rails/rspec-foss-impact.gitlab-ci.yml.erb index 4584cba0282..8a36848b363 100644 --- a/.gitlab/ci/rails/rspec-foss-impact.gitlab-ci.yml.erb +++ b/.gitlab/ci/rails/rspec-foss-impact.gitlab-ci.yml.erb @@ -39,7 +39,7 @@ dont-interrupt-me: RSPEC_TESTS_MAPPING_ENABLED: "true" script: - !reference [.base-script, script] - - rspec_paralellized_job "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag ~quarantine --tag ~level:background_migration --tag ~zoekt --tag ~click_house" + - rspec_parallelized_job "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag ~quarantine --tag ~level:background_migration --tag ~zoekt --tag ~click_house" artifacts: expire_in: 7d paths: @@ -54,7 +54,7 @@ rspec migration foss-impact: <% end %> script: - !reference [.base-script, script] - - rspec_paralellized_job "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag ~quarantine --tag ~zoekt --tag ~click_house" + - rspec_parallelized_job "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag ~quarantine --tag ~zoekt --tag ~click_house" <% end %> <% if rspec_files_per_test_level[:background_migration][:files].size > 0 %> diff --git a/.gitlab/ci/rails/shared.gitlab-ci.yml b/.gitlab/ci/rails/shared.gitlab-ci.yml index 636fefcb707..3194ac0c26f 100644 --- a/.gitlab/ci/rails/shared.gitlab-ci.yml +++ b/.gitlab/ci/rails/shared.gitlab-ci.yml @@ -80,7 +80,7 @@ include: # spec/lib, yet background migration tests are also sitting there, # and they should run on their own jobs so we don't need to run them # in unit tests again. - - rspec_paralellized_job "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag ~quarantine --tag ~level:background_migration --tag ~click_house --tag ~real_ai_request" + - rspec_parallelized_job "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag ~quarantine --tag ~level:background_migration --tag ~click_house --tag ~real_ai_request" after_script: - echo -e "\e[0Ksection_start:`date +%s`:report_results_section[collapsed=true]\r\e[0KReport results" - bundle exec gem list gitlab_quality-test_tooling @@ -133,7 +133,7 @@ include: .rspec-base-migration: script: - !reference [.base-script, script] - - rspec_paralellized_job "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag ~quarantine --tag ~zoekt --tag ~click_house" + - rspec_parallelized_job "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag ~quarantine --tag ~zoekt --tag ~click_house" after_script: - !reference [.rspec-base, after_script] @@ -155,7 +155,7 @@ include: - cp config/click_house.yml.example config/click_house.yml - 'sed -i "s|url:.*$|url: http://clickhouse:8123|g" config/click_house.yml' - !reference [.base-script, script] - - rspec_paralellized_job "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag click_house" + - rspec_parallelized_job "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag click_house" .rspec-base-pg14-as-if-foss: extends: diff --git a/.gitlab/ci/reports.gitlab-ci.yml b/.gitlab/ci/reports.gitlab-ci.yml index 0290d0158b6..2e963b7857a 100644 --- a/.gitlab/ci/reports.gitlab-ci.yml +++ b/.gitlab/ci/reports.gitlab-ci.yml @@ -80,7 +80,7 @@ gemnasium-python-dependency_scanning: extends: .default-retry stage: test image: - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/security-products/package-hunter-cli:v2.1.0@sha256:1f1d31fdc81f6cf0ee305ff0291bfb56f22c5764fe042948ff1676f2f8c60352 + name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/security-products/package-hunter-cli:v3.0.0@sha256:e281525b3be870d6618b6bad2685733dcb9908e4eb21f0e5b4fe4bb6f6083f91 entrypoint: [""] variables: HTR_user: '$PACKAGE_HUNTER_USER' diff --git a/.rubocop_todo/layout/hash_alignment.yml b/.rubocop_todo/layout/hash_alignment.yml index cf32e66d3e0..01a6e4ddeb4 100644 --- a/.rubocop_todo/layout/hash_alignment.yml +++ b/.rubocop_todo/layout/hash_alignment.yml @@ -2,7 +2,6 @@ # Cop supports --autocorrect. Layout/HashAlignment: Exclude: - - 'config/initializers/rspec_profiling.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/value_stream_shared_examples.rb' - 'lib/gitlab/redis/multi_store.rb' diff --git a/.rubocop_todo/lint/unused_method_argument.yml b/.rubocop_todo/lint/unused_method_argument.yml index 7e5714ef918..2c9d5c3da14 100644 --- a/.rubocop_todo/lint/unused_method_argument.yml +++ b/.rubocop_todo/lint/unused_method_argument.yml @@ -217,7 +217,6 @@ Lint/UnusedMethodArgument: - 'config/initializers/active_record_preloader.rb' - 'config/initializers/active_record_table_definition.rb' - 'config/initializers/forbid_sidekiq_in_transactions.rb' - - 'config/initializers/rspec_profiling.rb' - 'config/object_store_settings.rb' - 'ee/app/controllers/ee/projects/protected_branches_controller.rb' - 'ee/app/controllers/groups/omniauth_callbacks_controller.rb' @@ -266,7 +265,6 @@ Lint/UnusedMethodArgument: - 'ee/app/serializers/analytics/cycle_analytics/value_stream_errors_serializer.rb' - 'ee/app/services/app_sec/dast/scans/run_service.rb' - 'ee/app/services/audit_events/runners_token_audit_event_service.rb' - - 'ee/app/services/automation/dispatch_service.rb' - 'ee/app/services/boards/epic_lists/update_service.rb' - 'ee/app/services/concerns/incident_management/oncall_rotations/shared_rotation_logic.rb' - 'ee/app/services/ee/merge_requests/merge_base_service.rb' @@ -276,7 +274,6 @@ Lint/UnusedMethodArgument: - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/app/services/security/security_orchestration_policies/process_scan_result_policy_service.rb' - 'ee/app/validators/vulnerabilities/cvss_vector_validator.rb' - - 'ee/app/workers/automation/execute_rule_worker.rb' - 'ee/app/workers/gitlab_subscriptions/refresh_seats_worker.rb' - 'ee/db/fixtures/development/20_burndown.rb' - 'ee/lib/audit/compliance_framework_changes_auditor.rb' diff --git a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml index 45c060ebe03..c0f48f83492 100644 --- a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml +++ b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml @@ -315,7 +315,6 @@ SidekiqLoadBalancing/WorkerDataConsistency: - 'ee/app/workers/approval_rules/external_approval_rule_payload_worker.rb' - 'ee/app/workers/arkose/blocked_users_report_worker.rb' - 'ee/app/workers/auth/saml_group_sync_worker.rb' - - 'ee/app/workers/automation/execute_rule_worker.rb' - 'ee/app/workers/ci/minutes/refresh_cached_data_worker.rb' - 'ee/app/workers/ci/minutes/update_project_and_namespace_usage_worker.rb' - 'ee/app/workers/ci/sync_reports_to_report_approval_rules_worker.rb' diff --git a/.rubocop_todo/style/inline_disable_annotation.yml b/.rubocop_todo/style/inline_disable_annotation.yml index 1119f212b4f..1a6226514e6 100644 --- a/.rubocop_todo/style/inline_disable_annotation.yml +++ b/.rubocop_todo/style/inline_disable_annotation.yml @@ -1108,7 +1108,6 @@ Style/InlineDisableAnnotation: - 'config/initializers/mail_starttls_patch.rb' - 'config/initializers/postgres_cte_as_materialized.rb' - 'config/initializers/rack_VULNDB-255039_patch.rb' - - 'config/initializers/rspec_profiling.rb' - 'config/initializers/safe_session_store_patch.rb' - 'config/initializers/sidekiq.rb' - 'config/initializers/warden.rb' diff --git a/GITLAB_PAGES_VERSION b/GITLAB_PAGES_VERSION index d35f1128be3..f02cef6123f 100644 --- a/GITLAB_PAGES_VERSION +++ b/GITLAB_PAGES_VERSION @@ -1 +1 @@ -38a79230add5dc453d8fafa48f7f3e218a70f0be +bf6cd6ddf529f8958adee206ac0f93953e9ac39c diff --git a/Gemfile b/Gemfile index f08b2bc2e48..4e7048ddc80 100644 --- a/Gemfile +++ b/Gemfile @@ -464,7 +464,7 @@ group :development, :test do gem 'vite_rails', '~> 3.0.17', feature_category: :shared gem 'vite_ruby', '~> 3.5.0', feature_category: :shared - gem 'gitlab-housekeeper', path: 'gems/gitlab-housekeeper' # rubocop:todo Gemfile/MissingFeatureCategory + gem 'gitlab-housekeeper', path: 'gems/gitlab-housekeeper', feature_category: :tooling end group :development, :test, :danger do diff --git a/app/assets/javascripts/ci/pipeline_editor/components/validate/ci_validate.vue b/app/assets/javascripts/ci/pipeline_editor/components/validate/ci_validate.vue index 617088f303b..1d152a63407 100644 --- a/app/assets/javascripts/ci/pipeline_editor/components/validate/ci_validate.vue +++ b/app/assets/javascripts/ci/pipeline_editor/components/validate/ci_validate.vue @@ -9,6 +9,7 @@ import { GlTooltip, GlTooltipDirective, GlSprintf, + GlEmptyState, } from '@gitlab/ui'; import { s__, __ } from '~/locale'; import Tracking from '~/tracking'; @@ -67,6 +68,7 @@ export default { GlLink, GlSprintf, GlTooltip, + GlEmptyState, ValidatePipelinePopover, }, directives: { @@ -226,38 +228,44 @@ export default { -
- -

{{ $options.i18n.title }}

-