mirror of
https://gitlab.com/gitlab-org/gitlab-foss.git
synced 2025-07-29 12:00:32 +00:00
883 lines
28 KiB
Ruby
883 lines
28 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe Todo, feature_category: :notifications do
|
|
let_it_be(:issue) { create(:issue) }
|
|
let_it_be(:user) { create(:user) }
|
|
let_it_be(:user2) { create(:user) }
|
|
let_it_be(:group) { create(:group, developers: user) }
|
|
let_it_be(:project) { create(:project, :repository, developers: user) }
|
|
let_it_be(:project2) { create(:project) }
|
|
|
|
describe 'relationships' do
|
|
it { is_expected.to belong_to(:author).class_name("User") }
|
|
it { is_expected.to belong_to(:note) }
|
|
it { is_expected.to belong_to(:project) }
|
|
it { is_expected.to belong_to(:group) }
|
|
it { is_expected.to belong_to(:target).touch(false) }
|
|
it { is_expected.to belong_to(:user) }
|
|
end
|
|
|
|
describe 'respond to' do
|
|
it { is_expected.to respond_to(:author_name) }
|
|
it { is_expected.to respond_to(:author_email) }
|
|
end
|
|
|
|
describe 'validations' do
|
|
it { is_expected.to validate_presence_of(:action) }
|
|
it { is_expected.to validate_presence_of(:target_type) }
|
|
it { is_expected.to validate_presence_of(:user) }
|
|
it { is_expected.to validate_presence_of(:author) }
|
|
|
|
context "for project and/or group" do
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
subject { described_class.new(project: project, group: group) }
|
|
|
|
where(:project?, :group?) do
|
|
true | true
|
|
true | false
|
|
false | true
|
|
end
|
|
|
|
with_them do
|
|
it "are valid" do
|
|
subject.project = project? ? project : nil
|
|
subject.group = group? ? group : nil
|
|
subject.validate
|
|
|
|
expect(subject.errors[:project]).to be_empty
|
|
expect(subject.errors[:group]).to be_empty
|
|
end
|
|
end
|
|
|
|
it "are both are missing" do
|
|
subject.project = nil
|
|
subject.group = nil
|
|
subject.validate
|
|
|
|
expect(subject.errors.messages[:project].first).to eq("can't be blank")
|
|
expect(subject.errors.messages[:group].first).to eq("can't be blank")
|
|
end
|
|
end
|
|
|
|
context 'for commits' do
|
|
subject { described_class.new(target_type: 'Commit') }
|
|
|
|
it { is_expected.to validate_presence_of(:commit_id) }
|
|
it { is_expected.not_to validate_presence_of(:target_id) }
|
|
end
|
|
|
|
context 'for issuables' do
|
|
subject { described_class.new(target: issue) }
|
|
|
|
it { is_expected.to validate_presence_of(:target_id) }
|
|
it { is_expected.not_to validate_presence_of(:commit_id) }
|
|
end
|
|
|
|
context 'for parentless types' do
|
|
where(:action_type) do
|
|
[
|
|
[Todo::SSH_KEY_EXPIRING_SOON],
|
|
[Todo::SSH_KEY_EXPIRED]
|
|
]
|
|
end
|
|
|
|
with_them do
|
|
context "for #{params[:action_type]} should not require a target" do
|
|
subject { described_class.new(target: user, action: action_type) }
|
|
|
|
it { is_expected.not_to validate_presence_of(:project) }
|
|
it { is_expected.not_to validate_presence_of(:group) }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#action_name' do
|
|
let(:todo) { build(:todo) }
|
|
|
|
it 'returns the symbolic name for a valid action code on one standard action' do
|
|
todo.action = Todo::ASSIGNED
|
|
expect(todo.action_name).to eq(:assigned)
|
|
end
|
|
|
|
it 'returns nil for an undefined action code' do
|
|
todo.action = 999 # An undefined action code
|
|
expect(todo.action_name).to be_nil
|
|
end
|
|
end
|
|
|
|
describe '#parentless_type?' do
|
|
let(:todo) { build(:todo) }
|
|
|
|
context 'when action is a parentless action type' do
|
|
it 'returns true when action is included in parentless_action_types' do
|
|
parentless_action = described_class.parentless_action_types.first
|
|
todo.action = parentless_action
|
|
|
|
expect(todo).to be_parentless_type
|
|
end
|
|
end
|
|
|
|
context 'when action is not a parentless action type' do
|
|
it 'returns false when action is not included in parentless_action_types' do
|
|
non_parentless_action = (described_class::ACTION_NAMES.keys - described_class.parentless_action_types).first
|
|
todo.action = non_parentless_action
|
|
|
|
expect(todo).not_to be_parentless_type
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#body' do
|
|
before do
|
|
subject.target = build(:issue, title: 'Bugfix')
|
|
end
|
|
|
|
it 'returns target title when note is blank' do
|
|
subject.note = nil
|
|
|
|
expect(subject.body).to eq 'Bugfix'
|
|
end
|
|
|
|
it 'returns note when note is present' do
|
|
subject.note = build(:note, note: 'quick fix')
|
|
|
|
expect(subject.body).to eq 'quick fix'
|
|
end
|
|
|
|
it 'returns full path of target when action is member_access_requested' do
|
|
subject.target = group
|
|
subject.action = Todo::MEMBER_ACCESS_REQUESTED
|
|
|
|
expect(subject.body).to eq group.full_path
|
|
end
|
|
end
|
|
|
|
describe '#done' do
|
|
it 'changes state to done' do
|
|
todo = create(:todo, state: :pending)
|
|
|
|
expect { todo.done }.to change(todo, :state).from('pending').to('done')
|
|
end
|
|
|
|
it 'does not raise error when is already done' do
|
|
todo = create(:todo, state: :done)
|
|
|
|
expect { todo.done }.not_to raise_error
|
|
end
|
|
end
|
|
|
|
describe '#for_commit?' do
|
|
it 'returns true when target is a commit' do
|
|
subject.target_type = 'Commit'
|
|
|
|
expect(subject.for_commit?).to eq true
|
|
end
|
|
|
|
it 'returns false when target is an issuable' do
|
|
subject.target_type = 'Issue'
|
|
|
|
expect(subject.for_commit?).to eq false
|
|
end
|
|
end
|
|
|
|
describe '#for_design?' do
|
|
it 'returns true when target is a Design' do
|
|
subject.target_type = 'DesignManagement::Design'
|
|
|
|
expect(subject.for_design?).to eq(true)
|
|
end
|
|
|
|
it 'returns false when target is not a Design' do
|
|
subject.target_type = 'Issue'
|
|
|
|
expect(subject.for_design?).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe '#for_alert?' do
|
|
it 'returns true when target is a Alert' do
|
|
subject.target_type = 'AlertManagement::Alert'
|
|
|
|
expect(subject.for_alert?).to eq(true)
|
|
end
|
|
|
|
it 'returns false when target is not a Alert' do
|
|
subject.target_type = 'Issue'
|
|
|
|
expect(subject.for_alert?).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe '#for_issue_or_work_item?' do
|
|
it 'returns true when target is an Issue' do
|
|
subject.target_type = 'Issue'
|
|
|
|
expect(subject.for_issue_or_work_item?).to be_truthy
|
|
end
|
|
|
|
it 'returns true when target is a WorkItem' do
|
|
subject.target_type = 'WorkItem'
|
|
|
|
expect(subject.for_issue_or_work_item?).to be_truthy
|
|
end
|
|
|
|
it 'returns false when target is not an Issue' do
|
|
subject.target_type = 'DesignManagement::Design'
|
|
|
|
expect(subject.for_issue_or_work_item?).to be_falsey
|
|
end
|
|
end
|
|
|
|
describe '#target' do
|
|
context 'for commits' do
|
|
let(:commit) { project.commit }
|
|
|
|
it 'returns an instance of Commit when exists' do
|
|
subject.project = project
|
|
subject.target_type = 'Commit'
|
|
subject.commit_id = commit.id
|
|
|
|
expect(subject.target).to be_a(Commit)
|
|
expect(subject.target).to eq commit
|
|
end
|
|
|
|
it 'returns nil when does not exists' do
|
|
subject.project = project
|
|
subject.target_type = 'Commit'
|
|
subject.commit_id = 'xxxx'
|
|
|
|
expect(subject.target).to be_nil
|
|
end
|
|
end
|
|
|
|
it 'returns the issuable for issuables' do
|
|
subject.target_id = issue.id
|
|
subject.target_type = issue.class.name
|
|
|
|
expect(subject.target).to eq issue
|
|
end
|
|
end
|
|
|
|
describe '#target_reference' do
|
|
shared_examples 'returns full_path' do
|
|
specify do
|
|
subject.target = target
|
|
subject.action = Todo::MEMBER_ACCESS_REQUESTED
|
|
|
|
expect(subject.target_reference).to eq target.full_path
|
|
end
|
|
end
|
|
|
|
it 'returns commit full reference with short id' do
|
|
commit = project.commit
|
|
|
|
subject.project = project
|
|
subject.target_type = 'Commit'
|
|
subject.commit_id = commit.id
|
|
|
|
expect(subject.target_reference).to eq commit.reference_link_text(full: false)
|
|
end
|
|
|
|
it 'returns full reference for issuables' do
|
|
subject.target = issue
|
|
|
|
expect(subject.target_reference).to eq issue.to_reference(full: false)
|
|
end
|
|
|
|
context 'when target is member access requested' do
|
|
%i[project group].each do |target_type|
|
|
it_behaves_like 'returns full_path' do
|
|
let(:target) { create(target_type, :public) }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#target_url' do
|
|
subject { todo.target_url }
|
|
|
|
context 'when the todo is coming from a commit' do
|
|
let_it_be(:todo) { create(:on_commit_todo, user: user, project: project) }
|
|
|
|
it 'returns the commit web path' do
|
|
is_expected.to eq("http://localhost/#{project.full_path}/-/commit/#{todo.target.sha}")
|
|
end
|
|
end
|
|
|
|
context 'when the todo is coming from an issue' do
|
|
let_it_be(:issue) { create(:issue, project: project) }
|
|
|
|
context 'when coming from the issue itself' do
|
|
let_it_be(:todo) { create(:todo, project: project, user: user, target: issue) }
|
|
|
|
it 'returns the issue web path' do
|
|
is_expected.to eq("http://localhost/#{project.full_path}/-/issues/#{issue.iid}")
|
|
end
|
|
end
|
|
|
|
context 'when coming from a note on the issue' do
|
|
let_it_be(:note) { create(:note, project: project, noteable: issue) }
|
|
let_it_be(:todo) { create(:todo, project: project, user: user, note: note, target: issue) }
|
|
|
|
it 'returns the issue web path with an anchor to the note' do
|
|
is_expected.to eq("http://localhost/#{project.full_path}/-/issues/#{issue.iid}#note_#{note.id}")
|
|
end
|
|
end
|
|
|
|
context 'when coming from a design on the issue' do
|
|
let_it_be(:design) { create(:design, project: project, issue: issue) }
|
|
let_it_be(:todo) { create(:todo, project: project, user: user, target: design) }
|
|
|
|
it 'returns the design web path' do
|
|
is_expected.to eq("http://localhost/#{project.full_path}/-/issues/#{issue.iid}/designs/#{design.filename}")
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when the todo is coming from a work item' do
|
|
let_it_be(:work_item) { create(:work_item, :test_case, project: project) }
|
|
|
|
context 'when coming from the work item itself' do
|
|
let_it_be(:todo) { create(:todo, project: project, user: user, target: work_item, target_type: WorkItem.name) }
|
|
|
|
it 'returns the work item web path' do
|
|
is_expected.to eq("http://localhost/#{project.full_path}/-/work_items/#{work_item.iid}")
|
|
end
|
|
end
|
|
|
|
context 'when coming from a note on the work item' do
|
|
let_it_be(:note) { create(:note, project: project, noteable: work_item) }
|
|
let_it_be(:todo) { create(:todo, project: project, user: user, note: note, target: work_item, target_type: WorkItem.name) }
|
|
|
|
it 'returns the work item web path with an anchor to the note' do
|
|
is_expected.to eq("http://localhost/#{project.full_path}/-/work_items/#{work_item.iid}#note_#{note.id}")
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when the todo is coming from a merge request' do
|
|
let_it_be(:merge_request) { create(:merge_request, source_project: project) }
|
|
|
|
context 'when coming from the merge request itself' do
|
|
let_it_be(:todo) { create(:todo, project: project, user: user, target: merge_request) }
|
|
|
|
it 'returns the merge request web path' do
|
|
is_expected.to eq("http://localhost/#{project.full_path}/-/merge_requests/#{merge_request.iid}")
|
|
end
|
|
end
|
|
|
|
context 'when coming from a note on the merge request' do
|
|
let_it_be(:note) { create(:note, project: project, noteable: merge_request) }
|
|
let_it_be(:todo) { create(:todo, project: project, user: user, note: note, target: merge_request) }
|
|
|
|
it 'returns the issue web path with an anchor to the note' do
|
|
is_expected.to eq("http://localhost/#{project.full_path}/-/merge_requests/#{merge_request.iid}#note_#{note.id}")
|
|
end
|
|
end
|
|
|
|
context 'when coming from a failed pipeline on the merge request' do
|
|
let_it_be(:todo) { create(:todo, :build_failed, project: project, user: user, target: merge_request) }
|
|
|
|
it 'returns the issue web path with an anchor to the note' do
|
|
is_expected.to eq("http://localhost/#{project.full_path}/-/merge_requests/#{merge_request.iid}/pipelines")
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when the todo is coming from a wiki page' do
|
|
let_it_be(:wiki_page_meta) { create(:wiki_page_meta, :for_wiki_page, project: project) }
|
|
|
|
context 'when coming from the wiki page itself' do
|
|
let_it_be(:todo) { create(:todo, project: project, user: user, target: wiki_page_meta) }
|
|
|
|
it 'returns the wiki page web path' do
|
|
is_expected.to eq("http://localhost/#{project.full_path}/-/wikis/#{wiki_page_meta.canonical_slug}")
|
|
end
|
|
end
|
|
|
|
context 'when coming from a note on the wiki page' do
|
|
let_it_be(:note) { create(:note, project: project, noteable: wiki_page_meta) }
|
|
let_it_be(:todo) { create(:todo, project: project, user: user, note: note, target: wiki_page_meta) }
|
|
|
|
it 'returns the wiki page web path with an anchor to the note' do
|
|
is_expected.to eq("http://localhost/#{project.full_path}/-/wikis/#{wiki_page_meta.canonical_slug}#note_#{note.id}")
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when the todo is coming from an alert' do
|
|
let_it_be(:alert) { create(:alert_management_alert, project: project) }
|
|
let_it_be(:todo) { create(:todo, project: project, user: user, target: alert) }
|
|
|
|
it 'returns the merge request web path' do
|
|
is_expected.to eq("http://localhost/#{project.full_path}/-/alert_management/#{alert.iid}/details")
|
|
end
|
|
end
|
|
|
|
context 'when the todo is for an access request' do
|
|
context 'when it is a project access request' do
|
|
let_it_be(:todo) { create(:todo, :member_access_requested, project: project, user: user, target: project) }
|
|
|
|
it 'returns project access requests web path' do
|
|
is_expected.to eq("http://localhost/#{project.full_path}/-/project_members?tab=access_requests")
|
|
end
|
|
end
|
|
|
|
context 'when it is a group access request' do
|
|
let_it_be(:todo) { create(:todo, :member_access_requested, project: nil, group: group, user: user, target: group) }
|
|
|
|
it 'returns project access requests web path' do
|
|
is_expected.to eq("http://localhost/groups/#{group.full_path}/-/group_members?tab=access_requests")
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when todo is for an expired SSH key' do
|
|
let_it_be(:key) { create(:key, user: user) }
|
|
let_it_be(:todo) { build(:todo, target: key, project: nil, group: nil, user: user) }
|
|
|
|
it { is_expected.to eq("http://localhost/-/user_settings/ssh_keys/#{key.id}") }
|
|
end
|
|
end
|
|
|
|
describe '#self_added?' do
|
|
let(:user_1) { build(:user) }
|
|
|
|
before do
|
|
subject.user = user_1
|
|
end
|
|
|
|
it 'is true when the user is the author' do
|
|
subject.author = user_1
|
|
|
|
expect(subject).to be_self_added
|
|
end
|
|
|
|
it 'is false when the user is not the author' do
|
|
subject.author = build(:user)
|
|
|
|
expect(subject).not_to be_self_added
|
|
end
|
|
end
|
|
|
|
describe '#done?' do
|
|
let_it_be(:todo1) { create(:todo, state: :pending) }
|
|
let_it_be(:todo2) { create(:todo, state: :done) }
|
|
|
|
it 'returns true for todos with done state' do
|
|
expect(todo2.done?).to be_truthy
|
|
end
|
|
|
|
it 'returns false for todos with state pending' do
|
|
expect(todo1.done?).to be_falsey
|
|
end
|
|
end
|
|
|
|
describe '#self_assigned?' do
|
|
let(:user_1) { build(:user) }
|
|
|
|
context 'when self_added' do
|
|
before do
|
|
subject.user = user_1
|
|
subject.author = user_1
|
|
end
|
|
|
|
it 'returns true for ASSIGNED' do
|
|
subject.action = Todo::ASSIGNED
|
|
|
|
expect(subject).to be_self_assigned
|
|
end
|
|
|
|
it 'returns true for REVIEW_REQUESTED' do
|
|
subject.action = Todo::REVIEW_REQUESTED
|
|
|
|
expect(subject).to be_self_assigned
|
|
end
|
|
|
|
it 'returns false for other action' do
|
|
subject.action = Todo::MENTIONED
|
|
|
|
expect(subject).not_to be_self_assigned
|
|
end
|
|
end
|
|
|
|
context 'when todo is not self_added' do
|
|
before do
|
|
subject.user = user_1
|
|
subject.author = build(:user)
|
|
end
|
|
|
|
it 'returns false' do
|
|
subject.action = Todo::ASSIGNED
|
|
|
|
expect(subject).not_to be_self_assigned
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '.for_action' do
|
|
it 'returns the todos for a given action' do
|
|
create(:todo, action: Todo::MENTIONED)
|
|
|
|
todo = create(:todo, action: Todo::ASSIGNED)
|
|
|
|
expect(described_class.for_action(Todo::ASSIGNED)).to eq([todo])
|
|
end
|
|
end
|
|
|
|
describe '.for_author' do
|
|
it 'returns the todos for a given author' do
|
|
user = create(:user)
|
|
user2 = create(:user)
|
|
todo = create(:todo, author: user)
|
|
|
|
create(:todo, author: user2)
|
|
|
|
expect(described_class.for_author(user)).to eq([todo])
|
|
end
|
|
end
|
|
|
|
describe '.for_project' do
|
|
it 'returns the todos for a given project' do
|
|
todo = create(:todo, project: project)
|
|
|
|
create(:todo, project: project2)
|
|
|
|
expect(described_class.for_project(project)).to eq([todo])
|
|
end
|
|
|
|
it 'returns the todos for many projects' do
|
|
project3 = create(:project)
|
|
|
|
todo1 = create(:todo, project: project)
|
|
todo2 = create(:todo, project: project2)
|
|
create(:todo, project: project3)
|
|
|
|
expect(described_class.for_project([project2, project])).to contain_exactly(todo2, todo1)
|
|
end
|
|
end
|
|
|
|
describe '.for_undeleted_projects' do
|
|
let(:project3) { create(:project) }
|
|
|
|
let!(:todo1) { create(:todo, project: project) }
|
|
let!(:todo2) { create(:todo, project: project2) }
|
|
let!(:todo3) { create(:todo, project: project3) }
|
|
|
|
it 'returns the todos for a given project' do
|
|
expect(described_class.for_undeleted_projects).to contain_exactly(todo1, todo2, todo3)
|
|
end
|
|
|
|
context 'when todo belongs to deleted project' do
|
|
let(:project2) { create(:project, pending_delete: true) }
|
|
|
|
it 'excludes todos of deleted projects' do
|
|
expect(described_class.for_undeleted_projects).to contain_exactly(todo1, todo3)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '.for_group' do
|
|
it 'returns the todos for a given group' do
|
|
group2 = create(:group)
|
|
todo = create(:todo, group: group)
|
|
|
|
create(:todo, group: group2)
|
|
|
|
expect(described_class.for_group(group)).to eq([todo])
|
|
end
|
|
end
|
|
|
|
describe '.for_type' do
|
|
it 'returns the todos for a given target type' do
|
|
todo = create(:todo, target: issue)
|
|
|
|
create(:todo, target: create(:merge_request))
|
|
|
|
expect(described_class.for_type(Issue.name)).to eq([todo])
|
|
end
|
|
end
|
|
|
|
describe '.for_target' do
|
|
it 'returns the todos for a given target' do
|
|
todo = create(:todo, target: issue)
|
|
|
|
create(:todo, target: create(:merge_request))
|
|
|
|
expect(described_class.for_type(Issue.name).for_target(todo.target))
|
|
.to contain_exactly(todo)
|
|
end
|
|
end
|
|
|
|
describe '.for_commit' do
|
|
it 'returns the todos for a commit ID' do
|
|
todo = create(:todo, commit_id: '123')
|
|
|
|
create(:todo, commit_id: '456')
|
|
|
|
expect(described_class.for_commit('123')).to eq([todo])
|
|
end
|
|
end
|
|
|
|
describe '.not_in_users' do
|
|
it 'returns the expected todos' do
|
|
user = create(:user)
|
|
user2 = create(:user)
|
|
|
|
todo1 = create(:todo, user: user)
|
|
todo2 = create(:todo, user: user)
|
|
create(:todo, user: user2)
|
|
|
|
expect(described_class.not_in_users(user2)).to contain_exactly(todo1, todo2)
|
|
end
|
|
end
|
|
|
|
describe '.for_group_ids_and_descendants' do
|
|
it 'returns the todos for a group and its descendants' do
|
|
parent_group = group
|
|
child_group = create(:group, parent: parent_group)
|
|
|
|
todo1 = create(:todo, group: parent_group)
|
|
todo2 = create(:todo, group: child_group)
|
|
todos = described_class.for_group_ids_and_descendants([parent_group.id])
|
|
|
|
expect(todos).to contain_exactly(todo1, todo2)
|
|
end
|
|
end
|
|
|
|
describe '.pending_for_expiring_ssh_keys' do
|
|
it 'returns only todos matching the given key ids' do
|
|
todo1 = create(:todo, target_type: Key, target_id: 1, action: described_class::SSH_KEY_EXPIRING_SOON, state: :pending)
|
|
todo2 = create(:todo, target_type: Key, target_id: 2, action: described_class::SSH_KEY_EXPIRING_SOON, state: :pending)
|
|
create(:todo, target_type: Key, target_id: 3, action: described_class::SSH_KEY_EXPIRING_SOON, state: :done)
|
|
create(:todo, target_type: Issue, target_id: 1, action: described_class::ASSIGNED, state: :pending)
|
|
todos = described_class.pending_for_expiring_ssh_keys([1, 2, 3])
|
|
|
|
expect(todos).to contain_exactly(todo1, todo2)
|
|
end
|
|
end
|
|
|
|
describe '.for_user' do
|
|
it 'returns the expected todos' do
|
|
todo1 = create(:todo, user: user)
|
|
todo2 = create(:todo, user: user)
|
|
create(:todo, user: user2)
|
|
|
|
expect(described_class.for_user(user)).to contain_exactly(todo1, todo2)
|
|
end
|
|
end
|
|
|
|
describe '.for_note' do
|
|
it 'returns todos that belongs to notes' do
|
|
note_1 = create(:note, noteable: issue, project: issue.project)
|
|
note_2 = create(:note, noteable: issue, project: issue.project)
|
|
todo_1 = create(:todo, note: note_1)
|
|
todo_2 = create(:todo, note: note_2)
|
|
create(:todo, note: create(:note))
|
|
|
|
expect(described_class.for_note([note_1, note_2])).to contain_exactly(todo_1, todo_2)
|
|
end
|
|
end
|
|
|
|
describe '.pending_count_by_user_id' do
|
|
before do
|
|
create(:todo, user: user, state: :pending)
|
|
create(:todo, user: user, state: :pending)
|
|
create(:todo, user: user, state: :done)
|
|
create(:todo, user: user2, state: :pending)
|
|
end
|
|
|
|
specify do
|
|
expect(described_class.pending_count_by_user_id).to eq({ user.id => 2, user2.id => 1 })
|
|
end
|
|
end
|
|
|
|
describe '.any_for_target?' do
|
|
it 'returns true if there are todos for a given target' do
|
|
todo = create(:todo)
|
|
|
|
expect(described_class.any_for_target?(todo.target)).to eq(true)
|
|
end
|
|
|
|
it 'returns true if there is at least one todo for a given target with state pending' do
|
|
create(:todo, state: :done, target: issue)
|
|
create(:todo, state: :pending, target: issue)
|
|
|
|
expect(described_class.any_for_target?(issue)).to eq(true)
|
|
end
|
|
|
|
it 'returns false if there are only todos for a given target with state done while searching for pending' do
|
|
create(:todo, state: :done, target: issue)
|
|
create(:todo, state: :done, target: issue)
|
|
|
|
expect(described_class.any_for_target?(issue, :pending)).to eq(false)
|
|
end
|
|
|
|
it 'returns false if there are no todos for a given target' do
|
|
expect(described_class.any_for_target?(issue)).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe '.batch_update' do
|
|
it 'updates the state of todos' do
|
|
todo = create(:todo, :pending)
|
|
ids = described_class.batch_update(state: :done)
|
|
|
|
todo.reload
|
|
|
|
expect(ids).to eq([todo.id])
|
|
expect(todo.state).to eq('done')
|
|
end
|
|
|
|
it 'does not update todos that already have the given state' do
|
|
create(:todo, :pending)
|
|
|
|
expect(described_class.batch_update(state: :pending)).to be_empty
|
|
end
|
|
|
|
it 'updates updated_at' do
|
|
create(:todo, :pending)
|
|
|
|
travel_to(1.day.from_now) do
|
|
expected_update_date = Time.current.utc
|
|
|
|
ids = described_class.batch_update(state: :done)
|
|
|
|
expect(Todo.where(id: ids).map(&:updated_at)).to all(be_like_time(expected_update_date))
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '.sort_by_snoozed_and_creation_dates' do
|
|
let_it_be(:todo1) { create(:todo) }
|
|
let_it_be(:todo2) { create(:todo, created_at: 3.hours.ago) }
|
|
let_it_be(:todo3) { create(:todo, snoozed_until: 1.hour.ago) }
|
|
|
|
context 'when sorting by ascending date' do
|
|
subject { described_class.sort_by_snoozed_and_creation_dates(direction: :asc) }
|
|
|
|
it { is_expected.to eq([todo2, todo3, todo1]) }
|
|
end
|
|
|
|
context 'when sorting by descending date' do
|
|
subject { described_class.sort_by_snoozed_and_creation_dates }
|
|
|
|
it { is_expected.to eq([todo1, todo3, todo2]) }
|
|
end
|
|
end
|
|
|
|
describe '.distinct_user_ids' do
|
|
subject { described_class.distinct_user_ids }
|
|
|
|
let_it_be(:todo) { create(:todo, user: user) }
|
|
let_it_be(:todo) { create(:todo, user: user) }
|
|
let_it_be(:todo) { create(:todo, user: user2) }
|
|
|
|
it { is_expected.to contain_exactly(user.id, user2.id) }
|
|
end
|
|
|
|
describe '.for_internal_notes' do
|
|
it 'returns todos created from internal notes' do
|
|
internal_note = create(:note, confidential: true)
|
|
todo = create(:todo, note: internal_note)
|
|
create(:todo)
|
|
|
|
expect(described_class.for_internal_notes).to contain_exactly(todo)
|
|
end
|
|
end
|
|
|
|
shared_context 'with todos authored by banned and unbanned users' do
|
|
let(:unbanned_author_pending_todo) { create(:todo, :pending) }
|
|
let(:unbanned_author_done_todo) { create(:todo, :done) }
|
|
let(:banned_user) { create(:user, :banned) }
|
|
let(:banned_author_pending_todo) { create(:todo, :pending, author: banned_user) }
|
|
let(:banned_author_done_todo) { create(:todo, :done, author: banned_user) }
|
|
end
|
|
|
|
describe '.without_banned_user' do
|
|
include_context 'with todos authored by banned and unbanned users'
|
|
|
|
it 'only returns todos that are not authored by a banned user' do
|
|
expect(described_class.without_banned_user).to contain_exactly(unbanned_author_pending_todo, unbanned_author_done_todo)
|
|
end
|
|
end
|
|
|
|
describe '.pending_without_hidden' do
|
|
include_context 'with todos authored by banned and unbanned users'
|
|
|
|
it 'only returns todos that are not pending and authored by a banned user' do
|
|
expect(described_class.pending_without_hidden).to contain_exactly(unbanned_author_pending_todo)
|
|
end
|
|
end
|
|
|
|
describe '.all_without_hidden' do
|
|
include_context 'with todos authored by banned and unbanned users'
|
|
|
|
it 'only returns todos that are not pending and authored by a banned user' do
|
|
expect(described_class.all_without_hidden).to contain_exactly(unbanned_author_pending_todo, unbanned_author_done_todo, banned_author_done_todo)
|
|
end
|
|
end
|
|
|
|
describe 'snoozed and not_snoozed scopes' do
|
|
let_it_be(:snoozed_todo) { create(:todo, snoozed_until: 1.day.from_now) }
|
|
let_it_be(:unsnoozed_todo) { create(:todo, snoozed_until: 1.day.ago) }
|
|
let_it_be(:never_snoozed_todo) { create(:todo, snoozed_until: nil) }
|
|
|
|
describe '.snoozed' do
|
|
it 'only returns todos that are currently snoozed' do
|
|
expect(described_class.snoozed).to contain_exactly(snoozed_todo)
|
|
end
|
|
end
|
|
|
|
describe '.not_snoozed' do
|
|
it 'returns todos that are not snoozed anymore or never were snoozed' do
|
|
expect(described_class.not_snoozed).to contain_exactly(unsnoozed_todo, never_snoozed_todo)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#access_request_url' do
|
|
shared_examples 'returns member access requests tab url/path' do
|
|
it 'returns group access requests tab url/path if target is group' do
|
|
subject.target = group
|
|
|
|
expect(subject.access_request_url(only_path: only_path)).to eq(Gitlab::Routing.url_helpers.group_group_members_url(group, tab: 'access_requests', only_path: only_path))
|
|
end
|
|
|
|
it 'returns project access requests tab url/path if target is project' do
|
|
subject.target = project
|
|
|
|
expect(subject.access_request_url(only_path: only_path)).to eq(Gitlab::Routing.url_helpers.project_project_members_url(project, tab: 'access_requests', only_path: only_path))
|
|
end
|
|
|
|
it 'returns empty string if target is neither group nor project' do
|
|
subject.target = issue
|
|
|
|
expect(subject.access_request_url(only_path: only_path)).to eq("")
|
|
end
|
|
end
|
|
|
|
context 'when only_path param is false' do
|
|
it_behaves_like 'returns member access requests tab url/path' do
|
|
let_it_be(:only_path) { false }
|
|
end
|
|
end
|
|
|
|
context 'when only_path param is nil' do
|
|
it_behaves_like 'returns member access requests tab url/path' do
|
|
let_it_be(:only_path) { nil }
|
|
end
|
|
end
|
|
|
|
context 'when only_path param is true' do
|
|
it_behaves_like 'returns member access requests tab url/path' do
|
|
let_it_be(:only_path) { true }
|
|
end
|
|
end
|
|
end
|
|
end
|