mirror of
https://gitlab.com/gitlab-org/gitlab-foss.git
synced 2025-08-01 16:04:19 +00:00
442 lines
16 KiB
Ruby
442 lines
16 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe 'User Settings > Personal access tokens', :with_current_organization, :js, feature_category: :system_access do
|
|
include Spec::Support::Helpers::ModalHelpers
|
|
include Features::AccessTokenHelpers
|
|
|
|
let(:user) { create(:user) }
|
|
let(:pat_create_service) do
|
|
instance_double('PersonalAccessTokens::CreateService',
|
|
execute: ServiceResponse.error(message: 'error', payload: { personal_access_token: PersonalAccessToken.new }))
|
|
end
|
|
|
|
describe "migrate_user_access_tokens_ui feature flag on" do
|
|
before do
|
|
sign_in(user)
|
|
end
|
|
|
|
describe "token creation" do
|
|
it "allows creation of a personal access token" do
|
|
name = 'My PAT'
|
|
description = 'My PAT description'
|
|
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
expect(active_access_tokens_count).to have_text('0')
|
|
|
|
click_button 'Add new token'
|
|
fill_in "Token name", with: name
|
|
|
|
fill_in "Description", with: description
|
|
|
|
# Set date to 1st of next month
|
|
find_field("Expiration date").click
|
|
find(".pika-next").click
|
|
click_on "1"
|
|
|
|
# Scopes
|
|
check "read_api"
|
|
check "read_user"
|
|
|
|
click_on "Create token"
|
|
wait_for_all_requests
|
|
|
|
expect(access_token_table).to have_text(name)
|
|
expect(access_token_table).to have_text(description)
|
|
expect(access_token_table).to have_text('in')
|
|
expect(access_token_table).to have_text('read_api')
|
|
expect(access_token_table).to have_text('read_user')
|
|
expect(new_access_token).to match(/[\w-]{20}/)
|
|
expect(active_access_tokens_count).to have_text('1')
|
|
end
|
|
|
|
context "when creation fails" do
|
|
it "displays an error message" do
|
|
number_tokens_before = PersonalAccessToken.count
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
click_button 'Add new token'
|
|
fill_in "Token name", with: 'My PAT'
|
|
|
|
click_on "Create token"
|
|
wait_for_all_requests
|
|
|
|
expect(number_tokens_before).to equal(PersonalAccessToken.count)
|
|
expect(page).to have_content(_("At least one scope is required."))
|
|
expect(page).to have_content("No access tokens")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'active tokens' do
|
|
let!(:impersonation_token) { create(:personal_access_token, :impersonation, user: user) }
|
|
let!(:personal_access_token) { create(:personal_access_token, user: user) }
|
|
|
|
it 'only shows personal access tokens' do
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
expect(access_token_table).to have_text(personal_access_token.name)
|
|
expect(access_token_table).not_to have_text(impersonation_token.name)
|
|
end
|
|
|
|
context 'when User#time_display_relative is false' do
|
|
before do
|
|
user.update!(time_display_relative: false)
|
|
end
|
|
|
|
it 'shows absolute times for expires_at' do
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
expect(access_token_table).to have_text(PersonalAccessToken.last.expires_at.strftime('%b %-d'))
|
|
end
|
|
end
|
|
|
|
context 'when token has no Last Used IPs' do
|
|
it 'shows "Never" as the value' do
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
expect(last_used_ip).to have_text('Last used: Never')
|
|
end
|
|
end
|
|
|
|
context 'when token has Last Used IPs' do
|
|
let(:current_ip_address) { '127.0.0.1' }
|
|
|
|
before do
|
|
personal_access_token.last_used_ips << Authn::PersonalAccessTokenLastUsedIp.new(
|
|
organization: personal_access_token.organization,
|
|
ip_address: current_ip_address)
|
|
end
|
|
|
|
it 'shows the current_ip_address in last_used_ips' do
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
expect(last_used_ips).to have_text("IP: #{current_ip_address}")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "inactive tokens" do
|
|
let!(:personal_access_token) { create(:personal_access_token, user: user) }
|
|
|
|
it "allows revocation of an active token" do
|
|
visit user_settings_personal_access_tokens_path
|
|
access_token_options.click
|
|
accept_gl_confirm(button_text: 'Revoke') { click_on "Revoke" }
|
|
|
|
expect(access_token_table).to have_text("No access tokens")
|
|
end
|
|
|
|
it "removes expired tokens from 'active' section" do
|
|
personal_access_token.update!(expires_at: 5.days.ago)
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
expect(access_token_table).to have_text("No access tokens")
|
|
end
|
|
|
|
context "when revocation fails" do
|
|
it "displays an error message" do
|
|
allow_next_instance_of(PersonalAccessTokens::RevokeService) do |instance|
|
|
allow(instance).to receive(:revocation_permitted?).and_return(false)
|
|
end
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
access_token_options.click
|
|
accept_gl_confirm(button_text: "Revoke") { click_on "Revoke" }
|
|
expect(access_token_table).to have_text(personal_access_token.name)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "rotating tokens" do
|
|
let!(:personal_access_token) { create(:personal_access_token, user: user) }
|
|
|
|
it "displays the newly created token" do
|
|
visit user_settings_personal_access_tokens_path
|
|
expect(active_access_tokens_count).to have_text('1')
|
|
access_token_options.click
|
|
accept_gl_confirm(button_text: s_('AccessTokens|Rotate')) { click_on s_('AccessTokens|Rotate') }
|
|
wait_for_all_requests
|
|
expect(page).to have_content("Make sure you save it - you won't be able to access it again.")
|
|
expect(access_token_table).to have_text(personal_access_token.name)
|
|
expect(new_access_token).to match(/[\w-]{20}/)
|
|
expect(active_access_tokens_count).to have_text('1')
|
|
end
|
|
|
|
context "when rotation fails" do
|
|
it "displays an error message" do
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
access_token_options.click
|
|
accept_gl_confirm(button_text: s_('AccessTokens|Rotate')) do
|
|
personal_access_token.revoke!
|
|
click_on s_('AccessTokens|Rotate')
|
|
end
|
|
|
|
wait_for_all_requests
|
|
expect(page).to have_content(s_('AccessTokens|Token already revoked'))
|
|
end
|
|
end
|
|
end
|
|
|
|
it "prefills token details" do
|
|
name = 'My PAT'
|
|
description = 'My PAT description'
|
|
scopes = 'api,read_user'
|
|
|
|
visit user_settings_personal_access_tokens_path({ name: name, scopes: scopes, description: description })
|
|
|
|
expect(page).to have_field("Token name", with: name)
|
|
expect(page).to have_field("Description", with: description)
|
|
expect(find_field('api', with: 'api')).to be_checked
|
|
expect(find_field('read_user')).to be_checked
|
|
end
|
|
|
|
describe "feed token" do
|
|
def feed_token_description
|
|
"Your feed token authenticates you when your RSS reader loads a personalized RSS feed or when your calendar\
|
|
application loads a personalized calendar. It is visible in those feed URLs. It cannot be used to access\
|
|
any other data."
|
|
end
|
|
|
|
context "when enabled" do
|
|
it "displays feed token" do
|
|
allow(Gitlab::CurrentSettings).to receive(:disable_feed_token).and_return(false)
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
within_testid('feed-token-container') do
|
|
click_button('Click to reveal')
|
|
|
|
expect(page).to have_field('Feed token', with: user.feed_token)
|
|
expect(page).to have_content(feed_token_description)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when disabled" do
|
|
it "does not display feed token" do
|
|
allow(Gitlab::CurrentSettings).to receive(:disable_feed_token).and_return(true)
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
expect(page).not_to have_content(feed_token_description)
|
|
expect(page).not_to have_field('Feed token')
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "migrate_user_access_tokens_ui feature flag off" do
|
|
before do
|
|
stub_feature_flags(migrate_user_access_tokens_ui: false)
|
|
sign_in(user)
|
|
end
|
|
|
|
describe "token creation" do
|
|
it "allows creation of a personal access token" do
|
|
name = 'My PAT'
|
|
description = 'My PAT description'
|
|
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
expect(active_access_tokens_counter).to have_text('0')
|
|
|
|
click_button 'Add new token'
|
|
fill_in "Token name", with: name
|
|
|
|
fill_in "Token description", with: description
|
|
|
|
# Set date to 1st of next month
|
|
find_field("Expiration date").click
|
|
find(".pika-next").click
|
|
click_on "1"
|
|
|
|
# Scopes
|
|
check "read_api"
|
|
check "read_user"
|
|
|
|
click_on "Create personal access token"
|
|
wait_for_all_requests
|
|
|
|
expect(active_access_tokens).to have_text(name)
|
|
expect(active_access_tokens).to have_text(description)
|
|
expect(active_access_tokens).to have_text('in')
|
|
expect(active_access_tokens).to have_text('read_api')
|
|
expect(active_access_tokens).to have_text('read_user')
|
|
expect(created_access_token).to match(/[\w-]{20}/)
|
|
expect(active_access_tokens_counter).to have_text('1')
|
|
end
|
|
|
|
context "when creation fails" do
|
|
it "displays an error message" do
|
|
number_tokens_before = PersonalAccessToken.count
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
click_button 'Add new token'
|
|
fill_in "Token name", with: 'My PAT'
|
|
|
|
click_on "Create personal access token"
|
|
wait_for_all_requests
|
|
|
|
expect(number_tokens_before).to equal(PersonalAccessToken.count)
|
|
expect(page).to have_content(_("Scopes can't be blank"))
|
|
expect(page).not_to have_selector("[data-testid='new-access-tokens']")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'active tokens' do
|
|
let!(:impersonation_token) { create(:personal_access_token, :impersonation, user: user) }
|
|
let!(:personal_access_token) { create(:personal_access_token, user: user) }
|
|
|
|
it 'only shows personal access tokens' do
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
expect(active_access_tokens).to have_text(personal_access_token.name)
|
|
expect(active_access_tokens).not_to have_text(impersonation_token.name)
|
|
end
|
|
|
|
context 'when User#time_display_relative is false' do
|
|
before do
|
|
user.update!(time_display_relative: false)
|
|
end
|
|
|
|
it 'shows absolute times for expires_at' do
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
expect(active_access_tokens).to have_text(PersonalAccessToken.last.expires_at.strftime('%b %-d'))
|
|
end
|
|
end
|
|
|
|
context 'when token has no Last Used IPs' do
|
|
it 'shows "-" as the value' do
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
expect(active_access_tokens).to have_selector('td[data-label="Last Used IPs"]', text: '-')
|
|
end
|
|
end
|
|
|
|
context 'when token has Last Used IPs' do
|
|
let(:current_ip_address) { '127.0.0.1' }
|
|
|
|
before do
|
|
personal_access_token.last_used_ips << Authn::PersonalAccessTokenLastUsedIp.new(
|
|
organization: personal_access_token.organization,
|
|
ip_address: current_ip_address)
|
|
end
|
|
|
|
it 'shows the current_ip_address in last_used_ips' do
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
expect(active_access_tokens).to have_selector('td[data-label="Last Used IPs"]', text: current_ip_address)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "inactive tokens" do
|
|
let!(:personal_access_token) { create(:personal_access_token, user: user) }
|
|
|
|
it "allows revocation of an active token" do
|
|
visit user_settings_personal_access_tokens_path
|
|
accept_gl_confirm(button_text: 'Revoke') { click_on "Revoke" }
|
|
|
|
expect(active_access_tokens).to have_text("This user has no active personal access tokens.")
|
|
end
|
|
|
|
it "removes expired tokens from 'active' section" do
|
|
personal_access_token.update!(expires_at: 5.days.ago)
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
expect(active_access_tokens).to have_text("This user has no active personal access tokens.")
|
|
end
|
|
|
|
context "when revocation fails" do
|
|
it "displays an error message" do
|
|
allow_next_instance_of(PersonalAccessTokens::RevokeService) do |instance|
|
|
allow(instance).to receive(:revocation_permitted?).and_return(false)
|
|
end
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
accept_gl_confirm(button_text: "Revoke") { click_on "Revoke" }
|
|
expect(active_access_tokens).to have_text(personal_access_token.name)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "rotating tokens" do
|
|
let!(:personal_access_token) { create(:personal_access_token, user: user) }
|
|
|
|
it "displays the newly created token" do
|
|
visit user_settings_personal_access_tokens_path
|
|
expect(active_access_tokens_counter).to have_text('1')
|
|
accept_gl_confirm(button_text: s_('AccessTokens|Rotate')) { click_on s_('AccessTokens|Rotate') }
|
|
wait_for_all_requests
|
|
expect(page).to have_content("Your new personal access token has been created.")
|
|
expect(active_access_tokens).to have_text(personal_access_token.name)
|
|
expect(created_access_token).to match(/[\w-]{20}/)
|
|
expect(active_access_tokens_counter).to have_text('1')
|
|
end
|
|
|
|
context "when rotation fails" do
|
|
it "displays an error message" do
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
accept_gl_confirm(button_text: s_('AccessTokens|Rotate')) do
|
|
personal_access_token.revoke!
|
|
click_on s_('AccessTokens|Rotate')
|
|
end
|
|
|
|
wait_for_all_requests
|
|
expect(page).to have_content(s_('AccessTokens|Token already revoked'))
|
|
end
|
|
end
|
|
end
|
|
|
|
it "prefills token details" do
|
|
name = 'My PAT'
|
|
description = 'My PAT description'
|
|
scopes = 'api,read_user'
|
|
|
|
visit user_settings_personal_access_tokens_path({ name: name, scopes: scopes, description: description })
|
|
|
|
expect(page).to have_field("Token name", with: name)
|
|
expect(page).to have_field("Token description", with: description)
|
|
expect(find("#personal_access_token_scopes_api")).to be_checked
|
|
expect(find("#personal_access_token_scopes_read_user")).to be_checked
|
|
end
|
|
|
|
describe "feed token" do
|
|
def feed_token_description
|
|
"Your feed token authenticates you when your RSS reader loads a personalized RSS feed or when your calendar\
|
|
application loads a personalized calendar. It is visible in those feed URLs. It cannot be used to access\
|
|
any other data."
|
|
end
|
|
|
|
context "when enabled" do
|
|
it "displays feed token" do
|
|
allow(Gitlab::CurrentSettings).to receive(:disable_feed_token).and_return(false)
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
within_testid('feed-token-container') do
|
|
click_button('Click to reveal')
|
|
|
|
expect(page).to have_field('Feed token', with: user.feed_token)
|
|
expect(page).to have_content(feed_token_description)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when disabled" do
|
|
it "does not display feed token" do
|
|
allow(Gitlab::CurrentSettings).to receive(:disable_feed_token).and_return(true)
|
|
visit user_settings_personal_access_tokens_path
|
|
|
|
expect(page).not_to have_content(feed_token_description)
|
|
expect(page).not_to have_field('Feed token')
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|