From c13c8ff01fcce7bf183c9bd0920fccef1e9e912f Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 18 Mar 2025 18:07:22 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/global.gitlab-ci.yml | 42 --- .gitlab/ci/rails.gitlab-ci.yml | 17 +- .gitlab/ci/rails/shared.gitlab-ci.yml | 4 +- .gitlab/ci/rules.gitlab-ci.yml | 30 -- .../gitlab/feature_flag_without_actor.yml | 1 - ...e_end_string_concatenation_indentation.yml | 1 - .rubocop_todo/rspec/feature_category.yml | 1 - .rubocop_todo/rspec/named_subject.yml | 1 - .../rspec/verified_double_reference.yml | 2 - AI_GATEWAY_VERSION | 1 - .../groups_projects/components/tab_view.vue | 48 ++- .../components/tabs_with_list.vue | 21 +- .../edit/components/sections/google_play.vue | 2 +- .../javascripts/lib/utils/file_upload.js | 4 +- .../components/csv_upload_modal.vue | 22 +- .../shared/components/groups_view.vue | 2 +- .../shared/components/projects_view.vue | 2 +- .../profile/components/overview_tab.vue | 2 +- .../projects/your_work/components/app.vue | 4 +- .../projects/your_work/constants.js | 28 +- .../search/topbar/components/app.vue | 6 +- ...ox_by_type.vue => global_search_input.vue} | 2 +- .../groups_list/groups_list.stories.js | 2 +- .../components/groups_list/groups_list.vue | 5 +- .../nested_groups_projects_list.vue | 1 + .../projects_list/projects_list.vue | 5 +- .../upload_dropzone/upload_dropzone.vue | 5 + .../concerns/request_payload_logger.rb | 1 - ..._setting_vscode_extension_marketplace.json | 9 +- .../development/log_response_length.yml | 8 - ...250317122642_fix_secureflag_description.rb | 18 ++ db/schema_migrations/20250317122642 | 1 + doc/development/ai_features/_index.md | 171 +---------- .../ai_features/ai_development_license.md | 281 ++++++++++++++++++ .../ai_features/staging_accounts.md | 17 +- doc/development/custom_models/_index.md | 87 ------ .../python_guide/maintainership.md | 40 ++- .../repository/code_suggestions/_index.md | 22 +- lib/api/api.rb | 3 +- .../security/training_providers/importer.rb | 2 +- .../grape_logging/loggers/response_logger.rb | 26 -- lib/gitlab/lograge/custom_options.rb | 6 +- locale/gitlab.pot | 3 + .../10_govern/login/register_spec.rb | 3 +- scripts/utils.sh | 18 +- .../application_controller_spec.rb | 22 -- .../oauth/tokens_controller_spec.rb | 22 -- .../components/tab_view_spec.js | 12 +- .../components/tabs_with_list_spec.js | 6 + .../components/csv_upload_modal_spec.js | 29 +- .../shared/components/groups_view_spec.js | 4 +- .../shared/components/projects_view_spec.js | 2 +- .../profile/components/overview_tab_spec.js | 2 +- .../projects/your_work/components/app_spec.js | 7 +- .../search/topbar/components/app_spec.js | 6 +- .../components/search_box_by_type_spec.js | 6 +- .../groups_list/groups_list_spec.js | 6 +- .../projects_list/projects_list_spec.js | 4 +- .../upload_dropzone/upload_dropzone_spec.js | 46 +++ .../loggers/response_logger_spec.rb | 37 --- .../lib/gitlab/lograge/custom_options_spec.rb | 17 +- spec/models/application_setting_spec.rb | 20 +- spec/support/known_rspec_metadata_keys.yml | 2 - spec/support/rspec_order_todo.yml | 1 - 64 files changed, 597 insertions(+), 631 deletions(-) delete mode 100644 AI_GATEWAY_VERSION rename app/assets/javascripts/search/topbar/components/{search_box_by_type.vue => global_search_input.vue} (99%) delete mode 100644 config/feature_flags/development/log_response_length.yml create mode 100644 db/post_migrate/20250317122642_fix_secureflag_description.rb create mode 100644 db/schema_migrations/20250317122642 create mode 100644 doc/development/ai_features/ai_development_license.md delete mode 100644 doc/development/custom_models/_index.md delete mode 100644 lib/gitlab/grape_logging/loggers/response_logger.rb delete mode 100644 spec/lib/gitlab/grape_logging/loggers/response_logger_spec.rb diff --git a/.gitlab/ci/global.gitlab-ci.yml b/.gitlab/ci/global.gitlab-ci.yml index 63e52067421..383c3a6f39b 100644 --- a/.gitlab/ci/global.gitlab-ci.yml +++ b/.gitlab/ci/global.gitlab-ci.yml @@ -343,44 +343,6 @@ - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:zoekt-ci-image-1.9 alias: zoekt-ci-image -.ai-gateway-variables: - variables: - AIGW_AUTH__BYPASS_EXTERNAL: true - AIGW_GOOGLE_CLOUD_PLATFORM__PROJECT: $VERTEX_AI_PROJECT - AIGW_GOOGLE_CLOUD_PLATFORM__SERVICE_ACCOUNT_JSON_KEY: $VERTEX_AI_CREDENTIALS - AIGW_FASTAPI__DOCS_URL: "/docs" - AIGW_FASTAPI__OPENAPI_URL: "/openapi.json" - AIGW_FASTAPI__API_PORT: 5052 - ANTHROPIC_API_KEY: $ANTHROPIC_API_KEY_FOR_SERVICE - # CI_DEBUG_SERVICES: "true" # Enable this variable when you debug ai-gateway boot failure. - -.ai-gateway-services: - services: - - name: registry.gitlab.com/gitlab-org/modelops/applied-ml/code-suggestions/ai-assist/model-gateway:v1.18.0 - alias: ai-gateway - -.litellm-proxy-variables: - variables: - LITELLM_CONFIG_CONTENT: | - model_list: - - model_name: codestral - litellm_params: - model: ollama/codestral - mock_response: "Mock response from codestral" - - model_name: mistral - litellm_params: - model: ollama/mistral - mock_response: "Mock response from mistral" - -.litellm-proxy-services: - services: - - name: ghcr.io/berriai/litellm:main-latest - alias: litellm-proxy - entrypoint: ["/bin/sh", "-c"] - command: - - | - mkdir -p /tmp && echo "${LITELLM_CONFIG_CONTENT}" > /tmp/config.yaml && litellm --config /tmp/config.yaml - .use-pg14: extends: - .pg-base-variables @@ -431,13 +393,9 @@ extends: - .use-pg14 - .zoekt-variables - - .ai-gateway-variables - - .litellm-proxy-variables services: - !reference [.db-services-with-auto-explain, services] - !reference [.es7-services, services] - - !reference [.ai-gateway-services, services] - - !reference [.litellm-proxy-services, services] .use-pg15-es7-ee: extends: diff --git a/.gitlab/ci/rails.gitlab-ci.yml b/.gitlab/ci/rails.gitlab-ci.yml index 1341e9a3462..e2d3008a6b9 100644 --- a/.gitlab/ci/rails.gitlab-ci.yml +++ b/.gitlab/ci/rails.gitlab-ci.yml @@ -895,21 +895,6 @@ rspec-ee integration pg16 single-db-sec-connection: - .rspec-ee-integration-parallel - .rails:rules:single-db-sec-connection-ee -.custom-models-variables: - variables: - AIGW_CUSTOM_MODELS__ENABLED: true - AI_GATEWAY_URL: http://ai-gateway:5052 - LITELLM_PROXY_URL: http://litellm-proxy:4000 - -rspec-ee system custom-models pg16: - extends: - - .rspec-ee-base-pg16 - - .rails:rules:ee-only-system - - .custom-models-variables - script: - - !reference [.base-script, script] - - rspec_parallelized_job "--tag requires_custom_models_setup" - rspec-ee system pg16: extends: - .rspec-ee-base-pg16 @@ -1224,7 +1209,7 @@ rspec-ee system pg17: stage: test script: - !reference [.base-script, script] - - rspec_section rspec_fail_fast "${MATCHING_TESTS_PATH}" "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag ~quarantine --tag ~zoekt --tag ~click_house --tag ~real_ai_request" + - rspec_section rspec_fail_fast "${MATCHING_TESTS_PATH}" "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag ~quarantine --tag ~zoekt --tag ~click_house" rspec fail-fast: extends: diff --git a/.gitlab/ci/rails/shared.gitlab-ci.yml b/.gitlab/ci/rails/shared.gitlab-ci.yml index c2f82a735b2..5c37ef4870d 100644 --- a/.gitlab/ci/rails/shared.gitlab-ci.yml +++ b/.gitlab/ci/rails/shared.gitlab-ci.yml @@ -107,7 +107,7 @@ include: # spec/lib, yet background migration tests are also sitting there, # and they should run on their own jobs so we don't need to run them # in unit tests again. - - rspec_section rspec_parallelized_job "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag ~quarantine --tag ~level:background_migration --tag ~click_house --tag ~real_ai_request" + - rspec_section rspec_parallelized_job "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag ~quarantine --tag ~level:background_migration --tag ~click_house" after_script: - source scripts/utils.sh - log_disk_usage # https://gitlab.com/gitlab-org/gitlab/-/issues/478880 @@ -205,7 +205,7 @@ include: .rspec-base-migration: script: - !reference [.base-script, script] - - rspec_section rspec_parallelized_job "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag ~quarantine --tag ~zoekt --tag ~click_house --tag ~real_ai_request" + - rspec_section rspec_parallelized_job "--fail-fast=${RSPEC_FAIL_FAST_THRESHOLD} --tag ~quarantine --tag ~zoekt --tag ~click_house" after_script: - !reference [.rspec-base, after_script] diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 80863db629f..69aa6aa3657 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -2384,36 +2384,6 @@ - <<: *if-default-refs changes: *code-backstage-patterns -.rails:rules:ee-gitlab-duo-chat-base: - rules: - - !reference [".strict-ee-only-rules", rules] - - if: '$ANTHROPIC_API_KEY == null' - when: never - - <<: *if-fork-merge-request - when: never - -.rails:rules:ee-gitlab-duo-chat-optional: - rules: - - !reference [".rails:rules:ee-gitlab-duo-chat-base", rules] - - <<: *if-merge-request - changes: *backend-patterns - when: never - allow_failure: true - -.rails:rules:ee-gitlab-duo-chat-always: - rules: - - !reference [".rails:rules:ee-gitlab-duo-chat-base", rules] - - <<: *if-merge-request - changes: *ai-patterns - -.rails:rules:ee-gitlab-duo-chat-qa-full: - rules: - - !reference [".rails:rules:ee-gitlab-duo-chat-optional", rules] - - <<: *if-default-branch-refs - changes: *setup-test-env-patterns - when: never - allow_failure: true - .rails:rules:db:check-schema: rules: - <<: *if-not-ee diff --git a/.rubocop_todo/gitlab/feature_flag_without_actor.yml b/.rubocop_todo/gitlab/feature_flag_without_actor.yml index 80e79892c36..d052a6d0cb4 100644 --- a/.rubocop_todo/gitlab/feature_flag_without_actor.yml +++ b/.rubocop_todo/gitlab/feature_flag_without_actor.yml @@ -149,7 +149,6 @@ Gitlab/FeatureFlagWithoutActor: - 'lib/gitlab/git/diff.rb' - 'lib/gitlab/git/repository.rb' - 'lib/gitlab/git/user.rb' - - 'lib/gitlab/grape_logging/loggers/response_logger.rb' - 'lib/gitlab/internal_events.rb' - 'lib/gitlab/lograge/custom_options.rb' - 'lib/gitlab/memory/reports/heap_dump.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml index f8420befaf8..e543c5fff18 100644 --- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -306,7 +306,6 @@ Layout/LineEndStringConcatenationIndentation: - 'ee/spec/services/protected_environments/update_service_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/ci_action/template_spec.rb' - 'ee/spec/services/security/token_revocation_service_spec.rb' - - 'ee/spec/support/llm.rb' - 'ee/spec/support/shared_examples/lib/gitlab/llm/chain/slash_command_tool_shared_examples.rb' - 'ee/spec/support/shared_examples/requests/api/graphql/ci/queueing_history_shared_examples.rb' - 'ee/spec/support/shared_examples/requests/identity_verification_shared_examples.rb' diff --git a/.rubocop_todo/rspec/feature_category.yml b/.rubocop_todo/rspec/feature_category.yml index 2adb29399b6..be7e73a23b6 100644 --- a/.rubocop_todo/rspec/feature_category.yml +++ b/.rubocop_todo/rspec/feature_category.yml @@ -2498,7 +2498,6 @@ RSpec/FeatureCategory: - 'spec/lib/gitlab/grape_logging/loggers/filter_parameters_spec.rb' - 'spec/lib/gitlab/grape_logging/loggers/perf_logger_spec.rb' - 'spec/lib/gitlab/grape_logging/loggers/queue_duration_logger_spec.rb' - - 'spec/lib/gitlab/grape_logging/loggers/response_logger_spec.rb' - 'spec/lib/gitlab/grape_logging/loggers/token_logger_spec.rb' - 'spec/lib/gitlab/grape_logging/loggers/urgency_logger_spec.rb' - 'spec/lib/gitlab/graphql/authorize/authorize_resource_spec.rb' diff --git a/.rubocop_todo/rspec/named_subject.yml b/.rubocop_todo/rspec/named_subject.yml index c3a217604a2..9adc0303f5f 100644 --- a/.rubocop_todo/rspec/named_subject.yml +++ b/.rubocop_todo/rspec/named_subject.yml @@ -1966,7 +1966,6 @@ RSpec/NamedSubject: - 'spec/lib/gitlab/grape_logging/loggers/exception_logger_spec.rb' - 'spec/lib/gitlab/grape_logging/loggers/filter_parameters_spec.rb' - 'spec/lib/gitlab/grape_logging/loggers/queue_duration_logger_spec.rb' - - 'spec/lib/gitlab/grape_logging/loggers/response_logger_spec.rb' - 'spec/lib/gitlab/grape_logging/loggers/token_logger_spec.rb' - 'spec/lib/gitlab/graphql/batch_key_spec.rb' - 'spec/lib/gitlab/graphql/copy_field_description_spec.rb' diff --git a/.rubocop_todo/rspec/verified_double_reference.yml b/.rubocop_todo/rspec/verified_double_reference.yml index 0d7387cebdc..937da31b45b 100644 --- a/.rubocop_todo/rspec/verified_double_reference.yml +++ b/.rubocop_todo/rspec/verified_double_reference.yml @@ -3,8 +3,6 @@ RSpec/VerifiedDoubleReference: Exclude: - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb' - - 'ee/spec/features/custom_models/code_suggestions_spec.rb' - - 'ee/spec/features/custom_models/duo_chat_spec.rb' - 'ee/spec/features/merge_request/user_sees_security_policy_rules_licence_compliance_spec.rb' - 'ee/spec/features/projects/google_cloud/artifact_registry_spec.rb' - 'ee/spec/features/projects/integrations/google_cloud_platform/user_activates_artifact_management_spec.rb' diff --git a/AI_GATEWAY_VERSION b/AI_GATEWAY_VERSION deleted file mode 100644 index ada8921c1f0..00000000000 --- a/AI_GATEWAY_VERSION +++ /dev/null @@ -1 +0,0 @@ -1dbddb919823f69cb58bf36343c84c52ec4a3418 diff --git a/app/assets/javascripts/groups_projects/components/tab_view.vue b/app/assets/javascripts/groups_projects/components/tab_view.vue index fc2378dca4f..e0bcc2a4f33 100644 --- a/app/assets/javascripts/groups_projects/components/tab_view.vue +++ b/app/assets/javascripts/groups_projects/components/tab_view.vue @@ -1,15 +1,12 @@