diff --git a/.eslint_todo/vue-no-unused-properties.mjs b/.eslint_todo/vue-no-unused-properties.mjs index f1ef2e04495..e114be50465 100644 --- a/.eslint_todo/vue-no-unused-properties.mjs +++ b/.eslint_todo/vue-no-unused-properties.mjs @@ -293,8 +293,6 @@ export default { 'ee/app/assets/javascripts/oncall_schedules/components/schedule/components/preset_weeks/weeks_header_item.vue', 'ee/app/assets/javascripts/packages_and_registries/container_registry/explorer/components/list_page/container_scanning_counts.vue', 'ee/app/assets/javascripts/packages_and_registries/settings/project/components/dependency_proxy_packages_settings_form.vue', - 'ee/app/assets/javascripts/product_analytics/onboarding/components/providers/self_managed_provider_card.vue', - 'ee/app/assets/javascripts/product_analytics/onboarding/settings_instrumentation_instructions.vue', 'ee/app/assets/javascripts/projects/components/move_personal_project_to_group_modal.vue', 'ee/app/assets/javascripts/projects/merge_requests/blocking_mr_input_root.vue', 'ee/app/assets/javascripts/projects/settings/branch_rules/components/view/index.vue', diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index e5c035e79af..4fcee4f2a75 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -333befa213dffe9a756658ebd1d85da5d32e8b11 +42c36c24adc64b5d1b0bb467873d67c923c8a612 diff --git a/app/assets/javascripts/boards/components/board_card.vue b/app/assets/javascripts/boards/components/board_card.vue index b4b77bf4564..1e33a358140 100644 --- a/app/assets/javascripts/boards/components/board_card.vue +++ b/app/assets/javascripts/boards/components/board_card.vue @@ -127,7 +127,6 @@ export default { visitUrl(this.item.webUrl); return; } - e.preventDefault(); const isMultiSelect = e.ctrlKey || e.metaKey; if (isMultiSelect && gon?.features?.boardMultiSelect) { @@ -174,9 +173,7 @@ export default { changeFocusInColumn(currentCard, i) { // Building a list using data-col-index instead of just traversing the ul is necessary for swimlanes const columnCards = [ - ...document.querySelectorAll( - `button.board-card-button[data-col-index="${this.columnIndex}"]`, - ), + ...document.querySelectorAll(`a.board-card-button[data-col-index="${this.columnIndex}"]`), ]; const currentIndex = columnCards.indexOf(currentCard); if (currentIndex + i < 0 || currentIndex + i > columnCards.length - 1) { @@ -206,7 +203,7 @@ export default { return; } // Focus the same index if possible, or last card - const targetCards = lists[currentIndex + i].querySelectorAll('button.board-card-button'); + const targetCards = lists[currentIndex + i].querySelectorAll('a.board-card-button'); if (targetCards.length <= this.index) { targetCards[targetCards.length - 1].focus(); } else { @@ -241,26 +238,28 @@ export default { data-testid="board-card" class="board-card gl-border gl-relative gl-mb-3 gl-rounded-base gl-border-section gl-bg-section gl-leading-normal hover:gl-bg-subtle dark:hover:gl-bg-gray-200" > - + diff --git a/app/assets/javascripts/boards/components/board_card_inner.vue b/app/assets/javascripts/boards/components/board_card_inner.vue index 58e756ef8e0..f155f05cc8c 100644 --- a/app/assets/javascripts/boards/components/board_card_inner.vue +++ b/app/assets/javascripts/boards/components/board_card_inner.vue @@ -255,10 +255,10 @@ export default { };