From 84f5d32c70bced1464f82aa2cd6263feb38a16f5 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 11 Mar 2025 21:09:32 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/qa-common/rules.gitlab-ci.yml | 1 + .../index/components/integrations_table.vue | 32 ++- .../javascripts/notebook/cells/code.vue | 12 +- .../javascripts/notebook/cells/code/index.vue | 7 +- app/assets/javascripts/notebook/index.vue | 3 + .../work_item_attributes_wrapper.vue | 1 + app/finders/namespaces/projects_finder.rb | 6 + .../resolvers/namespace_projects_resolver.rb | 7 +- app/models/bulk_imports/entity.rb | 5 +- .../ci/project_with_pipeline_variable.rb | 20 ++ .../start_pipeline_service.rb | 1 + .../push_rule_file_size_limit.yml | 9 + config/gitlab_loose_foreign_keys.yml | 4 + ...container-registry-s3v1-storage driver.yml | 24 ++ db/docs/projects_with_pipeline_variables.yml | 14 + db/docs/vulnerability_state_transitions.yml | 12 +- ..._project_id_to_merge_request_diff_files.rb | 29 ++ ...ate_ci_projects_with_pipeline_variables.rb | 11 + ...y_state_transitions_project_id_not_null.rb | 14 + ...async_index_to_merge_request_diff_files.rb | 20 ++ db/schema_migrations/20250224231330 | 1 + db/schema_migrations/20250226084225 | 1 + db/schema_migrations/20250303230228 | 1 + db/schema_migrations/20250307080738 | 1 + db/structure.sql | 17 +- doc/api/graphql/reference/_index.md | 44 +++ .../documentation/graphql_styleguide.md | 4 +- doc/development/documentation/metadata.md | 2 +- .../documentation/restful_api_styleguide.md | 2 +- .../site_architecture/global_nav.md | 31 +-- .../styleguide/deprecations_and_removals.md | 2 +- doc/development/integrations/_index.md | 2 +- doc/update/breaking_windows.md | 1 + doc/update/deprecations.md | 26 ++ .../application_security/remediate/_index.md | 83 ++++++ doc/user/duo_workflow/use_cases.md | 256 ++++++++++++++++++ doc/user/glql/_index.md | 4 +- doc/user/glql/functions.md | 2 +- .../merge_requests/approvals/_index.md | 5 +- lib/gitlab/checks/changes_access.rb | 2 +- ...size_check.rb => file_size_limit_check.rb} | 4 +- locale/gitlab.pot | 32 ++- qa/Gemfile | 2 +- qa/Gemfile.lock | 8 +- .../push_over_ssh_file_size_spec.rb | 71 +++++ scripts/frontend/quarantined_vue3_specs.txt | 1 - spec/db/schema_spec.rb | 1 + .../namespaces/projects_finder_spec.rb | 26 ++ spec/frontend/fixtures/raw.rb | 4 + spec/frontend/notebook/cells/code_spec.js | 18 ++ spec/frontend/notebook/cells/markdown_spec.js | 20 +- spec/frontend/notebook/index_spec.js | 15 + .../namespace_projects_resolver_spec.rb | 23 ++ spec/lib/gitlab/checks/changes_access_spec.rb | 2 +- ..._spec.rb => file_size_limit_check_spec.rb} | 10 +- spec/lib/gitlab/database/sharding_key_spec.rb | 8 +- spec/lib/gitlab/git/repository_spec.rb | 2 +- spec/models/bulk_imports/entity_spec.rb | 4 +- .../ci/project_with_pipeline_variable_spec.rb | 41 +++ .../start_pipeline_service_spec.rb | 8 + spec/support/helpers/test_env.rb | 3 +- 61 files changed, 919 insertions(+), 103 deletions(-) create mode 100644 app/models/ci/project_with_pipeline_variable.rb create mode 100644 config/feature_flags/gitlab_com_derisk/push_rule_file_size_limit.yml create mode 100644 data/deprecations/17.10-container-registry-s3v1-storage driver.yml create mode 100644 db/docs/projects_with_pipeline_variables.yml create mode 100644 db/migrate/20250224231330_add_project_id_to_merge_request_diff_files.rb create mode 100644 db/migrate/20250307080738_create_ci_projects_with_pipeline_variables.rb create mode 100644 db/post_migrate/20250226084225_add_vulnerability_state_transitions_project_id_not_null.rb create mode 100644 db/post_migrate/20250303230228_add_async_index_to_merge_request_diff_files.rb create mode 100644 db/schema_migrations/20250224231330 create mode 100644 db/schema_migrations/20250226084225 create mode 100644 db/schema_migrations/20250303230228 create mode 100644 db/schema_migrations/20250307080738 create mode 100644 doc/user/application_security/remediate/_index.md create mode 100644 doc/user/duo_workflow/use_cases.md rename lib/gitlab/checks/{global_file_size_check.rb => file_size_limit_check.rb} (95%) create mode 100644 qa/qa/specs/features/browser_ui/3_create/repository/push_over_ssh_file_size_spec.rb rename spec/lib/gitlab/checks/{global_file_size_check_spec.rb => file_size_limit_check_spec.rb} (83%) create mode 100644 spec/models/ci/project_with_pipeline_variable_spec.rb diff --git a/.gitlab/ci/qa-common/rules.gitlab-ci.yml b/.gitlab/ci/qa-common/rules.gitlab-ci.yml index 824181af270..6102c44d5f8 100644 --- a/.gitlab/ci/qa-common/rules.gitlab-ci.yml +++ b/.gitlab/ci/qa-common/rules.gitlab-ci.yml @@ -87,6 +87,7 @@ # by checking code patterns, skip running job on changes that can't affect the outcome - *mr-code-patterns - *default-branch + - *mr-stable-branch-code-patterns .rules:test:update-patch: rules: diff --git a/app/assets/javascripts/integrations/index/components/integrations_table.vue b/app/assets/javascripts/integrations/index/components/integrations_table.vue index cb9bad18c96..1390126d5a4 100644 --- a/app/assets/javascripts/integrations/index/components/integrations_table.vue +++ b/app/assets/javascripts/integrations/index/components/integrations_table.vue @@ -6,6 +6,15 @@ import TimeAgoTooltip from '~/vue_shared/components/time_ago_tooltip.vue'; import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin'; export default { + i18n: { + addIntegrationTitle: s__('Integrations|Add integration'), + addIntegrationAriaLabel: (title) => + sprintf(s__('Integrations|Add new %{title} integration'), { title }), + addIntegrationText: __('Add'), + configureIntegrationText: __('Configure'), + configureIntegrationAriaLabel: (title) => + sprintf(s__('Integrations|Configure %{title}'), { title }), + }, components: { GlAvatar, GlAvatarLink, @@ -50,8 +59,8 @@ export default { fields.push( { key: 'active', - label: '', - thClass: 'gl-w-7', + label: __('Active'), + thClass: 'gl-w-7 gl-sr-only', tdClass: '!gl-border-b-0 !gl-align-middle', }, { @@ -74,8 +83,8 @@ export default { fields.push({ key: 'edit_path', - label: '', - thClass: 'gl-w-15', + label: __('Actions'), + thClass: 'gl-w-15 gl-sr-only', tdClass: '!gl-border-b-0 gl-text-right !gl-align-middle', }); @@ -140,12 +149,15 @@ export default { :entity-name="item.title" :alt="item.title" :size="48" + aria-hidden="true" shape="rect" class="integration-logo" />

{{ item.title }}

-

{{ item.description }}

+

+ {{ item.description }} +

@@ -166,8 +178,10 @@ export default { :href="item.edit_path" category="secondary" icon="plus" - :title="s__('Integrations|Add integration')" - >{{ __('Add') }}{{ $options.i18n.addIntegrationText }} diff --git a/app/assets/javascripts/notebook/cells/code.vue b/app/assets/javascripts/notebook/cells/code.vue index bc1bab62553..248d93908df 100644 --- a/app/assets/javascripts/notebook/cells/code.vue +++ b/app/assets/javascripts/notebook/cells/code.vue @@ -23,18 +23,26 @@ export default { return this.cell.source || ''; }, hasOutput() { - return this.cell.outputs.length; + return this.cell.outputs?.length; }, outputs() { return this.cell.outputs; }, + language() { + return this.cell.cell_type === 'raw' ? 'txt' : 'python'; + }, }, };