diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index e61e1cff8af..e2924bdfffc 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -526,7 +526,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/kubernetes/rollout_instances.rb' - 'lib/gitlab/language_data.rb' - 'lib/gitlab/lets_encrypt/client.rb' - - 'lib/gitlab/metrics/prometheus.rb' - 'lib/gitlab/prometheus_client.rb' - 'lib/gitlab/rack_attack/request.rb' - 'lib/gitlab/redis/multi_store.rb' diff --git a/.rubocop_todo/layout/line_continuation_spacing.yml b/.rubocop_todo/layout/line_continuation_spacing.yml index 7b2c125ac62..fa649521005 100644 --- a/.rubocop_todo/layout/line_continuation_spacing.yml +++ b/.rubocop_todo/layout/line_continuation_spacing.yml @@ -2,7 +2,6 @@ # Cop supports --autocorrect. Layout/LineContinuationSpacing: Exclude: - - 'app/helpers/projects_helper.rb' - 'app/helpers/tags_helper.rb' - 'app/helpers/tree_helper.rb' - 'app/models/concerns/spammable.rb' diff --git a/GITLAB_KAS_VERSION b/GITLAB_KAS_VERSION index a9bf7da17b7..02ad143ea51 100644 --- a/GITLAB_KAS_VERSION +++ b/GITLAB_KAS_VERSION @@ -1 +1 @@ -403b947e4d6bcaa170535e7972a536a2ab21b5d4 +09aa77d55b90fa51939ea12867eb2aaf43c61ee2 diff --git a/app/assets/javascripts/boards/components/board_list_header.vue b/app/assets/javascripts/boards/components/board_list_header.vue index 6846363939a..9fa941853f5 100644 --- a/app/assets/javascripts/boards/components/board_list_header.vue +++ b/app/assets/javascripts/boards/components/board_list_header.vue @@ -213,6 +213,9 @@ export default { filters: this.filterParams, }; }, + showStatusIcon() { + return this.listType === 'status' && (!this.isSwimlanesHeader || !this.list.collapsed); + }, }, apollo: { // eslint-disable-next-line @gitlab/vue-no-undef-apollo-properties @@ -387,7 +390,7 @@ export default { />
diff --git a/app/assets/javascripts/ci/runner/admin_new_runner/index.js b/app/assets/javascripts/ci/runner/admin_new_runner/index.js index 434c1197f71..a603589f0b2 100644 --- a/app/assets/javascripts/ci/runner/admin_new_runner/index.js +++ b/app/assets/javascripts/ci/runner/admin_new_runner/index.js @@ -12,6 +12,8 @@ export const initAdminNewRunner = (selector = '#js-admin-new-runner') => { return null; } + const { runnersPath } = el.dataset; + const apolloProvider = new VueApollo({ defaultClient: createDefaultClient(), }); @@ -20,7 +22,11 @@ export const initAdminNewRunner = (selector = '#js-admin-new-runner') => { el, apolloProvider, render(h) { - return h(AdminNewRunnerApp); + return h(AdminNewRunnerApp, { + props: { + runnersPath, + }, + }); }, }); }; diff --git a/app/assets/javascripts/ci/runner/components/runner_create_wizard.vue b/app/assets/javascripts/ci/runner/components/runner_create_wizard.vue index 2eeece2b639..8da6238d062 100644 --- a/app/assets/javascripts/ci/runner/components/runner_create_wizard.vue +++ b/app/assets/javascripts/ci/runner/components/runner_create_wizard.vue @@ -17,12 +17,17 @@ export default { required: true, validator: (t) => RUNNER_TYPES.includes(t), }, + runnersPath: { + type: String, + required: true, + }, }, data() { return { currentStep: 1, tags: '', runUntagged: false, + newRunnerId: null, }; }, methods: { @@ -36,6 +41,9 @@ export default { this.tags = requiredFields.tags; this.runUntagged = requiredFields.runUntagged; }, + onGetNewRunnerId(runnerId) { + this.newRunnerId = runnerId; + }, }, stepsTotal: 3, }; @@ -59,10 +67,13 @@ export default { :runner-type="runnerType" @next="onNext" @back="onBack" + @onGetNewRunnerId="onGetNewRunnerId" /> diff --git a/app/assets/javascripts/ci/runner/components/runner_create_wizard_optional_fields.vue b/app/assets/javascripts/ci/runner/components/runner_create_wizard_optional_fields.vue index aa797e9e14e..fc9df49e1aa 100644 --- a/app/assets/javascripts/ci/runner/components/runner_create_wizard_optional_fields.vue +++ b/app/assets/javascripts/ci/runner/components/runner_create_wizard_optional_fields.vue @@ -120,6 +120,7 @@ export default { return; } + this.$emit('onGetNewRunnerId', runner.id); this.$emit('next'); // destroy the alert createAlert({ message: null }).dismiss(); diff --git a/app/assets/javascripts/ci/runner/components/runner_create_wizard_registration.vue b/app/assets/javascripts/ci/runner/components/runner_create_wizard_registration.vue index fea81a4a068..7841d364609 100644 --- a/app/assets/javascripts/ci/runner/components/runner_create_wizard_registration.vue +++ b/app/assets/javascripts/ci/runner/components/runner_create_wizard_registration.vue @@ -1,11 +1,31 @@ @@ -26,10 +90,79 @@ export default { :steps-total="stepsTotal" > -