From 5ecacec30458330df5fa6d591dc58e37afb41cd4 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 4 Oct 2019 15:06:38 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/frontend.gitlab-ci.yml | 30 +- .gitlab/ci/global.gitlab-ci.yml | 5 + .gitlab/ci/rails.gitlab-ci.yml | 19 + app/assets/javascripts/gfm_auto_complete.js | 1 + .../commit_sidebar/editor_header.vue | 7 +- .../components/commit_sidebar/list_item.vue | 3 + .../ide/components/file_row_extra.vue | 10 +- .../ide/components/ide_tree_list.vue | 7 +- .../ide/components/new_dropdown/modal.vue | 1 - .../ide/components/repo_editor.vue | 24 +- app/assets/javascripts/ide/lib/files.js | 4 +- app/assets/javascripts/ide/stores/actions.js | 69 ++- .../javascripts/ide/stores/actions/file.js | 9 +- .../javascripts/ide/stores/actions/project.js | 84 ++-- .../ide/stores/modules/commit/actions.js | 2 - .../javascripts/ide/stores/mutation_types.js | 4 +- .../javascripts/ide/stores/mutations.js | 113 +++-- .../javascripts/ide/stores/mutations/file.js | 18 +- app/assets/javascripts/ide/stores/state.js | 1 - app/assets/javascripts/ide/stores/utils.js | 70 ++- .../components/changed_file_icon.vue | 8 +- .../vue_shared/components/file_row.vue | 2 +- .../stylesheets/framework/animations.scss | 15 - app/graphql/resolvers/issues_resolver.rb | 2 +- app/graphql/types/issuable_sort_enum.rb | 10 + app/graphql/types/issue_sort_enum.rb | 10 + ...g-labels-when-using-label-quick-action.yml | 5 + jest.config.js | 5 +- .../import_export/project_tree_restorer.rb | 4 +- lib/gitlab/sidekiq_config.rb | 14 +- lib/tasks/frontend.rake | 5 +- .../projects/environments_controller_spec.rb | 4 +- .../frontend/fixtures/autocomplete_sources.rb | 4 + spec/frontend/ide/lib/files_spec.js | 4 +- .../commit_sidebar/list_item_spec.js | 34 +- .../ide/components/file_row_extra_spec.js | 21 + .../ide/components/ide_tree_list_spec.js | 14 - .../ide/components/repo_editor_spec.js | 83 +++- .../ide/stores/actions/project_spec.js | 197 ++++++--- spec/javascripts/ide/stores/actions_spec.js | 367 +++++++++++++--- .../ide/stores/modules/commit/actions_spec.js | 92 ++-- .../ide/stores/mutations/file_spec.js | 19 +- spec/javascripts/ide/stores/mutations_spec.js | 405 +++++++++++++++--- spec/javascripts/ide/stores/utils_spec.js | 225 ++++++++-- spec/javascripts/lazy_loader_spec.js | 18 +- .../vue_shared/components/file_row_spec.js | 13 - spec/lib/gitlab_spec.rb | 1 + 47 files changed, 1545 insertions(+), 517 deletions(-) create mode 100644 app/graphql/types/issuable_sort_enum.rb create mode 100644 app/graphql/types/issue_sort_enum.rb create mode 100644 changelogs/unreleased/17596-show-all-matching-labels-when-using-label-quick-action.yml diff --git a/.gitlab/ci/frontend.gitlab-ci.yml b/.gitlab/ci/frontend.gitlab-ci.yml index 1feda7ed4d4..16b85696727 100644 --- a/.gitlab/ci/frontend.gitlab-ci.yml +++ b/.gitlab/ci/frontend.gitlab-ci.yml @@ -123,7 +123,7 @@ compile-assets pull-cache: - .use-pg9 dependencies: ["compile-assets", "compile-assets pull-cache", "setup-test-env"] -karma: +.karma-base: extends: .only-code-frontend-job-base variables: # we override the max_old_space_size to prevent OOM errors @@ -134,6 +134,9 @@ karma: - scripts/gitaly-test-spawn - date - bundle exec rake karma + +karma: + extends: .karma-base coverage: '/^Statements *: (\d+\.\d+%)/' artifacts: name: coverage-javascript @@ -146,7 +149,12 @@ karma: reports: junit: junit_karma.xml -jest: +karma-foss: + extends: + - .karma-base + - .only-ee-as-if-foss + +.jest-base: extends: .only-code-frontend-job-base script: - scripts/gitaly-test-spawn @@ -154,6 +162,14 @@ jest: - bundle exec rake frontend:fixtures - date - yarn jest --ci --coverage + cache: + key: jest + paths: + - tmp/jest/jest/ + policy: pull-push + +jest: + extends: .jest-base artifacts: name: coverage-frontend expire_in: 31d @@ -164,11 +180,13 @@ jest: - tmp/tests/frontend/ reports: junit: junit_jest.xml + +jest-foss: + extends: + - .jest-base + - .only-ee-as-if-foss cache: - key: jest - paths: - - tmp/jest/jest/ - policy: pull-push + policy: pull .qa-job-base: extends: diff --git a/.gitlab/ci/global.gitlab-ci.yml b/.gitlab/ci/global.gitlab-ci.yml index e082d584b0c..0c0591d3fdc 100644 --- a/.gitlab/ci/global.gitlab-ci.yml +++ b/.gitlab/ci/global.gitlab-ci.yml @@ -149,3 +149,8 @@ variables: - $CI_PROJECT_NAME == "gitlab" - $CI_PROJECT_NAME == "gitlab-ee" # Support former project name for forks/mirrors + +.only-ee-as-if-foss: + extends: .only-ee + variables: + IS_GITLAB_EE: '0' diff --git a/.gitlab/ci/rails.gitlab-ci.yml b/.gitlab/ci/rails.gitlab-ci.yml index c315501b0ba..73b649b4d14 100644 --- a/.gitlab/ci/rails.gitlab-ci.yml +++ b/.gitlab/ci/rails.gitlab-ci.yml @@ -74,6 +74,12 @@ setup-test-env: - .rspec-base - .use-pg9 +.rspec-base-pg9-foss: + extends: + - .rspec-base + - .use-pg9 + - .only-ee-as-if-foss + .rspec-base-pg10: extends: - .rspec-base @@ -84,14 +90,27 @@ rspec unit pg9: extends: .rspec-base-pg9 parallel: 20 +rspec unit pg9-foss: + extends: .rspec-base-pg9-foss + parallel: 20 + rspec integration pg9: extends: .rspec-base-pg9 parallel: 6 +rspec integration pg9-foss: + extends: .rspec-base-pg9-foss + parallel: 6 + rspec system pg9: extends: .rspec-base-pg9 parallel: 24 +# TODO: This requires FOSS assets +# rspec system pg9-foss: +# extends: .rspec-base-pg9-foss +# parallel: 24 + rspec unit pg10: extends: .rspec-base-pg10 parallel: 20 diff --git a/app/assets/javascripts/gfm_auto_complete.js b/app/assets/javascripts/gfm_auto_complete.js index b308cd9c236..db3ad0bb4c9 100644 --- a/app/assets/javascripts/gfm_auto_complete.js +++ b/app/assets/javascripts/gfm_auto_complete.js @@ -337,6 +337,7 @@ class GfmAutoComplete { }, // eslint-disable-next-line no-template-curly-in-string insertTpl: '${atwho-at}${title}', + limit: 20, callbacks: { ...this.getDefaultCallbacks(), beforeSave(merges) { diff --git a/app/assets/javascripts/ide/components/commit_sidebar/editor_header.vue b/app/assets/javascripts/ide/components/commit_sidebar/editor_header.vue index 11d5d9639b6..6b2ef34c960 100644 --- a/app/assets/javascripts/ide/components/commit_sidebar/editor_header.vue +++ b/app/assets/javascripts/ide/components/commit_sidebar/editor_header.vue @@ -43,7 +43,12 @@ export default {