From 517b5d6e032bad7ed2b70113749f948c435c2591 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 12 Nov 2024 21:28:41 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../layout/line_continuation_spacing.yml | 1 - .rubocop_todo/rspec/feature_category.yml | 1 - .../javascripts/ci/common/pipelines_table.vue | 6 - .../components/pipelines_table_wrapper.vue | 2 - .../ci/pipeline_details/utils/index.js | 4 + .../header/pipeline_editor_mini_graph.vue | 3 +- .../pipeline_mini_graph/job_action_button.vue | 1 + .../ci/pipeline_mini_graph/job_item.vue | 3 +- .../legacy_pipeline_mini_graph.vue | 43 ++-- .../pipeline_mini_graph.vue | 2 +- .../ci/pipeline_mini_graph/pipeline_stage.vue | 15 +- .../pipeline_mini_graph/pipeline_stages.vue | 13 +- .../pipeline_failed_jobs_widget.vue | 4 +- .../ci/pipelines_page/pipelines.vue | 1 - .../legacy_pipelines_table_wrapper.vue | 1 - .../javascripts/graphql_shared/constants.js | 5 +- .../extensions_marketplace_warning.vue | 2 +- .../components/integration_view.vue | 7 +- .../components/profile_preferences.vue | 1 + .../projects/commit_box/info/utils.js | 1 + .../releases/components/expand_button.vue | 6 +- .../repository/components/commit_info.vue | 2 +- .../reviewers/uncollapsed_reviewer_list.vue | 2 +- .../todos/components/todos_app.vue | 7 +- .../groups_and_projects_listbox.vue | 115 ---------- .../components/inbound_token_access.vue | 53 +++-- .../components/logs_viewer/logs_top_bar.vue | 2 +- app/assets/stylesheets/framework/top_bar.scss | 5 + app/assets/stylesheets/pages/commits.scss | 24 -- app/assets/stylesheets/utilities.scss | 5 - app/helpers/preferences_helper.rb | 22 +- app/models/integrations/asana.rb | 6 +- app/serializers/stage_entity.rb | 2 + .../ci/job_token_scope/add_group_service.rb | 2 +- .../ci/job_token_scope/add_project_service.rb | 2 +- .../job_token_scope/edit_scope_validations.rb | 2 +- app/services/uploads/destroy_service.rb | 2 +- .../_collapsed_inline_list.html.haml | 4 +- app/views/projects/commits/_commit.html.haml | 2 +- .../17-4-secure-container-registries.yml | 1 + ...kfill_operations_strategies_project_id.yml | 2 +- ...ckfill_operations_strategies_project_id.rb | 21 ++ db/schema_migrations/20241108232843 | 1 + .../replication/selective_synchronization.md | 4 +- doc/api/notes.md | 15 +- doc/ci/jobs/ci_job_token.md | 3 +- doc/development/advanced_search.md | 5 +- .../advanced_search_migration_styleguide.md | 12 +- .../execution_context_selection.md | 66 +++--- .../testing_guide/end_to_end/index.md | 217 ++++++++---------- .../end_to_end/test_pipelines.md | 4 +- .../visual_studio_code/custom_queries.md | 2 +- .../visual_studio_code/remote_urls.md | 2 +- .../visual_studio_code/ssl.md | 2 +- .../visual_studio_code/troubleshooting.md | 2 +- doc/user/profile/preferences.md | 4 + doc/user/workspace/index.md | 11 +- .../lib/gitlab/backup/cli/shell/command.rb | 24 +- .../lib/gitlab/backup/cli/shell/pipeline.rb | 10 +- .../lib/gitlab/backup/cli/targets/database.rb | 91 ++------ .../gitlab/backup/cli/shell/command_spec.rb | 102 ++++++++ .../gitlab/backup/cli/shell/pipeline_spec.rb | 15 ++ lib/gitlab/auth/atlassian/token_refresher.rb | 2 +- locale/gitlab.pot | 38 ++- qa/qa/page/merge_request/show.rb | 7 +- .../resource/project_imported_from_github.rb | 5 +- .../import/import_large_github_repo_spec.rb | 1 - .../merge_request_set_to_auto_merge_spec.rb | 119 +++------- .../import/github_import_shared_context.rb | 1 - .../projects/jobs_controller_spec.rb | 2 +- .../projects/pipelines/pipelines_spec.rb | 2 +- spec/fixtures/api/schemas/pipeline_stage.json | 39 +++- .../ci/common/pipelines_table_spec.js | 6 + .../legacy_pipeline_mini_graph_spec.js | 5 +- .../pipeline_stage_spec.js | 1 - .../ci/pipelines_page/pipelines_spec.js | 77 ------- .../legacy_pipelines_table_wrapper_spec.js | 7 +- .../components/integration_view_spec.js | 6 + .../__snapshots__/expand_button_spec.js.snap | 8 +- .../uncollapsed_reviewer_list_spec.js | 26 +++ .../groups_and_projects_listbox_spec.js | 101 -------- .../token_access/inbound_token_access_spec.js | 82 +++---- spec/frontend/token_access/mock_data.js | 4 +- .../vue_merge_request_widget/mock_data.js | 2 + spec/helpers/preferences_helper_spec.rb | 41 ++-- spec/models/integrations/asana_spec.rb | 42 ++-- spec/serializers/stage_entity_spec.rb | 4 + .../job_token_scope/add_group_service_spec.rb | 2 +- .../add_project_service_spec.rb | 13 ++ 89 files changed, 731 insertions(+), 909 deletions(-) delete mode 100644 app/assets/javascripts/token_access/components/groups_and_projects_listbox.vue create mode 100644 db/post_migrate/20241108232843_finalize_backfill_operations_strategies_project_id.rb create mode 100644 db/schema_migrations/20241108232843 delete mode 100644 spec/frontend/token_access/groups_and_projects_listbox_spec.js diff --git a/.rubocop_todo/layout/line_continuation_spacing.yml b/.rubocop_todo/layout/line_continuation_spacing.yml index 7afbdc3321b..ddfa81c64c4 100644 --- a/.rubocop_todo/layout/line_continuation_spacing.yml +++ b/.rubocop_todo/layout/line_continuation_spacing.yml @@ -15,7 +15,6 @@ Layout/LineContinuationSpacing: - 'app/services/feature_flags/update_service.rb' - 'app/services/issues/build_service.rb' - 'app/services/merge_requests/merge_service.rb' - - 'app/services/uploads/destroy_service.rb' - 'app/services/users/email_verification/validate_token_service.rb' - 'ee/app/controllers/ee/ldap/omniauth_callbacks_controller.rb' - 'ee/app/graphql/mutations/requirements_management/export_requirements.rb' diff --git a/.rubocop_todo/rspec/feature_category.yml b/.rubocop_todo/rspec/feature_category.yml index f37c04501ef..aa29ebeece0 100644 --- a/.rubocop_todo/rspec/feature_category.yml +++ b/.rubocop_todo/rspec/feature_category.yml @@ -395,7 +395,6 @@ RSpec/FeatureCategory: - 'ee/spec/helpers/markup_helper_spec.rb' - 'ee/spec/helpers/notes_helper_spec.rb' - 'ee/spec/helpers/path_locks_helper_spec.rb' - - 'ee/spec/helpers/preferences_helper_spec.rb' - 'ee/spec/helpers/prevent_forking_helper_spec.rb' - 'ee/spec/helpers/projects/on_demand_scans_helper_spec.rb' - 'ee/spec/helpers/projects/project_members_helper_spec.rb' diff --git a/app/assets/javascripts/ci/common/pipelines_table.vue b/app/assets/javascripts/ci/common/pipelines_table.vue index 021aa6cb0e6..fac1521f1d1 100644 --- a/app/assets/javascripts/ci/common/pipelines_table.vue +++ b/app/assets/javascripts/ci/common/pipelines_table.vue @@ -72,11 +72,6 @@ export default { return value === PIPELINE_IID_KEY || value === PIPELINE_ID_KEY; }, }, - updateGraphDropdown: { - type: Boolean, - required: false, - default: false, - }, }, computed: { isMobile() { @@ -260,7 +255,6 @@ export default { :downstream-pipelines="getDownstreamPipelines(item)" :pipeline-path="item.path" :stages="getStages(item)" - :update-dropdown="updateGraphDropdown" :upstream-pipeline="item.triggered_by" @miniGraphStageClick="trackPipelineMiniGraph" /> diff --git a/app/assets/javascripts/ci/merge_requests/components/pipelines_table_wrapper.vue b/app/assets/javascripts/ci/merge_requests/components/pipelines_table_wrapper.vue index 818c167c67f..76f4007023a 100644 --- a/app/assets/javascripts/ci/merge_requests/components/pipelines_table_wrapper.vue +++ b/app/assets/javascripts/ci/merge_requests/components/pipelines_table_wrapper.vue @@ -58,7 +58,6 @@ export default { page: 1, pageInfo: {}, pipelines: [], - updateGraphDropdown: false, }; }, apollo: { @@ -345,7 +344,6 @@ export default { { export const graphqlEtagMergeRequestPipelines = (graphqlPath, mergeRequestId) => { return `${graphqlPath}merge_requests/id/${mergeRequestId}`; }; + +export const graphqlEtagStagePath = (graphqlPath, stageId) => { + return `${graphqlPath}/stages/id/${stageId}`; +}; diff --git a/app/assets/javascripts/ci/pipeline_editor/components/header/pipeline_editor_mini_graph.vue b/app/assets/javascripts/ci/pipeline_editor/components/header/pipeline_editor_mini_graph.vue index 993820b854c..b7442f06391 100644 --- a/app/assets/javascripts/ci/pipeline_editor/components/header/pipeline_editor_mini_graph.vue +++ b/app/assets/javascripts/ci/pipeline_editor/components/header/pipeline_editor_mini_graph.vue @@ -65,11 +65,12 @@ export default { } return stages.map(({ node }) => { - const { name, detailedStatus } = node; + const { id, detailedStatus, name } = node; return { // TODO: fetch dropdown_path from graphql when available // see https://gitlab.com/gitlab-org/gitlab/-/issues/342585 dropdown_path: `${this.pipelinePath}/stage.json?stage=${name}`, + id, name, path: `${this.pipelinePath}#${name}`, status: { diff --git a/app/assets/javascripts/ci/pipeline_mini_graph/job_action_button.vue b/app/assets/javascripts/ci/pipeline_mini_graph/job_action_button.vue index cd3c88dac54..68eb79a07cf 100644 --- a/app/assets/javascripts/ci/pipeline_mini_graph/job_action_button.vue +++ b/app/assets/javascripts/ci/pipeline_mini_graph/job_action_button.vue @@ -121,6 +121,7 @@ export default { :aria-label="jobAction.title" :disabled="isLoading" class="gl-h-6 gl-w-6 !gl-rounded-full !gl-p-0" + data-testid="ci-action-button" @click.prevent="onActionButtonClick" > diff --git a/app/assets/javascripts/ci/pipeline_mini_graph/job_item.vue b/app/assets/javascripts/ci/pipeline_mini_graph/job_item.vue index 19b741b9e50..802128e0997 100644 --- a/app/assets/javascripts/ci/pipeline_mini_graph/job_item.vue +++ b/app/assets/javascripts/ci/pipeline_mini_graph/job_item.vue @@ -48,7 +48,7 @@ export default { };