diff --git a/.rubocop_todo/layout/line_continuation_spacing.yml b/.rubocop_todo/layout/line_continuation_spacing.yml index 7afbdc3321b..ddfa81c64c4 100644 --- a/.rubocop_todo/layout/line_continuation_spacing.yml +++ b/.rubocop_todo/layout/line_continuation_spacing.yml @@ -15,7 +15,6 @@ Layout/LineContinuationSpacing: - 'app/services/feature_flags/update_service.rb' - 'app/services/issues/build_service.rb' - 'app/services/merge_requests/merge_service.rb' - - 'app/services/uploads/destroy_service.rb' - 'app/services/users/email_verification/validate_token_service.rb' - 'ee/app/controllers/ee/ldap/omniauth_callbacks_controller.rb' - 'ee/app/graphql/mutations/requirements_management/export_requirements.rb' diff --git a/.rubocop_todo/rspec/feature_category.yml b/.rubocop_todo/rspec/feature_category.yml index f37c04501ef..aa29ebeece0 100644 --- a/.rubocop_todo/rspec/feature_category.yml +++ b/.rubocop_todo/rspec/feature_category.yml @@ -395,7 +395,6 @@ RSpec/FeatureCategory: - 'ee/spec/helpers/markup_helper_spec.rb' - 'ee/spec/helpers/notes_helper_spec.rb' - 'ee/spec/helpers/path_locks_helper_spec.rb' - - 'ee/spec/helpers/preferences_helper_spec.rb' - 'ee/spec/helpers/prevent_forking_helper_spec.rb' - 'ee/spec/helpers/projects/on_demand_scans_helper_spec.rb' - 'ee/spec/helpers/projects/project_members_helper_spec.rb' diff --git a/app/assets/javascripts/ci/common/pipelines_table.vue b/app/assets/javascripts/ci/common/pipelines_table.vue index 021aa6cb0e6..fac1521f1d1 100644 --- a/app/assets/javascripts/ci/common/pipelines_table.vue +++ b/app/assets/javascripts/ci/common/pipelines_table.vue @@ -72,11 +72,6 @@ export default { return value === PIPELINE_IID_KEY || value === PIPELINE_ID_KEY; }, }, - updateGraphDropdown: { - type: Boolean, - required: false, - default: false, - }, }, computed: { isMobile() { @@ -260,7 +255,6 @@ export default { :downstream-pipelines="getDownstreamPipelines(item)" :pipeline-path="item.path" :stages="getStages(item)" - :update-dropdown="updateGraphDropdown" :upstream-pipeline="item.triggered_by" @miniGraphStageClick="trackPipelineMiniGraph" /> diff --git a/app/assets/javascripts/ci/merge_requests/components/pipelines_table_wrapper.vue b/app/assets/javascripts/ci/merge_requests/components/pipelines_table_wrapper.vue index 818c167c67f..76f4007023a 100644 --- a/app/assets/javascripts/ci/merge_requests/components/pipelines_table_wrapper.vue +++ b/app/assets/javascripts/ci/merge_requests/components/pipelines_table_wrapper.vue @@ -58,7 +58,6 @@ export default { page: 1, pageInfo: {}, pipelines: [], - updateGraphDropdown: false, }; }, apollo: { @@ -345,7 +344,6 @@ export default { { export const graphqlEtagMergeRequestPipelines = (graphqlPath, mergeRequestId) => { return `${graphqlPath}merge_requests/id/${mergeRequestId}`; }; + +export const graphqlEtagStagePath = (graphqlPath, stageId) => { + return `${graphqlPath}/stages/id/${stageId}`; +}; diff --git a/app/assets/javascripts/ci/pipeline_editor/components/header/pipeline_editor_mini_graph.vue b/app/assets/javascripts/ci/pipeline_editor/components/header/pipeline_editor_mini_graph.vue index 993820b854c..b7442f06391 100644 --- a/app/assets/javascripts/ci/pipeline_editor/components/header/pipeline_editor_mini_graph.vue +++ b/app/assets/javascripts/ci/pipeline_editor/components/header/pipeline_editor_mini_graph.vue @@ -65,11 +65,12 @@ export default { } return stages.map(({ node }) => { - const { name, detailedStatus } = node; + const { id, detailedStatus, name } = node; return { // TODO: fetch dropdown_path from graphql when available // see https://gitlab.com/gitlab-org/gitlab/-/issues/342585 dropdown_path: `${this.pipelinePath}/stage.json?stage=${name}`, + id, name, path: `${this.pipelinePath}#${name}`, status: { diff --git a/app/assets/javascripts/ci/pipeline_mini_graph/job_action_button.vue b/app/assets/javascripts/ci/pipeline_mini_graph/job_action_button.vue index cd3c88dac54..68eb79a07cf 100644 --- a/app/assets/javascripts/ci/pipeline_mini_graph/job_action_button.vue +++ b/app/assets/javascripts/ci/pipeline_mini_graph/job_action_button.vue @@ -121,6 +121,7 @@ export default { :aria-label="jobAction.title" :disabled="isLoading" class="gl-h-6 gl-w-6 !gl-rounded-full !gl-p-0" + data-testid="ci-action-button" @click.prevent="onActionButtonClick" > diff --git a/app/assets/javascripts/ci/pipeline_mini_graph/job_item.vue b/app/assets/javascripts/ci/pipeline_mini_graph/job_item.vue index 19b741b9e50..802128e0997 100644 --- a/app/assets/javascripts/ci/pipeline_mini_graph/job_item.vue +++ b/app/assets/javascripts/ci/pipeline_mini_graph/job_item.vue @@ -48,7 +48,7 @@ export default { };