From 38ec668b556a862c951bf2b65b180ac90b51e94b Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 14 Jul 2025 21:07:31 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab-ci.yml | 2 +- .rubocop.yml | 7 +- .../example_heredoc_delimiter.yml | 1 - .../node_matcher_directive.yml | 1 - .../on_send_without_on_c_send.yml | 1 - GITALY_SERVER_VERSION | 2 +- .../mailers/ci_pipeline_notif_v2/check.png | Bin 0 -> 312 bytes .../ci_pipeline_notif_v2/icon-branch-gray.gif | Bin 0 -> 437 bytes .../ci_pipeline_notif_v2/icon-commit-gray.gif | Bin 0 -> 259 bytes .../mailers/ci_pipeline_notif_v2/x-red.png | Bin 0 -> 612 bytes .../images/mailers/ci_pipeline_notif_v2/x.png | Bin 0 -> 375 bytes .../gke_registration_instructions.vue | 23 +- ...google_cloud_registration_instructions.vue | 20 +- .../wizard_operating_system_instruction.vue | 144 +++++ .../runner_create_wizard_registration.vue | 109 +++- .../groups/components/overview_tabs.vue | 38 +- .../components/tabs_with_list.vue | 34 +- .../members/components/members_tabs.vue | 2 +- .../members/placeholders/components/app.vue | 2 +- .../components/app.vue | 1 + .../profiles/chat_names_controller.rb | 14 +- app/graphql/types/project_type.rb | 1 + .../projects/repository_language_type.rb | 10 +- .../chat_names/authorize_user_service.rb | 2 +- .../sessions/successful_verification.haml | 13 +- app/views/notify/_failed_builds.html.haml | 8 +- .../notify/_successful_pipeline.html.haml | 32 +- app/views/notify/_users_list.html.haml | 2 +- .../approved_merge_request_email.html.haml | 22 +- ...rge_when_pipeline_succeeds_email.html.haml | 22 +- .../notify/pipeline_failed_email.html.haml | 28 +- ...emote_mirror_update_failed_email.html.haml | 10 +- ..._factor_otp_attempt_failed_email.html.haml | 4 +- .../unapproved_merge_request_email.html.haml | 22 +- .../notify/unknown_sign_in_email.html.haml | 6 +- .../profiles/chat_names/_chat_name.html.haml | 2 +- app/views/profiles/chat_names/index.html.haml | 10 +- app/views/profiles/chat_names/new.html.haml | 4 +- config/routes/profile.rb | 12 +- config/routes/user_settings.rb | 5 + ...boarding_status_registration_objective.yml | 5 +- ...ll_onboarding_status_setup_for_company.yml | 5 +- .../fix_usernamespace_audit_events.yml | 5 +- ...roject_id_to_merge_request_diff_commits.rb | 9 + ...1826_add_deleted_at_to_ai_catalog_items.rb | 9 + ...dd_index_to_ai_catalog_items_deleted_at.rb | 16 + ...nboarding_status_registration_objective.rb | 21 + ...alize_hk_fix_usernamespace_audit_events.rb | 21 + ...ill_onboarding_status_setup_for_company.rb | 21 + db/schema_migrations/20250707185423 | 1 + db/schema_migrations/20250708081911 | 1 + db/schema_migrations/20250709154335 | 1 + db/schema_migrations/20250711211826 | 1 + db/schema_migrations/20250711212414 | 1 + db/schema_migrations/20250713232042 | 1 + db/structure.sql | 6 +- doc/api/events.md | 2 +- doc/api/graphql/reference/_index.md | 93 +++ doc/api/projects.md | 2 +- doc/ci/components/_index.md | 4 +- .../instance_runner_compute_minutes.md | 2 +- .../immutable_container_tags.md | 26 +- doc/user/project/project_topics.md | 2 +- doc/user/project/working_with_projects.md | 612 ++++++++---------- gems/gitlab-backup-cli/.gitlab-ci.yml | 10 +- .../lib/gitlab/schema/validation.rb | 2 + .../validation/schema_objects/sequence.rb | 4 +- .../schema/validation/validators/base.rb | 3 +- .../validators/different_sequence_owners.rb | 24 + .../spec/fixtures/structure.sql | 4 + .../schema/validation/validators/base_spec.rb | 3 +- .../different_sequence_owners_spec.rb | 11 + .../validators/missing_sequences_spec.rb | 1 - .../sequence_validators_shared_examples.rb | 66 +- lib/sidebars/user_settings/menus/chat_menu.rb | 6 +- locale/gitlab.pot | 54 +- ...cking_finished_on_deprecated_migrations.rb | 41 -- ...checking_finished_on_invalid_migrations.rb | 135 ++++ .../profiles/chat_names_controller_spec.rb | 86 +++ spec/db/schema_spec.rb | 2 +- spec/features/profiles/chat_names_spec.rb | 8 +- spec/features/projects/compare_spec.rb | 2 +- .../gke_registration_instructions_spec.js | 16 + ...le_cloud_registration_instructions_spec.js | 17 + .../registration_instructions_spec.js | 5 + ...izard_operating_system_instruction_spec.js | 69 ++ spec/graphql/types/project_type_spec.rb | 2 +- .../projects/repository_language_type_spec.rb | 15 + spec/lib/gitlab/import_export/all_models.yml | 1 + .../user_settings/menus/chat_menu_spec.rb | 6 +- .../slack/block_kit/app_home_opened_spec.rb | 2 +- ..._finished_on_deprecated_migrations_spec.rb | 31 - ...ing_finished_on_invalid_migrations_spec.rb | 80 +++ 93 files changed, 1534 insertions(+), 655 deletions(-) create mode 100644 app/assets/images/mailers/ci_pipeline_notif_v2/check.png create mode 100644 app/assets/images/mailers/ci_pipeline_notif_v2/icon-branch-gray.gif create mode 100644 app/assets/images/mailers/ci_pipeline_notif_v2/icon-commit-gray.gif create mode 100644 app/assets/images/mailers/ci_pipeline_notif_v2/x-red.png create mode 100644 app/assets/images/mailers/ci_pipeline_notif_v2/x.png create mode 100644 app/assets/javascripts/ci/runner/components/registration/wizard_operating_system_instruction.vue create mode 100644 db/migrate/20250707185423_add_project_id_to_merge_request_diff_commits.rb create mode 100644 db/migrate/20250711211826_add_deleted_at_to_ai_catalog_items.rb create mode 100644 db/migrate/20250711212414_add_index_to_ai_catalog_items_deleted_at.rb create mode 100644 db/post_migrate/20250708081911_finalize_hk_backfill_onboarding_status_registration_objective.rb create mode 100644 db/post_migrate/20250709154335_finalize_hk_fix_usernamespace_audit_events.rb create mode 100644 db/post_migrate/20250713232042_finalize_hk_backfill_onboarding_status_setup_for_company.rb create mode 100644 db/schema_migrations/20250707185423 create mode 100644 db/schema_migrations/20250708081911 create mode 100644 db/schema_migrations/20250709154335 create mode 100644 db/schema_migrations/20250711211826 create mode 100644 db/schema_migrations/20250711212414 create mode 100644 db/schema_migrations/20250713232042 create mode 100644 gems/gitlab-schema-validation/lib/gitlab/schema/validation/validators/different_sequence_owners.rb create mode 100644 gems/gitlab-schema-validation/spec/lib/gitlab/schema/validation/validators/different_sequence_owners_spec.rb delete mode 100644 rubocop/cop/search/avoid_checking_finished_on_deprecated_migrations.rb create mode 100644 rubocop/cop/search/avoid_checking_finished_on_invalid_migrations.rb create mode 100644 spec/controllers/profiles/chat_names_controller_spec.rb create mode 100644 spec/frontend/ci/runner/components/registration/wizard_operating_system_instruction_spec.js delete mode 100644 spec/rubocop/cop/search/avoid_checking_finished_on_deprecated_migrations_spec.rb create mode 100644 spec/rubocop/cop/search/avoid_checking_finished_on_invalid_migrations_spec.rb diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index b17533df2e2..0746fd79ca6 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -206,7 +206,7 @@ workflow: GLCI_PUSH_RAILS_TEST_FAILURE_ISSUES_TO_GCS: "false" variables: - PG_VERSION: "14" + PG_VERSION: "16" DEFAULT_CI_IMAGE: "${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images/ci/${BUILD_OS}-${OS_VERSION}-slim-ruby-${RUBY_VERSION}-golang-${GO_VERSION}-node-${NODE_VERSION}-postgresql-${PG_VERSION}:rubygems-${RUBYGEMS_VERSION}-git-${GIT_VERSION}-lfs-${LFS_VERSION}-chrome-${CHROME_VERSION}-yarn-${YARN_VERSION}-graphicsmagick-${GRAPHICSMAGICK_VERSION}" DEFAULT_JOB_TAG: "gitlab-org" GITLAB_LARGE_RUNNER_OPTIONAL: "gitlab-org" # overridden just in gitlab-org/gitlab diff --git a/.rubocop.yml b/.rubocop.yml index 49ec10bc506..a7b9ab74185 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1279,12 +1279,9 @@ RSpec/FactoryBot/LocalStaticAssignment: Rails/TransactionExitStatement: Enabled: true -Search/AvoidCheckingFinishedOnDeprecatedMigrations: +Search/AvoidCheckingFinishedOnInvalidMigrations: Include: - - 'ee/app/models/**/*.rb' - - 'ee/lib/elastic/**/*.rb' - - 'ee/lib/gitlab/elastic/**/*.rb' - - 'ee/spec/support/helpers/elasticsearch_helpers.rb' + - 'ee/**/*.rb' # See https://gitlab.com/gitlab-org/gitlab/-/issues/407233 Cop/ExperimentsTestCoverage: diff --git a/.rubocop_todo/internal_affairs/example_heredoc_delimiter.yml b/.rubocop_todo/internal_affairs/example_heredoc_delimiter.yml index 90e63779a21..92c087bb98b 100644 --- a/.rubocop_todo/internal_affairs/example_heredoc_delimiter.yml +++ b/.rubocop_todo/internal_affairs/example_heredoc_delimiter.yml @@ -32,7 +32,6 @@ InternalAffairs/ExampleHeredocDelimiter: - 'spec/rubocop/cop/scalability/cron_worker_context_spec.rb' - 'spec/rubocop/cop/scalability/file_uploads_spec.rb' - 'spec/rubocop/cop/scalability/idempotent_worker_spec.rb' - - 'spec/rubocop/cop/search/avoid_checking_finished_on_deprecated_migrations_spec.rb' - 'spec/rubocop/cop/search/namespaced_class_spec.rb' - 'spec/rubocop/cop/sidekiq_api_usage_spec.rb' - 'spec/rubocop/cop/sidekiq_load_balancing/worker_data_consistency_spec.rb' diff --git a/.rubocop_todo/internal_affairs/node_matcher_directive.yml b/.rubocop_todo/internal_affairs/node_matcher_directive.yml index c81442b06e5..d1bd8140c67 100644 --- a/.rubocop_todo/internal_affairs/node_matcher_directive.yml +++ b/.rubocop_todo/internal_affairs/node_matcher_directive.yml @@ -60,7 +60,6 @@ InternalAffairs/NodeMatcherDirective: - 'rubocop/cop/scalability/cron_worker_context.rb' - 'rubocop/cop/scalability/file_uploads.rb' - 'rubocop/cop/scalability/idempotent_worker.rb' - - 'rubocop/cop/search/avoid_checking_finished_on_deprecated_migrations.rb' - 'rubocop/cop/sidekiq_api_usage.rb' - 'rubocop/cop/sidekiq_load_balancing/worker_data_consistency.rb' - 'rubocop/cop/sidekiq_options_queue.rb' diff --git a/.rubocop_todo/internal_affairs/on_send_without_on_c_send.yml b/.rubocop_todo/internal_affairs/on_send_without_on_c_send.yml index 3dcd7b4b9a4..002fdec49e6 100644 --- a/.rubocop_todo/internal_affairs/on_send_without_on_c_send.yml +++ b/.rubocop_todo/internal_affairs/on_send_without_on_c_send.yml @@ -117,7 +117,6 @@ InternalAffairs/OnSendWithoutOnCSend: - 'rubocop/cop/scalability/bulk_perform_with_context.rb' - 'rubocop/cop/scalability/cron_worker_context.rb' - 'rubocop/cop/scalability/file_uploads.rb' - - 'rubocop/cop/search/avoid_checking_finished_on_deprecated_migrations.rb' - 'rubocop/cop/sidekiq_api_usage.rb' - 'rubocop/cop/sidekiq_options_queue.rb' - 'rubocop/cop/sidekiq_redis_call.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index d650c7fc40d..af335402ea2 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -838089751c1ffa6700b328f3060ce869217393fe +e30c5e007ce5c67d4dbbdfdf5e95634d0cc09344 diff --git a/app/assets/images/mailers/ci_pipeline_notif_v2/check.png b/app/assets/images/mailers/ci_pipeline_notif_v2/check.png new file mode 100644 index 0000000000000000000000000000000000000000..452496e7ce0a8843b207b8a1203c9d404ca49ba3 GIT binary patch literal 312 zcmeAS@N?(olHy`uVBq!ia0vp^CLqkg1|*MGNWTVBoCO|{#S9E$svykh8Km+7D9BhG zKhJxkwNvOy+%Uix-JH}T53om_&+QGr4q=ViJa?K0f;pk$`R z=h!bshRXz}YA%|)!e`>t6`|X>E5Oca*!`P9Qe%7Ttc`U`K(6z2^>bP0l+XkK7(H_a literal 0 HcmV?d00001 diff --git a/app/assets/images/mailers/ci_pipeline_notif_v2/icon-branch-gray.gif b/app/assets/images/mailers/ci_pipeline_notif_v2/icon-branch-gray.gif new file mode 100644 index 0000000000000000000000000000000000000000..d484324c864b059e9d521d1cf09ac706a71ee6c9 GIT binary patch literal 437 zcmZ?wbhEHblwy!#_-f41(caV1-rLy$M15VI{S*49OzfXBp?~Vc2~(#}n>}OtoEbA_ z&7Ze;`O+23maSO6eC4vGtCj=Nvej$Xu3xuq!@9Mbwr<_Nb@PtxTX$^R1|)aw*|Tr& z-u-*`96WsZ=#eAGPMC&akmoHzsbmj8ps}Dio@k6tA~i`>+f2((H> zsB0~HohYj@%Pmy#f~-x))K3d0=;p0a3vK6di!@(#QQ?B29aFloR+zF=6?1M(ql;K} zWP6~oT7j`17qh6_WM=M|I2YD1{)Nn~ZgQ!t3BgOkE%eE=XM4A;4e_0E5HKpa1{> literal 0 HcmV?d00001 diff --git a/app/assets/images/mailers/ci_pipeline_notif_v2/icon-commit-gray.gif b/app/assets/images/mailers/ci_pipeline_notif_v2/icon-commit-gray.gif new file mode 100644 index 0000000000000000000000000000000000000000..5b8df9bbba6a01f6db577fdcb02fad3f04e30078 GIT binary patch literal 259 zcmZ?wbhEHblwy!#_#(~F(caV1-rLy$M15VIeG~epOrJJ;#`HP!=Ph0^f63OZ+qZ4o zarp4jBOq|>^y#x_K;Yc1TX!BleEjIqlW*U?eFuS`KYsl9|Nrm5fB*jf|IdH~6o0aS zc{(5xWG4e_!vnRxl+1Y3dvTA8@m~`+U^q64P(zHx%^c+tMh@Z4C;R%5s_z5{8fuLuE2;Rn(qRPZ;d$+ypT++sM z*Hfp?t^=SbilQjWY3RGQ>AR+dBZ09nW=g(XNh*Xg2{mXWKel(X?)(zWK{}s@PP5Uk|4gi?= zPiA6Ey7Wjw)@=uWaFHf9sbv`$!WfcJXUI?a?*o2uq^VjeCF5gTAVOXgrofF4yjlpH z|DU4BP-h3p5}F3UC&ev;WD89Lsh5(FL5hT?0hLQh$sol-0A*5=GDwvWk|QN8gH#J4 z6scV>VVPYFU?L?Ij?p$Q8H7y;Nl3+Dl|fjAkPIny8H8O3AxMeHAmm&wj|-;HqMOOF@~sSiD!k*KE*sZ37ub2DkF zit?d6(Ug=bEb!{HW+|zH5}dCDkdVsUB;l`TxTVNKlEoRP6giiZEY7fRxK|C4=CJSA z^6i}V-OW7+7iTFczZKj90pbjq*d{r939u}6#<{os?))Q-&Fqv|Jrk1}joDcD@j~gJ yxys?C_k**Ao9D?#8@24?`B)AVMNt$*IX-_y=HjZ(p)i#I0000`;5NORc zyOhPP(9!D($49{f?mi{{kJi7J>uhpy;ZST52x1GZ=81iopN? literal 0 HcmV?d00001 diff --git a/app/assets/javascripts/ci/runner/components/registration/gke_registration_instructions.vue b/app/assets/javascripts/ci/runner/components/registration/gke_registration_instructions.vue index 236650b2cf4..31aa19fba87 100644 --- a/app/assets/javascripts/ci/runner/components/registration/gke_registration_instructions.vue +++ b/app/assets/javascripts/ci/runner/components/registration/gke_registration_instructions.vue @@ -109,6 +109,11 @@ export default { required: false, default: null, }, + isWidget: { + type: Boolean, + required: false, + default: false, + }, }, data() { return { @@ -300,7 +305,7 @@ export default {