diff --git a/.gitlab/ci/database.gitlab-ci.yml b/.gitlab/ci/database.gitlab-ci.yml index f2c9093c967..64229671a2d 100644 --- a/.gitlab/ci/database.gitlab-ci.yml +++ b/.gitlab/ci/database.gitlab-ci.yml @@ -111,7 +111,7 @@ db:migrate:reset single-db: db:check-schema: extends: - .db-job-base - - .rails:rules:ee-mr-and-default-branch-only + - .rails:rules:db:check-schema script: - run_timed_command "bundle exec rake db:drop db:create db:migrate" diff --git a/.gitlab/ci/rails.gitlab-ci.yml b/.gitlab/ci/rails.gitlab-ci.yml index 94982b8acfe..752f380bbab 100644 --- a/.gitlab/ci/rails.gitlab-ci.yml +++ b/.gitlab/ci/rails.gitlab-ci.yml @@ -448,7 +448,7 @@ rspec:artifact-collector part-a: needs: - job: rspec system pg14 # 32 jobs optional: true - - job: rspec background_migration pg14 # 10 jobs + - job: rspec background_migration pg14 # 17 jobs optional: true rspec:artifact-collector part-b: diff --git a/.gitlab/ci/rails/shared.gitlab-ci.yml b/.gitlab/ci/rails/shared.gitlab-ci.yml index c8bf625f7f5..8553d6ccf60 100644 --- a/.gitlab/ci/rails/shared.gitlab-ci.yml +++ b/.gitlab/ci/rails/shared.gitlab-ci.yml @@ -330,6 +330,16 @@ include: # # parallel_job_count = ceil(current_job_count * (average_duration / target_duration)) # +# Here's an example in Ruby: +# +# current_job_count = 10 +# average_duration = 53 +# target_duration = 30 +# +# parallel_job_count = (current_job_count.to_f * (average_duration.to_f / target_duration.to_f)).ceil +# +# => To reach 30min target duration, we would need 18 parallel jobs instead of 10. +# # At the moment, we set the target to 30 minutes # # https://app.snowflake.com/ys68254/gitlab/w2woEkSvsfYa/chart @@ -337,8 +347,10 @@ include: parallel: 26 # https://app.snowflake.com/ys68254/gitlab/wpUmrAF0RJL/chart +# +# Please set back to around 10 once https://gitlab.com/gitlab-org/gitlab/-/issues/503221 is closed .rspec-background-migration-parallel: - parallel: 10 + parallel: 17 # https://app.snowflake.com/ys68254/gitlab/w4cxPH8ySQlP/chart .rspec-ee-migration-parallel: diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index e12cdc30697..a1af590690b 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -2334,13 +2334,15 @@ when: manual allow_failure: true -.rails:rules:ee-mr-and-default-branch-only: +.rails:rules:db:check-schema: rules: - <<: *if-not-ee when: never - <<: *if-merge-request-labels-pipeline-expedite when: never - <<: *if-merge-request-labels-run-all-rspec + # Remove the rule below once https://gitlab.com/gitlab-org/gitlab/-/issues/503221 is closed. + - !reference [".prevent-tier-1", rules] - <<: *if-merge-request changes: *code-backstage-patterns - <<: *if-default-branch-refs diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml index d8df41e728f..444f241949c 100644 --- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml +++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml @@ -410,7 +410,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/finders/packages/conan/package_finder_spec.rb' - 'spec/finders/packages/group_packages_finder_spec.rb' - 'spec/finders/packages/npm/package_finder_spec.rb' - - 'spec/finders/packages/nuget/package_finder_spec.rb' - 'spec/finders/packages/package_file_finder_spec.rb' - 'spec/finders/packages/tags_finder_spec.rb' - 'spec/finders/projects/members/effective_access_level_finder_spec.rb' diff --git a/GITLAB_PAGES_VERSION b/GITLAB_PAGES_VERSION index d87582f9008..14a4f309f85 100644 --- a/GITLAB_PAGES_VERSION +++ b/GITLAB_PAGES_VERSION @@ -1 +1 @@ -6546b58c9c2eb0a7696b5d6d876980dec961a9f9 +17af60d3c2af0b548781cda116c11b54640ff125 diff --git a/app/assets/javascripts/ml/model_registry/apps/index_ml_models.vue b/app/assets/javascripts/ml/model_registry/apps/index_ml_models.vue index ea185f942ad..9a0b413585e 100644 --- a/app/assets/javascripts/ml/model_registry/apps/index_ml_models.vue +++ b/app/assets/javascripts/ml/model_registry/apps/index_ml_models.vue @@ -1,5 +1,5 @@