mirror of
https://github.com/gitlabhq/gitlabhq.git
synced 2025-07-21 23:37:47 +00:00
69 lines
2.5 KiB
Ruby
69 lines
2.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
return if helper.stable_branch?
|
|
|
|
data_testids = /testid/
|
|
|
|
deprecated_qa_selectors = /(?=qa_selector|data-qa-selector)|(?!.*\bdata-qa-)(?=class=.*qa-.*|class: .*qa-.*)/
|
|
|
|
def filter_changed_lines(files, pattern)
|
|
lines = []
|
|
files.each do |file|
|
|
next if file.start_with?('spec/', 'ee/spec/', 'qa/')
|
|
|
|
testid_changed_lines = helper.changed_lines(file).select { |line| line =~ pattern }
|
|
next unless testid_changed_lines.any?
|
|
|
|
lines += ["file `#{file}`:", testid_changed_lines]
|
|
end
|
|
lines
|
|
end
|
|
|
|
changed_code_files = helper.changed_files(/\.(vue|haml|js|rb)$/)
|
|
|
|
return if changed_code_files.empty?
|
|
|
|
lines_with_testids = filter_changed_lines(changed_code_files, data_testids)
|
|
|
|
deprecated_qa_class = filter_changed_lines(changed_code_files, deprecated_qa_selectors)
|
|
|
|
return if (lines_with_testids + deprecated_qa_class).empty?
|
|
|
|
markdown(<<~MARKDOWN)
|
|
## Testid Selectors
|
|
|
|
MARKDOWN
|
|
|
|
if lines_with_testids.any?
|
|
markdown(<<~MARKDOWN)
|
|
The following changed lines in this MR contain testid selectors:
|
|
|
|
* #{lines_with_testids.join("\n* ")}
|
|
|
|
If the `e2e:package-and-test` job in the `qa` stage has run automatically, please ensure the tests are passing.
|
|
If the job has not run, please start the `trigger-omnibus-and-follow-up-e2e` job in the `qa` stage and ensure the tests in `follow-up-e2e:package-and-test-ee` pipeline are passing.
|
|
|
|
For the list of known failures please refer to [the latest pipeline triage issue](https://gitlab.com/gitlab-org/quality/pipeline-triage/-/issues).
|
|
|
|
If your changes are under a feature flag, please check our [Testing with feature flags](https://docs.gitlab.com/ee/development/testing_guide/end_to_end/feature_flags.html#automatic-test-execution-when-a-feature-flag-definition-changes) documentation for instructions.
|
|
|
|
MARKDOWN
|
|
|
|
warn "This merge request contains lines with testid selectors. Please ensure `e2e:package-and-test` job is run."
|
|
end
|
|
|
|
if deprecated_qa_class.any?
|
|
markdown(<<~MARKDOWN)
|
|
### Deprecated data-qa-selector
|
|
|
|
The following lines in this MR contain deprecated data-qa-selector selectors:
|
|
|
|
* #{deprecated_qa_class.join("\n* ")}
|
|
|
|
Please ensure all deprecated data-qa-selector attributes are replaced with data-testid attributes in accordance with our [Testing Guide](https://docs.gitlab.com/ee/development/testing_guide/end_to_end/page_objects.html#data-testid-vs-data-qa-selector).
|
|
|
|
MARKDOWN
|
|
|
|
warn "This merge request contains deprecated data-qa-selector attribute. Please use data-testid attribute instead."
|
|
end
|