Commit Graph

59 Commits

Author SHA1 Message Date
ec13a66180 sort safe_env_lst
bz 65371


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1876815 13f79535-47bb-0310-9956-ffa450edef68
2020-04-22 06:53:55 +00:00
8acbc07a95 * support/suexec.c (main): Report error string after failure from
setgid/initgroups or setuid.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1876745 13f79535-47bb-0310-9956-ffa450edef68
2020-04-20 09:31:25 +00:00
156dbb6aaf * support/suexec.c (safe_strtol): New function.
(main): Use ^ to be avoid using atoi(); try to catch more string to
  integer and integer to uid/gid conversion errors/surprises.

PR: 33207


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1876744 13f79535-47bb-0310-9956-ffa450edef68
2020-04-20 09:25:39 +00:00
29849173ea * support/suexec.c (clean_env): Revert use of ap_calloc in
r1874156 which broke the build.
https://travis-ci.org/apache/httpd/builds/651858409


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1874158 13f79535-47bb-0310-9956-ffa450edef68
2020-02-18 08:27:43 +00:00
f71e6fc9a3 convert malloc(3) into ap_malloc
bz 64049


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1874156 13f79535-47bb-0310-9956-ffa450edef68
2020-02-18 07:37:45 +00:00
85760859ca Fix spelling errors found by codespell. [skip ci]
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1873985 13f79535-47bb-0310-9956-ffa450edef68
2020-02-13 18:15:57 +00:00
8122b2a79d * support/suexec.c (clean_env): Avoid use of sprintf; no functional change.
PR: 33207


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1846253 13f79535-47bb-0310-9956-ffa450edef68
2018-11-09 16:02:21 +00:00
5b20d24ba0 Follow-up to r1734817: suexec passes through mod_include's DOCUMENT_ARGS
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1734955 13f79535-47bb-0310-9956-ffa450edef68
2016-03-14 16:31:36 +00:00
c95e60170d tab vs space
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1674214 13f79535-47bb-0310-9956-ffa450edef68
2015-04-17 05:48:28 +00:00
4893ecda29 suexec: Filter out HTTP_PROXY
Some programs look there for the http proxy server.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1659711 13f79535-47bb-0310-9956-ffa450edef68
2015-02-13 23:24:10 +00:00
6a1c04e803 Exit with error message if out of mem
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1425772 13f79535-47bb-0310-9956-ffa450edef68
2012-12-25 20:54:47 +00:00
63b24c3089 * support/suexec.c: Define AP_LOG_FACILITY.
(err_output): Use AP_LOG_FACILITY for syslog facility.

Suggested by: kbrand


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1344712 13f79535-47bb-0310-9956-ffa450edef68
2012-05-31 13:22:02 +00:00
cc9eab4c92 suexec: Add support for logging to syslog as an alternative to a
logfile.

* support/suexec.c (err_output) [AP_LOG_SYSLOG]: Log to syslog.
  (main): Close syslog fd if open, before execv.  Add -V output
  for AP_LOG_SYSLOG.

* configure.in: Add --with-suexec-syslog argument; allow
  --without-suexec-logfile to omit definition of AP_LOG_EXEC.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1341905 13f79535-47bb-0310-9956-ffa450edef68
2012-05-23 15:42:33 +00:00
3182653a2b * support/suexec.c: Add gcc format-string attributes to logging
functions.  
  (main): Always print uid/gid as unsigned long, and cast to avoid
  warnings (which somewhat defeats the point of the format string
  attrs, but is necessary since the size of gid/uid varies).


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1337344 13f79535-47bb-0310-9956-ffa450edef68
2012-05-11 19:32:38 +00:00
1039437f77 Add some environment variables to the whitelist in suexec
PR: 51499
Submitted by: Graham Laverty <graham reg ca>, Stefan Fritsch


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1146244 13f79535-47bb-0310-9956-ffa450edef68
2011-07-13 19:11:21 +00:00
2014acf62f Improvements found by cppcheck:
remove some unused variables and dead assignments, reduce the scope of some
variables, add some parens to improve readability


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1103459 13f79535-47bb-0310-9956-ffa450edef68
2011-05-15 16:58:45 +00:00
381673cdbf Support large log files in suexec
PR: 45856


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@987861 13f79535-47bb-0310-9956-ffa450edef68
2010-08-22 10:34:20 +00:00
3e9367c8d2 Only use fcntl() if we have fcntl.h
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@821475 13f79535-47bb-0310-9956-ffa450edef68
2009-10-04 07:57:32 +00:00
9adcc73504 suexec: Allow to log an error if exec fails by setting FD_CLOEXEC
on the log file instead of closing it.

PR: 10744
Submitted by: Nicolas Rachinsky
Reviewed by: Stefan Fritsch


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@821321 13f79535-47bb-0310-9956-ffa450edef68
2009-10-03 13:46:48 +00:00
301f0404f5 axe unmaintained 1.3-era code to support AUX, SunOS, IRIX, Next, Tandem, MPE,
LynxOS, QNX, and UnixWare


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@758944 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 00:32:22 +00:00
a42c37fd05 When group is given as a numeric gid, validate it by looking up the
actual group name such that the name can be used in log entries.

PR: 7862
Submitted by: <y-koga apache.or.jp>, Leif W <warp-9.9 usa.net>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@655711 13f79535-47bb-0310-9956-ffa450edef68
2008-05-13 02:21:33 +00:00
de659cbed0 update license header text
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@420983 13f79535-47bb-0310-9956-ffa450edef68
2006-07-11 20:33:53 +00:00
dd95d7c37c Update the copyright year in all .c, .h and .xml files
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@395228 13f79535-47bb-0310-9956-ffa450edef68
2006-04-19 12:11:27 +00:00
5061d9fa92 No functional Change: Removing trailing whitespace. This also
means that "blank" lines consisting of just spaces or
tabs are now really blank lines


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@332306 13f79535-47bb-0310-9956-ffa450edef68
2005-11-10 15:11:44 +00:00
905cdf9f0b Update copyright year to 2005 and standardize on current copyright owner line.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@151408 13f79535-47bb-0310-9956-ffa450edef68
2005-02-04 20:28:49 +00:00
8587927a4f * support/suexec.c (safe_env_lst): Declare array as static const.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@125784 13f79535-47bb-0310-9956-ffa450edef68
2005-01-20 15:38:05 +00:00
8eb3fb0802 suexec: Pass the SERVER_SIGNATURE envvar through to CGIs.
Submitted by: Zvi Har'El <rl math.technion.ac.il>
Reviewed by:  Jeff Trawick


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@104703 13f79535-47bb-0310-9956-ffa450edef68
2004-08-18 11:54:49 +00:00
4ce939e3e6 filepath_info wasn't set by the httpd for over 7 years
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@104664 13f79535-47bb-0310-9956-ffa450edef68
2004-08-15 17:19:04 +00:00
eeb57c17ad fix name of The Apache Software Foundation
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@102619 13f79535-47bb-0310-9956-ffa450edef68
2004-02-09 20:40:53 +00:00
c0dcb76491 fix copyright dates according the first cehck in
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@102592 13f79535-47bb-0310-9956-ffa450edef68
2004-02-08 14:14:53 +00:00
4f02cb1e18 apply Apache License, Version 2.0
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@102525 13f79535-47bb-0310-9956-ffa450edef68
2004-02-06 22:58:42 +00:00
fb07607180 update license to 2004.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@102135 13f79535-47bb-0310-9956-ffa450edef68
2004-01-01 13:26:26 +00:00
cf9772a8fc Remember an authenticated user during internal redirects if the
redirection target is not access protected and pass it
to scripts using the REDIRECT_REMOTE_USER environment variable.

PR: 10678, 11602.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@100604 13f79535-47bb-0310-9956-ffa450edef68
2003-07-14 17:24:38 +00:00
e1eff53b89 Propagate the handler name to the action script via
the REDIRECT_HANDLER environment variable.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@100598 13f79535-47bb-0310-9956-ffa450edef68
2003-07-14 16:04:47 +00:00
fc26ebab0c Be more pedantic when cleaning environment. Clean it
immediately after startup.

PR: 2790, 10449
Submitted by: Jeff Stewart <jws@purdue.edu>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@98738 13f79535-47bb-0310-9956-ffa450edef68
2003-02-19 21:27:05 +00:00
22d98172e8 Fix suexec compile error under SUNOS4, where strerror() doesn't exist.
PR: 5913, 9977
Submitted by: Jonathan W Miner <Jonathan.W.Miner@lmco.com>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@98618 13f79535-47bb-0310-9956-ffa450edef68
2003-02-12 15:28:28 +00:00
e833dc0afc Let suexec send a message to stderr, if it failed or its policy
was violated. This message appears in the error log and allows
for easier debugging.

PR: 10773
Proposed again by: Joshua Slive


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@98603 13f79535-47bb-0310-9956-ffa450edef68
2003-02-10 03:37:22 +00:00
742af25096 finished that boring job:
update license to 2003.

Happy New Year! ;-))


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@98573 13f79535-47bb-0310-9956-ffa450edef68
2003-02-03 17:53:28 +00:00
45e54694c8 Re-order header files in suexec.c. This adds apr.h, which is required
to get the apr macros.  Other than that, it is just for clarity.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@96995 13f79535-47bb-0310-9956-ffa450edef68
2002-09-28 00:26:27 +00:00
1532c1f996 fix a typo
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@94912 13f79535-47bb-0310-9956-ffa450edef68
2002-05-02 20:16:34 +00:00
845cbfd508 Update our copyright for this year.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93918 13f79535-47bb-0310-9956-ffa450edef68
2002-03-13 20:48:07 +00:00
5b313cc655 suexec: Allow HTTPS and SSL_* environment variables to be passed
through to CGI scripts.

PR: 9163
Submitted by:	Brian Reid <breid@customlogic.com>, Zvi Har'El <rl@math.technion.ac.il>
Reviewed by:	Joshua Slive, Lars Eilebrecht, Martin Kraemer


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93223 13f79535-47bb-0310-9956-ffa450edef68
2002-02-04 15:18:45 +00:00
eb82200c90 Just some style changes from when I was working on the recent suexec
patch. No more tabs, intended alignment remains.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92132 13f79535-47bb-0310-9956-ffa450edef68
2001-11-22 07:42:13 +00:00
d5fe728b25 Fix typos...
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91694 13f79535-47bb-0310-9956-ffa450edef68
2001-10-30 17:38:03 +00:00
e811bc50a1 Use uniform wrapping for unistd.h, and don't include it if it's aready included via fileio.h
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90491 13f79535-47bb-0310-9956-ffa450edef68
2001-08-22 15:40:29 +00:00
ef5bf37c4d Bring forward the suexec umask setting option from 1.3, and
also fix some configure.in bits that would define macros
	that needed to be numbers as strings instead.

Obtained from:	Apache HTTP Server 1.3


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@88493 13f79535-47bb-0310-9956-ffa450edef68
2001-03-11 23:22:32 +00:00
c9a450c264 Bring forward the -V option for suexec from 1.3.20-dev. It looks
like the umask() option needs to be brought forward, as well.
	Is this still 2.0.14-dev?


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@88483 13f79535-47bb-0310-9956-ffa450edef68
2001-03-09 20:20:31 +00:00
8bcd220ae9 Don't directly include ap_config_auto.h directly. It isn't available on
Windows platforms. Including ap_config.h will pick it up, or it will grab
the appropriate Windows header/defines.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@88402 13f79535-47bb-0310-9956-ffa450edef68
2001-03-01 00:55:03 +00:00
381f88d56a Update copyright to 2001
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@88184 13f79535-47bb-0310-9956-ffa450edef68
2001-02-16 04:26:53 +00:00
486c778c4e Header file cleanup.
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@88065 13f79535-47bb-0310-9956-ffa450edef68
2001-02-10 17:39:22 +00:00