VladPolskiy/apache-http-server
1
0
Fork 0
mirror of https://github.com/apache/httpd.git synced 2025-08-20 16:09:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Back out ap_set_default_perms(). Remove old logic to play with umask

Browse Source 
around the creation of the httpd.pid file.  Pass explicit permissions to
ap_open(), omitting write-ability except by the owning user.  As always,
we end up with rw-r--r-- for the permissions unless the umask is something
unusual.

Note that the OS/2 and Win32 implementations of ap_open() ignore the
permissions parameter altogether.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@85550 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Jeff Trawick
2000-06-12 21:08:25 +00:00
parent 374f895ac3
commit 93a6d2f3a7
1 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
server/log.c
View File

@ -490,9 +490,6 @@ void ap_log_pid(ap_pool_t *p, const char *fname)
ap_finfo_t finfo;
static pid_t saved_pid = -1;
pid_t mypid;
#ifndef WIN32
mode_t u;
#endif
if (!fname)
return;
@ -514,21 +511,14 @@ void ap_log_pid(ap_pool_t *p, const char *fname)
);
}
#ifndef WIN32
u = ap_set_default_fperms(022);
(void) ap_set_default_fperms(u | 022);
#endif
if (ap_open(&pid_file, fname, APR_WRITE | APR_CREATE | APR_TRUNCATE,
APR_OS_DEFAULT, p) != APR_SUCCESS) {
APR_UREAD | APR_UWRITE | APR_GREAD | APR_WREAD, p) != APR_SUCCESS) {
perror("fopen");
ap_log_error(APLOG_MARK, APLOG_STARTUP | APLOG_NOERRNO, 0, NULL,
"%s: could not log pid to file %s",
ap_server_argv0, fname);
exit(1);
}
#ifndef WIN32
(void) ap_set_default_fperms(u);
#endif
ap_fprintf(pid_file, "%ld\n", (long)mypid);
ap_close(pid_file);
saved_pid = mypid;