Files
online/test/UnitPasswordProtected.cpp
Miklos Vajna b8bd1990aa Rework LOOLProtocol::tokenize() to return a StringVector object
The bulk of this commit just changes std::vector<std::string> to
StringVector when we deal with tokens from a websocket message.

The less boring part of it is the new StringVector class, which is a
wrapper around std::vector<std::string>, and provides the same API,
except that operator[] returns a string, not a string&, and this allows
returning an empty string in case that prevents reading past the end of
the underlying array.

This means in case client code forgets to check size() before invoking
operator[], we don't crash. (See the ~3 previous commits which fixed
such crashes.)

Later the ctor could be changed to take a single underlying string to
avoid lots of tiny allocations, that's not yet done in this commit.

Change-Id: I8a6082143a8ac0b65824f574b32104d7889c184f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89687
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-28 16:07:56 +01:00

229 lines
8.2 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <memory>
#include <string>
#include <Poco/URI.h>
#include <cppunit/TestAssert.h>
#include <Unit.hpp>
#include <Util.hpp>
#include <helpers.hpp>
class LOOLWebSocket;
/// Password protected testcase.
class UnitPasswordProtected : public UnitWSD
{
TestResult testPasswordProtectedDocumentWithoutPassword();
TestResult testPasswordProtectedDocumentWithWrongPassword();
TestResult testPasswordProtectedDocumentWithCorrectPassword();
TestResult testPasswordProtectedDocumentWithCorrectPasswordAgain();
TestResult testPasswordProtectedOOXMLDocument();
TestResult testPasswordProtectedBinaryMSOfficeDocument();
public:
void invokeTest() override;
};
UnitBase::TestResult UnitPasswordProtected::testPasswordProtectedDocumentWithoutPassword()
{
const char* testname = "testPasswordProtectedDocumentWithoutPassword";
try
{
std::string documentPath, documentURL;
helpers::getDocumentPathAndURL("password-protected.ods", documentPath, documentURL,
testname);
Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, documentURL);
Poco::Net::HTTPResponse httpResponse;
std::shared_ptr<LOOLWebSocket> socket = helpers::connectLOKit(
Poco::URI(helpers::getTestServerURI()), request, httpResponse, testname);
// Send a load request without password first
helpers::sendTextFrame(socket, "load url=" + documentURL);
const auto response = helpers::getResponseString(socket, "error:", testname);
StringVector tokens(LOOLProtocol::tokenize(response, ' '));
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(3), tokens.size());
std::string errorCommand;
std::string errorKind;
LOOLProtocol::getTokenString(tokens[1], "cmd", errorCommand);
LOOLProtocol::getTokenString(tokens[2], "kind", errorKind);
CPPUNIT_ASSERT_EQUAL(std::string("load"), errorCommand);
CPPUNIT_ASSERT_EQUAL(std::string("passwordrequired:to-view"), errorKind);
}
catch (const Poco::Exception& exc)
{
CPPUNIT_FAIL(exc.displayText());
}
return TestResult::Ok;
}
UnitBase::TestResult UnitPasswordProtected::testPasswordProtectedDocumentWithWrongPassword()
{
const char* testname = "testPasswordProtectedDocumentWithWrongPassword";
try
{
std::string documentPath, documentURL;
helpers::getDocumentPathAndURL("password-protected.ods", documentPath, documentURL,
testname);
Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, documentURL);
Poco::Net::HTTPResponse httpResponse;
std::shared_ptr<LOOLWebSocket> socket = helpers::connectLOKit(
Poco::URI(helpers::getTestServerURI()), request, httpResponse, testname);
// Send a load request with incorrect password
helpers::sendTextFrame(socket, "load url=" + documentURL + " password=2");
const auto response = helpers::getResponseString(socket, "error:", testname);
StringVector tokens(LOOLProtocol::tokenize(response, ' '));
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(3), tokens.size());
std::string errorCommand;
std::string errorKind;
LOOLProtocol::getTokenString(tokens[1], "cmd", errorCommand);
LOOLProtocol::getTokenString(tokens[2], "kind", errorKind);
CPPUNIT_ASSERT_EQUAL(std::string("load"), errorCommand);
CPPUNIT_ASSERT_EQUAL(std::string("wrongpassword"), errorKind);
}
catch (const Poco::Exception& exc)
{
CPPUNIT_FAIL(exc.displayText());
}
return TestResult::Ok;
}
UnitBase::TestResult UnitPasswordProtected::testPasswordProtectedDocumentWithCorrectPassword()
{
const char* testname = "testPasswordProtectedDocumentWithCorrectPassword";
try
{
std::string documentPath, documentURL;
helpers::getDocumentPathAndURL("password-protected.ods", documentPath, documentURL,
testname);
Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, documentURL);
Poco::Net::HTTPResponse response;
std::shared_ptr<LOOLWebSocket> socket = helpers::connectLOKit(
Poco::URI(helpers::getTestServerURI()), request, response, testname);
// Send a load request with correct password
helpers::sendTextFrame(socket, "load url=" + documentURL + " password=1");
CPPUNIT_ASSERT_MESSAGE("cannot load the document with correct password " + documentURL,
helpers::isDocumentLoaded(socket, testname));
}
catch (const Poco::Exception& exc)
{
CPPUNIT_FAIL(exc.displayText());
}
return TestResult::Ok;
}
UnitBase::TestResult UnitPasswordProtected::testPasswordProtectedDocumentWithCorrectPasswordAgain()
{
return testPasswordProtectedDocumentWithCorrectPassword();
}
UnitBase::TestResult UnitPasswordProtected::testPasswordProtectedOOXMLDocument()
{
const char* testname = "testPasswordProtectedOOXMLDocument";
try
{
std::string documentPath, documentURL;
helpers::getDocumentPathAndURL("password-protected.docx", documentPath, documentURL,
testname);
Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, documentURL);
Poco::Net::HTTPResponse response;
std::shared_ptr<LOOLWebSocket> socket = helpers::connectLOKit(
Poco::URI(helpers::getTestServerURI()), request, response, testname);
// Send a load request with correct password
helpers::sendTextFrame(socket, "load url=" + documentURL + " password=abc");
CPPUNIT_ASSERT_MESSAGE("cannot load the document with correct password " + documentURL,
helpers::isDocumentLoaded(socket, testname));
}
catch (const Poco::Exception& exc)
{
CPPUNIT_FAIL(exc.displayText());
}
return TestResult::Ok;
}
UnitBase::TestResult UnitPasswordProtected::testPasswordProtectedBinaryMSOfficeDocument()
{
const char* testname = "testPasswordProtectedBinaryMSOfficeDocument";
try
{
std::string documentPath, documentURL;
helpers::getDocumentPathAndURL("password-protected.doc", documentPath, documentURL,
testname);
Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, documentURL);
Poco::Net::HTTPResponse response;
std::shared_ptr<LOOLWebSocket> socket = helpers::connectLOKit(
Poco::URI(helpers::getTestServerURI()), request, response, testname);
// Send a load request with correct password
helpers::sendTextFrame(socket, "load url=" + documentURL + " password=abc");
CPPUNIT_ASSERT_MESSAGE("cannot load the document with correct password " + documentURL,
helpers::isDocumentLoaded(socket, testname));
}
catch (const Poco::Exception& exc)
{
CPPUNIT_FAIL(exc.displayText());
}
return TestResult::Ok;
}
void UnitPasswordProtected::invokeTest()
{
UnitBase::TestResult result = testPasswordProtectedDocumentWithoutPassword();
if (result != TestResult::Ok)
exitTest(result);
result = testPasswordProtectedDocumentWithWrongPassword();
if (result != TestResult::Ok)
exitTest(result);
result = testPasswordProtectedDocumentWithCorrectPassword();
if (result != TestResult::Ok)
exitTest(result);
result = testPasswordProtectedDocumentWithCorrectPasswordAgain();
if (result != TestResult::Ok)
exitTest(result);
result = testPasswordProtectedOOXMLDocument();
if (result != TestResult::Ok)
exitTest(result);
result = testPasswordProtectedBinaryMSOfficeDocument();
if (result != TestResult::Ok)
exitTest(result);
exitTest(TestResult::Ok);
}
UnitBase* unit_create_wsd(void) { return new UnitPasswordProtected(); }
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */