LibreOffice/online
1
0
Fork 0
mirror of https://github.com/LibreOffice/online.git synced 2025-08-06 10:45:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bin code that has always been inside #if 0

Browse Source 
Also, the comment in it was misleading. We don't have just a single
buffer for a FakeSocket any longer.

Change-Id: I8f45fba2342ef42040e467b631739a56664ce6e8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90440
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
This commit is contained in:
Tor Lillqvist
2020-03-12 20:58:03 +02:00
parent 60f2e0d709
commit 188d00ce4a
1 changed files with 0 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
net/Socket.hpp
View File

@ -697,21 +697,6 @@ public:
#if !MOBILEAPP #if !MOBILEAPP
rc = ::write(fd, "w", 1); rc = ::write(fd, "w", 1);
#else #else
#if 0
// Our fake sockets are record-oriented with a single record buffer, so as we write one
// byte at a time to the wakeup pipe, we can't write another one before the previous one
// has been read.
//
// FIXME: Still, explicitly waiting here with fakeSocketPoll() for it to be writable
// doesn't seem to be any improvement. On the contrary, with this fakeSocketPoll(), we
// hang every time we run the app. Without it, we only hang occasionally.
LOG_TRC("Wakeup pipe write");
struct pollfd p;
p.fd = fd;
p.events = POLLOUT;
fakeSocketPoll(&p, 1, -1);
#endif
rc = fakeSocketWrite(fd, "w", 1); rc = fakeSocketWrite(fd, "w", 1);
#endif #endif
} while (rc == -1 && errno == EINTR); } while (rc == -1 && errno == EINTR);