mirror of
https://github.com/LibreOffice/core.git
synced 2025-07-26 15:45:26 +00:00

...which was introduced in <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=117782e0c2a81a4b8170f87f0fe7190ee22548e2> "c++: add -Wsfinae-incomplete" and causes warnings like > In file included from include/vcl/event.hxx:28, > from libreofficekit/source/gtk/lokdocview.cxx:26: > include/vcl/outdev.hxx:160:37: error: defining ‘OutputDevice’, which previously failed to be complete in a SFINAE context [-Werror=sfinae-incomplete=] > 160 | class SAL_WARN_UNUSED VCL_DLLPUBLIC OutputDevice : public virtual VclReferenceBase > | ^~~~~~~~~~~~ > In file included from include/vcl/vclevent.hxx:24, > from include/svtools/colorcfg.hxx:29, > from include/vcl/themecolors.hxx:12, > from include/vcl/settings.hxx:26, > from include/vcl/event.hxx:26: > include/vcl/vclptr.hxx:44:13: note: here. Use ‘-Wsfinae-incomplete=2’ for a diagnostic at that point > 44 | int (*)[sizeof(T)]) > | ^~~~~~~~~ because > include/vcl/vclptr.hxx:44:13: error: failed to complete ‘OutputDevice’ in SFINAE context [-Werror=sfinae-incomplete=] > 44 | int (*)[sizeof(T)]) > | ^~~~~~~~~ > include/vcl/vclptr.hxx: In substitution of ‘template<class T> constexpr bool vcl::detail::isIncompleteOrDerivedFromVclReferenceBase(int (*)[sizeof (T)]) [with T = VirtualDevice]’: > include/vcl/vclptr.hxx:60:79: required from ‘class VclPtr<VirtualDevice>’ > 60 | vcl::detail::isIncompleteOrDerivedFromVclReferenceBase<reference_type>( > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ > 61 | nullptr), > | ~~~~~~~~ > include/vcl/outdev.hxx:188:37: required from here > 188 | VclPtr<VirtualDevice> mpAlphaVDev; > | ^~~~~~~~~~~ As discussed in the newly added comment in include/vcl/vclptr.hxx, until we can address this with C++26 reflection, "use a HACK of (globally) ignoring that warning". (Which required adding a new HAVE_GCC_WSFINAE_INCOMPLETE configure check.) Change-Id: Ie1b44e730cf6b6269572158f6bd50e8911c15846 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188115 Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com> Tested-by: Jenkins
393 lines
12 KiB
C++
393 lines
12 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
||
/*
|
||
* This file is part of the LibreOffice project.
|
||
*
|
||
* This Source Code Form is subject to the terms of the Mozilla Public
|
||
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
||
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
||
*
|
||
* This file incorporates work covered by the following license notice:
|
||
*
|
||
* Licensed to the Apache Software Foundation (ASF) under one or more
|
||
* contributor license agreements. See the NOTICE file distributed
|
||
* with this work for additional information regarding copyright
|
||
* ownership. The ASF licenses this file to you under the Apache
|
||
* License, Version 2.0 (the "License"); you may not use this file
|
||
* except in compliance with the License. You may obtain a copy of
|
||
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
|
||
*/
|
||
|
||
#ifndef INCLUDED_VCL_PTR_HXX
|
||
#define INCLUDED_VCL_PTR_HXX
|
||
|
||
#include <sal/config.h>
|
||
|
||
#include <config_global.h>
|
||
#include <rtl/ref.hxx>
|
||
|
||
#include <utility>
|
||
#include <type_traits>
|
||
|
||
#ifdef DBG_UTIL
|
||
#ifndef _WIN32
|
||
#include <vcl/vclmain.hxx>
|
||
#endif
|
||
#endif
|
||
|
||
class VclReferenceBase;
|
||
|
||
namespace vcl::detail {
|
||
|
||
template<typename>
|
||
constexpr bool isIncompleteOrDerivedFromVclReferenceBase(...) { return true; }
|
||
|
||
template<typename T> constexpr bool isIncompleteOrDerivedFromVclReferenceBase(
|
||
int (*)[sizeof(T)])
|
||
{ return std::is_base_of<VclReferenceBase, T>::value; }
|
||
|
||
// The above isIncompleteOrDerivedFromVclReferenceBase will cause will cause -Wsfinae-incomplete
|
||
// warnings when e.g. OutputDevice (include/vcl/outdev.hxx) contains members of type
|
||
// VclPtr<OutputDevice>, so OutputDevice is not yet complete when
|
||
// sIncompleteOrDerivedFromVclReferenceBase is instantiated, but will become complete later on
|
||
// ("warning: error: defining ‘OutputDevice’, which previously failed to be complete in a SFINAE
|
||
// context [-Werror=sfinae-incomplete=]"). A real solution would presumably be using C++26
|
||
// reflection and rewriting the above isIncompleteOrDerivedFromVclReferenceBase as something like
|
||
//
|
||
// consteval bool isIncompleteOrDerivedFromVclReferenceBase(std::meta::info type) {
|
||
// return !std::meta::is_complete_type(type)
|
||
// || std::meta::is_base_of_type(^^VclReferenceBase, type);
|
||
// }
|
||
//
|
||
// But until then, use a HACK of (globally) ignoring that warning:
|
||
#if defined __GNUC__ && !defined __clang__ && HAVE_GCC_WSFINAE_INCOMPLETE
|
||
#pragma GCC diagnostic ignored "-Wsfinae-incomplete"
|
||
#endif
|
||
|
||
} // namespace vcl::detail
|
||
|
||
/**
|
||
* A thin wrapper around rtl::Reference to implement the acquire and dispose semantics we want for references to vcl::Window subclasses.
|
||
*
|
||
* For more details on the design please see vcl/README.lifecycle
|
||
*
|
||
* @param reference_type must be a subclass of vcl::Window
|
||
*/
|
||
template <class reference_type>
|
||
class VclPtr
|
||
{
|
||
static_assert(
|
||
vcl::detail::isIncompleteOrDerivedFromVclReferenceBase<reference_type>(
|
||
nullptr),
|
||
"template argument type must be derived from VclReferenceBase");
|
||
|
||
::rtl::Reference<reference_type> m_rInnerRef;
|
||
|
||
public:
|
||
/** Constructor...
|
||
*/
|
||
VclPtr() = default;
|
||
|
||
/** Constructor...
|
||
*/
|
||
VclPtr (reference_type * pBody)
|
||
: m_rInnerRef(pBody)
|
||
{}
|
||
|
||
/** Constructor... that doesn't take a ref.
|
||
*/
|
||
VclPtr (reference_type * pBody, __sal_NoAcquire)
|
||
: m_rInnerRef(pBody, SAL_NO_ACQUIRE)
|
||
{}
|
||
|
||
/** Up-casting conversion constructor: Copies interface reference.
|
||
|
||
Does not work for up-casts to ambiguous bases. For the special case of
|
||
up-casting to Reference< XInterface >, see the corresponding conversion
|
||
operator.
|
||
|
||
@param rRef another reference
|
||
*/
|
||
template< class derived_type >
|
||
requires std::is_base_of_v<reference_type, derived_type>
|
||
VclPtr(const VclPtr<derived_type>& rRef)
|
||
: m_rInnerRef( static_cast<reference_type*>(rRef) )
|
||
{
|
||
}
|
||
|
||
#if defined(DBG_UTIL) && !defined(_WIN32)
|
||
~VclPtr()
|
||
{
|
||
assert(m_rInnerRef.get() == nullptr || vclmain::isAlive());
|
||
// We can be one of the intermediate counts, but if we are the last
|
||
// VclPtr keeping this object alive, then something forgot to call dispose().
|
||
assert((!m_rInnerRef.get() || m_rInnerRef->isDisposed() || m_rInnerRef->getRefCount() > 1)
|
||
&& "someone forgot to call dispose()");
|
||
}
|
||
VclPtr(VclPtr const &) = default;
|
||
VclPtr(VclPtr &&) = default;
|
||
VclPtr & operator =(VclPtr const &) = default;
|
||
VclPtr & operator =(VclPtr &&) = default;
|
||
#endif
|
||
|
||
/**
|
||
* A construction helper for VclPtr. Since VclPtr types are created
|
||
* with a reference-count of one - to help fit into the existing
|
||
* code-flow; this helps us to construct them easily.
|
||
*
|
||
* For more details on the design please see vcl/README.lifecycle
|
||
*
|
||
* @tparam reference_type must be a subclass of vcl::Window
|
||
*/
|
||
template<typename... Arg> [[nodiscard]] static VclPtr Create(Arg &&... arg)
|
||
{
|
||
return VclPtr( new reference_type(std::forward<Arg>(arg)...), SAL_NO_ACQUIRE );
|
||
}
|
||
|
||
/** Probably most common used: handle->someBodyOp().
|
||
*/
|
||
reference_type * operator->() const
|
||
{
|
||
return m_rInnerRef.get();
|
||
}
|
||
|
||
/** Get the body. Can be used instead of operator->().
|
||
I.e. handle->someBodyOp() and handle.get()->someBodyOp()
|
||
are the same.
|
||
*/
|
||
reference_type * get() const
|
||
{
|
||
return m_rInnerRef.get();
|
||
}
|
||
|
||
void reset(reference_type *pBody)
|
||
{
|
||
m_rInnerRef.set(pBody);
|
||
}
|
||
|
||
/** Up-casting copy assignment operator.
|
||
|
||
Does not work for up-casts to ambiguous bases.
|
||
|
||
@param rRef another reference
|
||
*/
|
||
template<typename derived_type>
|
||
requires std::is_base_of_v<reference_type, derived_type>
|
||
VclPtr & operator =(VclPtr<derived_type> const& rRef)
|
||
{
|
||
return operator=(rRef.get());
|
||
}
|
||
|
||
VclPtr & operator =(reference_type * pBody)
|
||
{
|
||
m_rInnerRef.set(pBody);
|
||
return *this;
|
||
}
|
||
|
||
operator reference_type * () const
|
||
{
|
||
return m_rInnerRef.get();
|
||
}
|
||
|
||
explicit operator bool () const
|
||
{
|
||
return m_rInnerRef.get() != nullptr;
|
||
}
|
||
|
||
void reset()
|
||
{
|
||
m_rInnerRef.clear();
|
||
}
|
||
|
||
void disposeAndClear()
|
||
{
|
||
// hold it alive for the lifetime of this method
|
||
::rtl::Reference<reference_type> aTmp(std::move(m_rInnerRef));
|
||
// coverity[use_after_move : SUPPRESS] - the move ctor above must take care of it
|
||
assert(!m_rInnerRef);
|
||
if (aTmp.get()) {
|
||
aTmp->disposeOnce();
|
||
}
|
||
}
|
||
|
||
/** Needed to place VclPtr's into STL collection.
|
||
*/
|
||
bool operator< (const VclPtr & handle) const
|
||
{
|
||
return (m_rInnerRef < handle.m_rInnerRef);
|
||
}
|
||
}; // class VclPtr
|
||
|
||
template<typename T1, typename T2>
|
||
inline bool operator ==(VclPtr<T1> const & p1, VclPtr<T2> const & p2) {
|
||
return p1.get() == p2.get();
|
||
}
|
||
|
||
template<typename T> inline bool operator ==(VclPtr<T> const & p1, T const * p2)
|
||
{
|
||
return p1.get() == p2;
|
||
}
|
||
|
||
template<typename T> inline bool operator ==(VclPtr<T> const & p1, T * p2) {
|
||
return p1.get() == p2;
|
||
}
|
||
|
||
template<typename T> inline bool operator ==(T const * p1, VclPtr<T> const & p2)
|
||
{
|
||
return p1 == p2.get();
|
||
}
|
||
|
||
template<typename T> inline bool operator ==(T * p1, VclPtr<T> const & p2) {
|
||
return p1 == p2.get();
|
||
}
|
||
|
||
/**
|
||
* A construction helper for a temporary VclPtr. Since VclPtr types
|
||
* are created with a reference-count of one - to help fit into
|
||
* the existing code-flow; this helps us to construct them easily.
|
||
* see also VclPtr::Create and ScopedVclPtr
|
||
*
|
||
* For more details on the design please see vcl/README.lifecycle
|
||
*
|
||
* @param reference_type must be a subclass of vcl::Window
|
||
*/
|
||
template <class reference_type>
|
||
class SAL_WARN_UNUSED VclPtrInstance final : public VclPtr<reference_type>
|
||
{
|
||
public:
|
||
template<typename... Arg> VclPtrInstance(Arg &&... arg)
|
||
: VclPtr<reference_type>( new reference_type(std::forward<Arg>(arg)...), SAL_NO_ACQUIRE )
|
||
{
|
||
}
|
||
|
||
/**
|
||
* Override and disallow this, to prevent people accidentally calling it and actually
|
||
* getting VclPtr::Create and getting a naked VclPtr<> instance
|
||
*/
|
||
template<typename... Arg> static VclPtrInstance< reference_type > Create(Arg &&... ) = delete;
|
||
};
|
||
|
||
template <class reference_type>
|
||
class ScopedVclPtr : public VclPtr<reference_type>
|
||
{
|
||
public:
|
||
/** Constructor...
|
||
*/
|
||
using VclPtr<reference_type>::VclPtr;
|
||
|
||
/** Copy constructor...
|
||
*/
|
||
ScopedVclPtr (const VclPtr<reference_type> & handle)
|
||
: VclPtr<reference_type>(handle)
|
||
{}
|
||
|
||
/**
|
||
Assignment that releases the last reference.
|
||
*/
|
||
void disposeAndReset(reference_type *pBody)
|
||
{
|
||
if (pBody != this->get()) {
|
||
VclPtr<reference_type>::disposeAndClear();
|
||
VclPtr<reference_type>::reset(pBody);
|
||
}
|
||
}
|
||
|
||
/**
|
||
Assignment that releases the last reference.
|
||
*/
|
||
ScopedVclPtr& operator = (reference_type * pBody)
|
||
{
|
||
disposeAndReset(pBody);
|
||
return *this;
|
||
}
|
||
|
||
/** Up-casting assignment operator.
|
||
|
||
Does not work for up-casts to ambiguous bases.
|
||
|
||
@param rRef another VclPtr
|
||
*/
|
||
template<typename derived_type>
|
||
requires std::is_base_of_v<reference_type, derived_type>
|
||
ScopedVclPtr& operator =(VclPtr<derived_type> const& rRef)
|
||
{
|
||
return operator=(rRef.get());
|
||
}
|
||
|
||
/**
|
||
* Override and disallow this, to prevent people accidentally calling it and actually
|
||
* getting VclPtr::Create and getting a naked VclPtr<> instance
|
||
*/
|
||
template<typename... Arg> static ScopedVclPtr< reference_type > Create(Arg &&... ) = delete;
|
||
|
||
~ScopedVclPtr()
|
||
{
|
||
VclPtr<reference_type>::disposeAndClear();
|
||
assert(VclPtr<reference_type>::get() == nullptr); // make sure there are no lingering references
|
||
}
|
||
|
||
private:
|
||
// Most likely we don't want this default copy-constructor.
|
||
ScopedVclPtr (const ScopedVclPtr<reference_type> &) = delete;
|
||
// And certainly we don't want a default assignment operator.
|
||
ScopedVclPtr<reference_type>& operator = (const ScopedVclPtr<reference_type> &) = delete;
|
||
// And disallow reset as that doesn't call disposeAndClear on the original reference
|
||
void reset() = delete;
|
||
void reset(reference_type *pBody) = delete;
|
||
|
||
protected:
|
||
ScopedVclPtr (reference_type * pBody, __sal_NoAcquire)
|
||
: VclPtr<reference_type>(pBody, SAL_NO_ACQUIRE)
|
||
{}
|
||
};
|
||
|
||
/**
|
||
* A construction helper for ScopedVclPtr. Since VclPtr types are created
|
||
* with a reference-count of one - to help fit into the existing
|
||
* code-flow; this helps us to construct them easily.
|
||
*
|
||
* For more details on the design please see vcl/README.lifecycle
|
||
*
|
||
* @param reference_type must be a subclass of vcl::Window
|
||
*/
|
||
#if defined _MSC_VER
|
||
#pragma warning(push)
|
||
#pragma warning(disable: 4521) // " multiple copy constructors specified"
|
||
#endif
|
||
template <class reference_type>
|
||
class SAL_WARN_UNUSED ScopedVclPtrInstance final : public ScopedVclPtr<reference_type>
|
||
{
|
||
public:
|
||
template<typename... Arg> ScopedVclPtrInstance(Arg &&... arg)
|
||
: ScopedVclPtr<reference_type>( new reference_type(std::forward<Arg>(arg)...), SAL_NO_ACQUIRE )
|
||
{
|
||
}
|
||
|
||
/**
|
||
* Override and disallow this, to prevent people accidentally calling it and actually
|
||
* getting VclPtr::Create and getting a naked VclPtr<> instance
|
||
*/
|
||
template<typename... Arg> static ScopedVclPtrInstance< reference_type > Create(Arg &&...) = delete;
|
||
|
||
private:
|
||
// Prevent the above perfect forwarding ctor from hijacking (accidental)
|
||
// attempts at ScopedVclPtrInstance copy construction (where the hijacking
|
||
// would typically lead to somewhat obscure error messages); both non-const
|
||
// and const variants are needed here, as the ScopedVclPtr base class has a
|
||
// const--variant copy ctor, so the implicitly declared copy ctor for
|
||
// ScopedVclPtrInstance would also be the const variant, so non-const copy
|
||
// construction attempts would be hijacked by the perfect forwarding ctor;
|
||
// but if we only declared a non-const variant here, the const variant would
|
||
// no longer be implicitly declared (as there would already be an explicitly
|
||
// declared copy ctor), so const copy construction attempts would then be
|
||
// hijacked by the perfect forwarding ctor:
|
||
ScopedVclPtrInstance(ScopedVclPtrInstance &) = delete;
|
||
ScopedVclPtrInstance(ScopedVclPtrInstance const &) = delete;
|
||
};
|
||
#if defined _MSC_VER
|
||
#pragma warning(pop)
|
||
#endif
|
||
|
||
#endif // INCLUDED_VCL_PTR_HXX
|
||
|
||
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|