mirror of
https://github.com/LibreOffice/core.git
synced 2025-08-11 23:24:16 +00:00
5f3c2204eb
...finding dubious additions to namespace std (concentrating on functions for now). C++17 [namespace.std]/1: "The behavior of a C ++ program is undefined if it adds declarations or definitions to namespace std or to a namespace within namespace std unless otherwise specified." This foundad4c7b9775"Avoid declaring function templates in namespace std"042e30a3dc"Avoid adding a function template declaration to namespace std"cae9240a76"Avoid adding a function declaration to namespace std" Change-Id: Ic2ba54e2a8bf931d5c58cedf499c0d1229eb2166 Reviewed-on: https://gerrit.libreoffice.org/78220 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
57 lines
1.4 KiB
C++
57 lines
1.4 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <iterator>
|
|
#include <vector>
|
|
|
|
struct S
|
|
{
|
|
bool empty() const;
|
|
};
|
|
|
|
template <typename> struct ST
|
|
{
|
|
bool empty() const;
|
|
};
|
|
|
|
namespace std
|
|
{
|
|
bool empty( //expected-error {{Do not declare a function in namespace 'std' [loplugin:stdfunction]}}
|
|
S const&);
|
|
|
|
template <>
|
|
bool empty( //expected-error {{Do not declare a function template specialization in namespace 'std' [loplugin:stdfunction]}}
|
|
S const&);
|
|
|
|
template <typename T>
|
|
bool empty( //expected-error {{Do not declare a function template in namespace 'std' [loplugin:stdfunction]}}
|
|
ST<T> const&);
|
|
|
|
template <> class vector<S>
|
|
{
|
|
public:
|
|
[[nodiscard]] constexpr bool empty() const noexcept;
|
|
};
|
|
|
|
[[nodiscard]] constexpr bool vector<S>::empty() const noexcept { return true; }
|
|
}
|
|
|
|
namespace std::inner
|
|
{
|
|
bool empty( //expected-error {{Do not declare a function in namespace 'std' [loplugin:stdfunction]}}
|
|
S const&);
|
|
}
|
|
|
|
namespace outer::std
|
|
{
|
|
bool empty(S const&);
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|