mirror of
https://github.com/LibreOffice/core.git
synced 2025-08-21 21:54:15 +00:00
1b9da9b634
Doing so was likely inspired by the fact that in
GTK 3, GtkRadioButton subclasses GtkCheckButton.
In GTK 4, the two have been merged into GtkCheckButton,
and neither the VCL nor the Qt implementation has
any such inheritance for the implementations.
Drop it and instead explicitly define the 3 methods
both have in common in addition to the weld::Toggleable
base class methods.
With previous commit
Change-Id: I8de7add52f3ff4275fe8c7f077d4ac84a0a07e39
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jul 16 19:52:54 2025 +0200
tdf#130857 weld: Make indeterminate logic specific to CheckButton
in place, this also means that there is no more need to
have dummy implementations/overrides for the
weld::CheckButton::set_inconsistent/
weld::CheckButton::get_inconsistent base class
methods, with the inconsistent state not actually
being supported, as having such methods is no
longer mandated by a base class.
Switch the few callers of (the now no more existing)
weld::RadioButton::set_state to use weld::Toggleable::set_active
instead.
This cleans up the API a bit and prevents from any accidental
attempt to set the unsupported TRISTATE_INDET state for radio
buttons.
Change-Id: Iefa7d03a1380861f3936e797592d6c461ff3ff2a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188004
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>