mirror of
https://github.com/LibreOffice/core.git
synced 2025-08-14 07:48:39 +00:00
5b8f9514a3
...in CompilerTest_compilerplugins_clang, > [CPT] compilerplugins/clang/test/fragiledestructor.cxx > error: 'expected-error' diagnostics expected but not seen: > File compilerplugins/clang/test/fragiledestructor.cxx Line 26 (directive at compilerplugins/clang/test/fragiledestructor.cxx:27): calling virtual method from destructor, either make the virtual method final, or make this class final [loplugin:fragiledestructor] > File compilerplugins/clang/test/fragiledestructor.cxx Line 53 (directive at compilerplugins/clang/test/fragiledestructor.cxx:54): calling virtual method from destructor, either make the virtual method final, or make this class final [loplugin:fragiledestructor] > error: 'expected-error' diagnostics seen but not expected: > File compilerplugins/clang/test/fragiledestructor.cxx Line 39: virtual method 'f' is inside a 'final' class and can never be overridden > error: 'expected-note' diagnostics expected but not seen: > File compilerplugins/clang/test/fragiledestructor.cxx Line 28 (directive at compilerplugins/clang/test/fragiledestructor.cxx:29): callee method here [loplugin:fragiledestructor] > File compilerplugins/clang/test/fragiledestructor.cxx Line 48 (directive at compilerplugins/clang/test/fragiledestructor.cxx:49): callee method here [loplugin:fragiledestructor] Change-Id: Ie6484149b902e217a54b7b9423627e608d349d15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185221 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
92 lines
1.8 KiB
C++
92 lines
1.8 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include "sal/config.h"
|
|
|
|
// no warning expected
|
|
namespace test1
|
|
{
|
|
class Foo
|
|
{
|
|
~Foo() { f(); }
|
|
void f();
|
|
};
|
|
}
|
|
|
|
namespace test2
|
|
{
|
|
class Foo
|
|
{
|
|
~Foo() { f(); }
|
|
// expected-error@-1 {{calling virtual method from destructor, either make the virtual method final, or make this class final [loplugin:fragiledestructor]}}
|
|
virtual void f();
|
|
// expected-note@-1 {{callee method here [loplugin:fragiledestructor]}}
|
|
};
|
|
}
|
|
|
|
// no warning expected
|
|
namespace test3
|
|
{
|
|
class Foo final
|
|
{
|
|
~Foo() { f(); }
|
|
#if __has_warning("-Wunnecessary-virtual-specifier")
|
|
#pragma clang diagnostic ignored "-Wunnecessary-virtual-specifier"
|
|
#endif
|
|
virtual void f();
|
|
};
|
|
}
|
|
|
|
namespace test4
|
|
{
|
|
struct Bar
|
|
{
|
|
virtual ~Bar();
|
|
virtual void f();
|
|
// expected-note@-1 {{callee method here [loplugin:fragiledestructor]}}
|
|
};
|
|
class Foo : public Bar
|
|
{
|
|
~Foo() { f(); }
|
|
// expected-error@-1 {{calling virtual method from destructor, either make the virtual method final, or make this class final [loplugin:fragiledestructor]}}
|
|
};
|
|
}
|
|
|
|
// no warning expected
|
|
namespace test5
|
|
{
|
|
struct Bar
|
|
{
|
|
virtual ~Bar();
|
|
virtual void f();
|
|
};
|
|
class Foo : public Bar
|
|
{
|
|
~Foo() { f(); }
|
|
virtual void f() final override;
|
|
};
|
|
}
|
|
|
|
// no warning expected
|
|
namespace test6
|
|
{
|
|
struct Bar
|
|
{
|
|
virtual ~Bar();
|
|
virtual void f();
|
|
};
|
|
class Foo : public Bar
|
|
{
|
|
~Foo() { Foo::f(); }
|
|
virtual void f() override;
|
|
};
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|