mirror of
https://github.com/LibreOffice/core.git
synced 2025-08-15 20:47:46 +00:00

This change aims to avoid special-casing when dispatching commands from
LokChartHelper. It builds upon I883c6a6905e78da0c083323b5ef641fa27f133b4
and I2bc8cecfc4f38d66121d9a39313b37a51d7f0aff.
Before this patch, commands passed through LokChartHelper were directly
dispatched using ChartController::dispatch, instead of finding correct
dispatcher using queryDispatch. That required ChartController::dispatch
to handle the commands that it wasn't intended to handle; e.g., commit
9126cde8cb
(When chart is active pass
uno:ChangeTheme through to its parent frame, 2024-01-29) added that
special processing.
Now we can use the normal queryDispatch mechanism to find the correct
dispather, and revert the mentioned change.
Change-Id: I5c3231690f8a7a2bb7b83ced90f18866f9b2deb3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187368
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Chart Implementation for LibreOffice Calc
The chart2
denotes a second generation re-write done to rid us of the
foul and twisted legacy chart code.
Debugging
Shortcuts
CTRL + F12 creates a layout dump based on the XShapeDumper
based on SAL_WARN("chart2", ...