mirror of
https://github.com/LibreOffice/core.git
synced 2025-08-11 23:24:16 +00:00
8611f6e259
Which means we can get rid of the majestic hack of ScCaptionPtr Previously, SdrObject was manually managed, and the ownership passed around in very complicated fashion. Notes: (*) SvxShape has a strong reference to SdrObject, where previously it had a weak reference. It is now strong since otherwise the SdrObject will go away very eagerly. (*) SdrObject still has a weak reference to SvxShape (*) In the existing places that an SdrObject is being deleted, we now just clear the reference (*) instead of SwVirtFlyDrawObj removing itself from the page that contains inside it's destructor, make the call site do the removing from the page. (*) Needed to take the SolarMutex in UndoManagerHelper_Impl::impl_clear because this can be called from UNO (e.g. sfx2_complex JUnit test) and the SdrObjects need the SolarMutex when destructing. (*) handle a tricky situation with SwDrawVirtObj in the SwDrawModel destructor because the existing code wants mpDrawObj in SwAnchoredObject to be sometimes owning, sometimes not, which results in a cycle with the new code. Change-Id: I4d79df1660e386388e5d51030653755bca02a163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
86 lines
2.0 KiB
C++
86 lines
2.0 KiB
C++
|
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* Based on LLVM/Clang.
|
|
*
|
|
* This file is distributed under the University of Illinois Open Source
|
|
* License. See LICENSE.TXT for details.
|
|
*
|
|
*/
|
|
#ifndef LO_CLANG_SHARED_PLUGINS
|
|
|
|
#include <cassert>
|
|
#include <string>
|
|
#include <iostream>
|
|
#include <fstream>
|
|
#include <set>
|
|
#include <unordered_set>
|
|
#include "plugin.hxx"
|
|
#include "check.hxx"
|
|
|
|
/*
|
|
Check for places where we end up with more than one copy of cppu::OweakObject in a class, which
|
|
really should not happen - we should be using one of the AggImplInheritanceHelper classes then
|
|
to inherit.
|
|
*/
|
|
|
|
namespace
|
|
{
|
|
class WeakObject : public loplugin::FilteringPlugin<WeakObject>
|
|
{
|
|
public:
|
|
explicit WeakObject(loplugin::InstantiationData const& data)
|
|
: FilteringPlugin(data)
|
|
{
|
|
}
|
|
|
|
virtual bool preRun() override
|
|
{
|
|
return true;
|
|
}
|
|
|
|
virtual void run() override
|
|
{
|
|
if (preRun())
|
|
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
|
|
}
|
|
|
|
bool VisitCXXRecordDecl( const CXXRecordDecl* decl);
|
|
|
|
};
|
|
|
|
bool WeakObject::VisitCXXRecordDecl(const CXXRecordDecl* decl)
|
|
{
|
|
if (ignoreLocation(decl))
|
|
return true;
|
|
if (!decl->hasDefinition())
|
|
return true;
|
|
if (decl->hasAnyDependentBases())
|
|
return true;
|
|
int cnt = 0;
|
|
decl->forallBases(
|
|
[&cnt] (const CXXRecordDecl *BaseDefinition) -> bool
|
|
{
|
|
if (loplugin::DeclCheck(BaseDefinition).Class("OWeakObject").Namespace("cppu").GlobalNamespace())
|
|
++cnt;
|
|
return true;
|
|
});
|
|
if (cnt < 2)
|
|
return true;
|
|
|
|
report(DiagnosticsEngine::Warning, "more than one copy of cppu::OWeakObject inherited",
|
|
decl->getBeginLoc())
|
|
<< decl->getSourceRange();
|
|
return true;
|
|
}
|
|
|
|
loplugin::Plugin::Registration<WeakObject> weakobject("weakobject", false);
|
|
|
|
} // namespace
|
|
|
|
#endif // LO_CLANG_SHARED_PLUGINS
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|